diff options
| author | Rob Mensching <rob@firegiant.com> | 2020-01-13 14:41:17 -0800 |
|---|---|---|
| committer | Rob Mensching <rob@firegiant.com> | 2020-02-05 16:15:47 -0800 |
| commit | 6e2e67ab55c75f4655397588c0dcc64f50d22f92 (patch) | |
| tree | 01290e7b07ec6e4e4384e8fed568f14283f65d61 /src/WixToolset.Core.WindowsInstaller/WindowsInstallerStandardInternal.cs | |
| parent | c9c3ab2776252d3131fea561bd3f3fac8c045f5e (diff) | |
| download | wix-6e2e67ab55c75f4655397588c0dcc64f50d22f92.tar.gz wix-6e2e67ab55c75f4655397588c0dcc64f50d22f92.tar.bz2 wix-6e2e67ab55c75f4655397588c0dcc64f50d22f92.zip | |
Remove WixActionRowCollection and duplicate actions.xml
Diffstat (limited to 'src/WixToolset.Core.WindowsInstaller/WindowsInstallerStandardInternal.cs')
| -rw-r--r-- | src/WixToolset.Core.WindowsInstaller/WindowsInstallerStandardInternal.cs | 30 |
1 files changed, 2 insertions, 28 deletions
diff --git a/src/WixToolset.Core.WindowsInstaller/WindowsInstallerStandardInternal.cs b/src/WixToolset.Core.WindowsInstaller/WindowsInstallerStandardInternal.cs index 759bda14..33f1ba04 100644 --- a/src/WixToolset.Core.WindowsInstaller/WindowsInstallerStandardInternal.cs +++ b/src/WixToolset.Core.WindowsInstaller/WindowsInstallerStandardInternal.cs | |||
| @@ -2,10 +2,8 @@ | |||
| 2 | 2 | ||
| 3 | namespace WixToolset.Core.WindowsInstaller | 3 | namespace WixToolset.Core.WindowsInstaller |
| 4 | { | 4 | { |
| 5 | using System; | ||
| 6 | using System.Reflection; | 5 | using System.Reflection; |
| 7 | using System.Xml; | 6 | using System.Xml; |
| 8 | using WixToolset.Core.WindowsInstaller.Rows; | ||
| 9 | using WixToolset.Data.WindowsInstaller; | 7 | using WixToolset.Data.WindowsInstaller; |
| 10 | 8 | ||
| 11 | /// <summary> | 9 | /// <summary> |
| @@ -16,9 +14,6 @@ namespace WixToolset.Core.WindowsInstaller | |||
| 16 | private static readonly object lockObject = new object(); | 14 | private static readonly object lockObject = new object(); |
| 17 | 15 | ||
| 18 | private static TableDefinitionCollection tableDefinitions; | 16 | private static TableDefinitionCollection tableDefinitions; |
| 19 | #if REVISIT_FOR_PATCHING | ||
| 20 | private static WixActionRowCollection standardActions; | ||
| 21 | #endif | ||
| 22 | 17 | ||
| 23 | /// <summary> | 18 | /// <summary> |
| 24 | /// Gets the table definitions stored in this assembly. | 19 | /// Gets the table definitions stored in this assembly. |
| @@ -26,6 +21,8 @@ namespace WixToolset.Core.WindowsInstaller | |||
| 26 | /// <returns>Table definition collection for tables stored in this assembly.</returns> | 21 | /// <returns>Table definition collection for tables stored in this assembly.</returns> |
| 27 | public static TableDefinitionCollection GetTableDefinitions() | 22 | public static TableDefinitionCollection GetTableDefinitions() |
| 28 | { | 23 | { |
| 24 | // TODO: make the data static data structures instead of parsing an XML file and consider | ||
| 25 | // moving it all to WixToolset.Data.WindowsInstallerStandard class. | ||
| 29 | lock (lockObject) | 26 | lock (lockObject) |
| 30 | { | 27 | { |
| 31 | if (null == WindowsInstallerStandardInternal.tableDefinitions) | 28 | if (null == WindowsInstallerStandardInternal.tableDefinitions) |
| @@ -39,28 +36,5 @@ namespace WixToolset.Core.WindowsInstaller | |||
| 39 | 36 | ||
| 40 | return WindowsInstallerStandardInternal.tableDefinitions; | 37 | return WindowsInstallerStandardInternal.tableDefinitions; |
| 41 | } | 38 | } |
| 42 | |||
| 43 | /// <summary> | ||
| 44 | /// Gets the standard actions stored in this assembly. | ||
| 45 | /// </summary> | ||
| 46 | /// <returns>Collection of standard actions in this assembly.</returns> | ||
| 47 | public static WixActionRowCollection GetStandardActionRows() | ||
| 48 | { | ||
| 49 | #if REVISIT_FOR_PATCHING | ||
| 50 | lock (lockObject) | ||
| 51 | { | ||
| 52 | if (null == WindowsInstallerStandardInternal.standardActions) | ||
| 53 | { | ||
| 54 | using (XmlReader reader = XmlReader.Create(Assembly.GetExecutingAssembly().GetManifestResourceStream("WixToolset.Core.WindowsInstaller.Data.actions.xml"))) | ||
| 55 | { | ||
| 56 | WindowsInstallerStandardInternal.standardActions = WixActionRowCollection.Load(reader); | ||
| 57 | } | ||
| 58 | } | ||
| 59 | } | ||
| 60 | |||
| 61 | return WindowsInstallerStandardInternal.standardActions; | ||
| 62 | #endif | ||
| 63 | throw new NotImplementedException(); | ||
| 64 | } | ||
| 65 | } | 39 | } |
| 66 | } | 40 | } |
