diff options
| author | Rob Mensching <rob@firegiant.com> | 2020-07-05 23:26:48 -0700 |
|---|---|---|
| committer | Rob Mensching <rob@firegiant.com> | 2020-07-08 15:18:09 -0700 |
| commit | b8bd03960b79e92d38ee7094a88e246253dad800 (patch) | |
| tree | 89fec2cf4003832110bcbdd0633c8dcd492efd54 /src/WixToolset.Core.WindowsInstaller | |
| parent | 7b583330fd42356930bdc5a28820e546f6ca45a4 (diff) | |
| download | wix-b8bd03960b79e92d38ee7094a88e246253dad800.tar.gz wix-b8bd03960b79e92d38ee7094a88e246253dad800.tar.bz2 wix-b8bd03960b79e92d38ee7094a88e246253dad800.zip | |
Improve compiler performance by removing regex and other string fixes
Diffstat (limited to 'src/WixToolset.Core.WindowsInstaller')
| -rw-r--r-- | src/WixToolset.Core.WindowsInstaller/Unbind/UnbindDatabaseCommand.cs | 11 |
1 files changed, 6 insertions, 5 deletions
diff --git a/src/WixToolset.Core.WindowsInstaller/Unbind/UnbindDatabaseCommand.cs b/src/WixToolset.Core.WindowsInstaller/Unbind/UnbindDatabaseCommand.cs index d5601fad..36172b5e 100644 --- a/src/WixToolset.Core.WindowsInstaller/Unbind/UnbindDatabaseCommand.cs +++ b/src/WixToolset.Core.WindowsInstaller/Unbind/UnbindDatabaseCommand.cs | |||
| @@ -226,11 +226,12 @@ namespace WixToolset.Core.WindowsInstaller.Unbind | |||
| 226 | value = value.Replace("$(", "$$("); | 226 | value = value.Replace("$(", "$$("); |
| 227 | 227 | ||
| 228 | // escape things that look like wix variables | 228 | // escape things that look like wix variables |
| 229 | var matches = Common.WixVariableRegex.Matches(value); | 229 | // TODO: Evaluate this requirement. |
| 230 | for (var j = matches.Count - 1; 0 <= j; j--) | 230 | //var matches = Common.WixVariableRegex.Matches(value); |
| 231 | { | 231 | //for (var j = matches.Count - 1; 0 <= j; j--) |
| 232 | value = value.Insert(matches[j].Index, "!"); | 232 | //{ |
| 233 | } | 233 | // value = value.Insert(matches[j].Index, "!"); |
| 234 | //} | ||
| 234 | 235 | ||
| 235 | row[i] = value; | 236 | row[i] = value; |
| 236 | break; | 237 | break; |