aboutsummaryrefslogtreecommitdiff
path: root/src/WixToolset.Core
diff options
context:
space:
mode:
authorRob Mensching <rob@firegiant.com>2021-03-16 10:52:55 -0700
committerRob Mensching <rob@firegiant.com>2021-03-16 11:07:44 -0700
commit0d4df529a7e34f033112a1c6f16f749880334e7d (patch)
tree4c472f0f49ef732951f211221aa0524706523146 /src/WixToolset.Core
parent60f75abcd1fe49052c118a2597ac59a82c372b64 (diff)
downloadwix-0d4df529a7e34f033112a1c6f16f749880334e7d.tar.gz
wix-0d4df529a7e34f033112a1c6f16f749880334e7d.tar.bz2
wix-0d4df529a7e34f033112a1c6f16f749880334e7d.zip
Use validation now implemented in Core.Native
Fixes wixtoolset/issues#5946
Diffstat (limited to 'src/WixToolset.Core')
-rw-r--r--src/WixToolset.Core/CommandLine/BuildCommand.cs28
1 files changed, 24 insertions, 4 deletions
diff --git a/src/WixToolset.Core/CommandLine/BuildCommand.cs b/src/WixToolset.Core/CommandLine/BuildCommand.cs
index baca91ba..eda93f31 100644
--- a/src/WixToolset.Core/CommandLine/BuildCommand.cs
+++ b/src/WixToolset.Core/CommandLine/BuildCommand.cs
@@ -344,14 +344,14 @@ namespace WixToolset.Core.CommandLine
344 context.ExpectedEmbeddedFiles = resolveResult.ExpectedEmbeddedFiles; 344 context.ExpectedEmbeddedFiles = resolveResult.ExpectedEmbeddedFiles;
345 context.Extensions = this.ExtensionManager.GetServices<IBinderExtension>(); 345 context.Extensions = this.ExtensionManager.GetServices<IBinderExtension>();
346 context.FileSystemExtensions = this.ExtensionManager.GetServices<IFileSystemExtension>(); 346 context.FileSystemExtensions = this.ExtensionManager.GetServices<IFileSystemExtension>();
347 context.Ices = Array.Empty<string>(); // TODO: set this correctly 347 context.Ices = this.commandLine.Ices;
348 context.IntermediateFolder = intermediateFolder; 348 context.IntermediateFolder = intermediateFolder;
349 context.IntermediateRepresentation = resolveResult.IntermediateRepresentation; 349 context.IntermediateRepresentation = resolveResult.IntermediateRepresentation;
350 context.OutputPath = this.OutputFile; 350 context.OutputPath = this.OutputFile;
351 context.PdbType = this.PdbType; 351 context.PdbType = this.PdbType;
352 context.PdbPath = this.PdbType == PdbType.None ? null : this.PdbFile ?? Path.ChangeExtension(this.OutputFile, ".wixpdb"); 352 context.PdbPath = this.PdbType == PdbType.None ? null : this.PdbFile ?? Path.ChangeExtension(this.OutputFile, ".wixpdb");
353 context.SuppressIces = Array.Empty<string>(); // TODO: set this correctly 353 context.SuppressIces = this.commandLine.SuppressIces;
354 context.SuppressValidation = true; // TODO: set this correctly 354 context.SuppressValidation = this.commandLine.SuppressValidation;
355 context.CancellationToken = cancellationToken; 355 context.CancellationToken = cancellationToken;
356 356
357 var binder = this.ServiceProvider.GetService<IBinder>(); 357 var binder = this.ServiceProvider.GetService<IBinder>();
@@ -541,6 +541,12 @@ namespace WixToolset.Core.CommandLine
541 541
542 public string BuiltOutputsFile { get; private set; } 542 public string BuiltOutputsFile { get; private set; }
543 543
544 public List<string> Ices { get; } = new List<string>();
545
546 public List<string> SuppressIces { get; } = new List<string>();
547
548 public bool SuppressValidation { get; set; }
549
544 public CommandLine(IServiceProvider serviceProvider, IMessaging messaging) 550 public CommandLine(IServiceProvider serviceProvider, IMessaging messaging)
545 { 551 {
546 this.ServiceProvider = serviceProvider; 552 this.ServiceProvider = serviceProvider;
@@ -634,6 +640,13 @@ namespace WixToolset.Core.CommandLine
634 parser.GetNextArgumentOrError(arg, this.IncludeSearchPaths); 640 parser.GetNextArgumentOrError(arg, this.IncludeSearchPaths);
635 return true; 641 return true;
636 642
643 case "ice":
644 {
645 var value = parser.GetNextArgumentOrError(arg);
646 this.Ices.Add(value);
647 return true;
648 }
649
637 case "intermediatefolder": 650 case "intermediatefolder":
638 this.IntermediateFolder = parser.GetNextArgumentAsDirectoryOrError(arg); 651 this.IntermediateFolder = parser.GetNextArgumentAsDirectoryOrError(arg);
639 return true; 652 return true;
@@ -670,6 +683,13 @@ namespace WixToolset.Core.CommandLine
670 return false; 683 return false;
671 } 684 }
672 685
686 case "sice":
687 {
688 var value = parser.GetNextArgumentOrError(arg);
689 this.SuppressIces.Add(value);
690 return true;
691 }
692
673 case "nologo": 693 case "nologo":
674 this.ShowLogo = false; 694 this.ShowLogo = false;
675 return true; 695 return true;
@@ -680,7 +700,7 @@ namespace WixToolset.Core.CommandLine
680 return true; 700 return true;
681 701
682 case "sval": 702 case "sval":
683 // todo: implement 703 this.SuppressValidation = true;
684 return true; 704 return true;
685 } 705 }
686 706