aboutsummaryrefslogtreecommitdiff
path: root/src/WixToolset.Core
diff options
context:
space:
mode:
authorRob Mensching <rob@firegiant.com>2019-11-05 22:33:33 -0800
committerRob Mensching <rob@firegiant.com>2019-11-05 22:39:16 -0800
commit97a70bbc1b90cb26f8c77d83e703689d15d08761 (patch)
treec4d05ae10cb907f522c1df476cb1d5df7604cd14 /src/WixToolset.Core
parent0f65aaaca2faf1b6fc233c445216d547f08c6fa5 (diff)
downloadwix-97a70bbc1b90cb26f8c77d83e703689d15d08761.tar.gz
wix-97a70bbc1b90cb26f8c77d83e703689d15d08761.tar.bz2
wix-97a70bbc1b90cb26f8c77d83e703689d15d08761.zip
Fix resolution of !(bind.ProductVersion.MsiId) bind variables
Fixes wixtoolset/issues#4830
Diffstat (limited to 'src/WixToolset.Core')
-rw-r--r--src/WixToolset.Core/Bind/ResolveDelayedFieldsCommand.cs7
1 files changed, 3 insertions, 4 deletions
diff --git a/src/WixToolset.Core/Bind/ResolveDelayedFieldsCommand.cs b/src/WixToolset.Core/Bind/ResolveDelayedFieldsCommand.cs
index 22710aca..be0e4578 100644
--- a/src/WixToolset.Core/Bind/ResolveDelayedFieldsCommand.cs
+++ b/src/WixToolset.Core/Bind/ResolveDelayedFieldsCommand.cs
@@ -153,12 +153,11 @@ namespace WixToolset.Core.Bind
153 } 153 }
154 else 154 else
155 { 155 {
156 string key = String.Format(CultureInfo.InvariantCulture, "{0}.{1}", variableId, variableScope).ToLower(CultureInfo.InvariantCulture); 156 var key = String.Format(CultureInfo.InvariantCulture, "{0}.{1}", variableId, variableScope).ToLower(CultureInfo.InvariantCulture);
157 string resolvedValue = variableDefaultValue;
158 157
159 if (resolutionData.ContainsKey(key)) 158 if (!resolutionData.TryGetValue(key, out var resolvedValue))
160 { 159 {
161 resolvedValue = resolutionData[key]; 160 resolvedValue = variableDefaultValue;
162 } 161 }
163 162
164 if ("bind" == variableNamespace) 163 if ("bind" == variableNamespace)