diff options
| author | Bob Arnson <bob@firegiant.com> | 2019-11-04 13:15:39 -0500 |
|---|---|---|
| committer | Bob Arnson <bob@firegiant.com> | 2019-11-04 13:26:21 -0500 |
| commit | e6f381b0ce2011ced88697ca7ddaae8a053b57d7 (patch) | |
| tree | cae29c941c440e3b2284bd53171fefc034917987 /src/WixToolset.Core | |
| parent | 34e002b3a9043ff3062c676c74fb124b5feef784 (diff) | |
| download | wix-e6f381b0ce2011ced88697ca7ddaae8a053b57d7.tar.gz wix-e6f381b0ce2011ced88697ca7ddaae8a053b57d7.tar.bz2 wix-e6f381b0ce2011ced88697ca7ddaae8a053b57d7.zip | |
Tolerate missing RegistryValue/@Value when @Type="binary".
Diffstat (limited to 'src/WixToolset.Core')
| -rw-r--r-- | src/WixToolset.Core/Compiler_2.cs | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/WixToolset.Core/Compiler_2.cs b/src/WixToolset.Core/Compiler_2.cs index 10416850..2f578e61 100644 --- a/src/WixToolset.Core/Compiler_2.cs +++ b/src/WixToolset.Core/Compiler_2.cs | |||
| @@ -2006,11 +2006,11 @@ namespace WixToolset.Core | |||
| 2006 | //} | 2006 | //} |
| 2007 | 2007 | ||
| 2008 | // value may be set by child MultiStringValue elements, so it must be checked here | 2008 | // value may be set by child MultiStringValue elements, so it must be checked here |
| 2009 | if (null == value) | 2009 | if (null == value && valueType != RegistryValueType.Binary) |
| 2010 | { | 2010 | { |
| 2011 | this.Core.Write(ErrorMessages.ExpectedAttribute(sourceLineNumbers, node.Name.LocalName, "Value")); | 2011 | this.Core.Write(ErrorMessages.ExpectedAttribute(sourceLineNumbers, node.Name.LocalName, "Value")); |
| 2012 | } | 2012 | } |
| 2013 | else if (0 == value.Length && ("+" == name || "-" == name || "*" == name)) // prevent accidental authoring of special name values | 2013 | else if (0 == value?.Length && ("+" == name || "-" == name || "*" == name)) // prevent accidental authoring of special name values |
| 2014 | { | 2014 | { |
| 2015 | this.Core.Write(ErrorMessages.RegistryNameValueIncorrect(sourceLineNumbers, node.Name.LocalName, "Name", name)); | 2015 | this.Core.Write(ErrorMessages.RegistryNameValueIncorrect(sourceLineNumbers, node.Name.LocalName, "Name", name)); |
| 2016 | } | 2016 | } |