diff options
| author | Sean Hall <r.sean.hall@gmail.com> | 2021-12-30 15:32:57 -0600 |
|---|---|---|
| committer | Sean Hall <r.sean.hall@gmail.com> | 2021-12-30 18:40:49 -0600 |
| commit | 8dfadd0c9068965af138949b630ef8496b4f7bbb (patch) | |
| tree | 58bc40d5306d80a39712470aab0d5bf325eb3a45 /src/api/burn | |
| parent | 84a1b0f8ffe40a26916b1dfb3e1b59b6b0c31ad4 (diff) | |
| download | wix-8dfadd0c9068965af138949b630ef8496b4f7bbb.tar.gz wix-8dfadd0c9068965af138949b630ef8496b4f7bbb.tar.bz2 wix-8dfadd0c9068965af138949b630ef8496b4f7bbb.zip | |
Don't report related operation in OnDetectRelatedBundle.
#5796
Diffstat (limited to 'src/api/burn')
8 files changed, 4 insertions, 29 deletions
diff --git a/src/api/burn/WixToolset.BootstrapperCore.Native/inc/BootstrapperApplication.h b/src/api/burn/WixToolset.BootstrapperCore.Native/inc/BootstrapperApplication.h index c2641b5f..4fbfc890 100644 --- a/src/api/burn/WixToolset.BootstrapperCore.Native/inc/BootstrapperApplication.h +++ b/src/api/burn/WixToolset.BootstrapperCore.Native/inc/BootstrapperApplication.h | |||
| @@ -725,7 +725,6 @@ struct BA_ONDETECTRELATEDBUNDLE_ARGS | |||
| 725 | LPCWSTR wzBundleTag; | 725 | LPCWSTR wzBundleTag; |
| 726 | BOOL fPerMachine; | 726 | BOOL fPerMachine; |
| 727 | LPCWSTR wzVersion; | 727 | LPCWSTR wzVersion; |
| 728 | BOOTSTRAPPER_RELATED_OPERATION operation; | ||
| 729 | BOOL fMissingFromCache; | 728 | BOOL fMissingFromCache; |
| 730 | }; | 729 | }; |
| 731 | 730 | ||
diff --git a/src/api/burn/WixToolset.Mba.Core/BootstrapperApplication.cs b/src/api/burn/WixToolset.Mba.Core/BootstrapperApplication.cs index b1fcaea4..34b63a50 100644 --- a/src/api/burn/WixToolset.Mba.Core/BootstrapperApplication.cs +++ b/src/api/burn/WixToolset.Mba.Core/BootstrapperApplication.cs | |||
| @@ -1345,9 +1345,9 @@ namespace WixToolset.Mba.Core | |||
| 1345 | return args.HResult; | 1345 | return args.HResult; |
| 1346 | } | 1346 | } |
| 1347 | 1347 | ||
| 1348 | int IBootstrapperApplication.OnDetectRelatedBundle(string wzProductCode, RelationType relationType, string wzBundleTag, bool fPerMachine, string wzVersion, RelatedOperation operation, bool fMissingFromCache, ref bool fCancel) | 1348 | int IBootstrapperApplication.OnDetectRelatedBundle(string wzProductCode, RelationType relationType, string wzBundleTag, bool fPerMachine, string wzVersion, bool fMissingFromCache, ref bool fCancel) |
| 1349 | { | 1349 | { |
| 1350 | DetectRelatedBundleEventArgs args = new DetectRelatedBundleEventArgs(wzProductCode, relationType, wzBundleTag, fPerMachine, wzVersion, operation, fMissingFromCache, fCancel); | 1350 | DetectRelatedBundleEventArgs args = new DetectRelatedBundleEventArgs(wzProductCode, relationType, wzBundleTag, fPerMachine, wzVersion, fMissingFromCache, fCancel); |
| 1351 | this.OnDetectRelatedBundle(args); | 1351 | this.OnDetectRelatedBundle(args); |
| 1352 | 1352 | ||
| 1353 | fCancel = args.Cancel; | 1353 | fCancel = args.Cancel; |
diff --git a/src/api/burn/WixToolset.Mba.Core/EventArgs.cs b/src/api/burn/WixToolset.Mba.Core/EventArgs.cs index 65169b25..93831be6 100644 --- a/src/api/burn/WixToolset.Mba.Core/EventArgs.cs +++ b/src/api/burn/WixToolset.Mba.Core/EventArgs.cs | |||
| @@ -434,7 +434,7 @@ namespace WixToolset.Mba.Core | |||
| 434 | public class DetectRelatedBundleEventArgs : CancellableHResultEventArgs | 434 | public class DetectRelatedBundleEventArgs : CancellableHResultEventArgs |
| 435 | { | 435 | { |
| 436 | /// <summary /> | 436 | /// <summary /> |
| 437 | public DetectRelatedBundleEventArgs(string productCode, RelationType relationType, string bundleTag, bool perMachine, string version, RelatedOperation operation, bool missingFromCache, bool cancelRecommendation) | 437 | public DetectRelatedBundleEventArgs(string productCode, RelationType relationType, string bundleTag, bool perMachine, string version, bool missingFromCache, bool cancelRecommendation) |
| 438 | : base(cancelRecommendation) | 438 | : base(cancelRecommendation) |
| 439 | { | 439 | { |
| 440 | this.ProductCode = productCode; | 440 | this.ProductCode = productCode; |
| @@ -442,7 +442,6 @@ namespace WixToolset.Mba.Core | |||
| 442 | this.BundleTag = bundleTag; | 442 | this.BundleTag = bundleTag; |
| 443 | this.PerMachine = perMachine; | 443 | this.PerMachine = perMachine; |
| 444 | this.Version = version; | 444 | this.Version = version; |
| 445 | this.Operation = operation; | ||
| 446 | this.MissingFromCache = missingFromCache; | 445 | this.MissingFromCache = missingFromCache; |
| 447 | } | 446 | } |
| 448 | 447 | ||
| @@ -472,11 +471,6 @@ namespace WixToolset.Mba.Core | |||
| 472 | public string Version { get; private set; } | 471 | public string Version { get; private set; } |
| 473 | 472 | ||
| 474 | /// <summary> | 473 | /// <summary> |
| 475 | /// Gets the operation that will be taken on the detected bundle. | ||
| 476 | /// </summary> | ||
| 477 | public RelatedOperation Operation { get; private set; } | ||
| 478 | |||
| 479 | /// <summary> | ||
| 480 | /// Whether the related bundle is missing from the package cache. | 474 | /// Whether the related bundle is missing from the package cache. |
| 481 | /// </summary> | 475 | /// </summary> |
| 482 | public bool MissingFromCache { get; set; } | 476 | public bool MissingFromCache { get; set; } |
diff --git a/src/api/burn/WixToolset.Mba.Core/IBootstrapperApplication.cs b/src/api/burn/WixToolset.Mba.Core/IBootstrapperApplication.cs index 3df54bde..babd523a 100644 --- a/src/api/burn/WixToolset.Mba.Core/IBootstrapperApplication.cs +++ b/src/api/burn/WixToolset.Mba.Core/IBootstrapperApplication.cs | |||
| @@ -156,15 +156,6 @@ namespace WixToolset.Mba.Core | |||
| 156 | /// <summary> | 156 | /// <summary> |
| 157 | /// See <see cref="IDefaultBootstrapperApplication.DetectRelatedBundle"/>. | 157 | /// See <see cref="IDefaultBootstrapperApplication.DetectRelatedBundle"/>. |
| 158 | /// </summary> | 158 | /// </summary> |
| 159 | /// <param name="wzBundleId"></param> | ||
| 160 | /// <param name="relationType"></param> | ||
| 161 | /// <param name="wzBundleTag"></param> | ||
| 162 | /// <param name="fPerMachine"></param> | ||
| 163 | /// <param name="wzVersion"></param> | ||
| 164 | /// <param name="operation"></param> | ||
| 165 | /// <param name="fMissingFromCache"></param> | ||
| 166 | /// <param name="fCancel"></param> | ||
| 167 | /// <returns></returns> | ||
| 168 | [PreserveSig] | 159 | [PreserveSig] |
| 169 | [return: MarshalAs(UnmanagedType.I4)] | 160 | [return: MarshalAs(UnmanagedType.I4)] |
| 170 | int OnDetectRelatedBundle( | 161 | int OnDetectRelatedBundle( |
| @@ -173,7 +164,6 @@ namespace WixToolset.Mba.Core | |||
| 173 | [MarshalAs(UnmanagedType.LPWStr)] string wzBundleTag, | 164 | [MarshalAs(UnmanagedType.LPWStr)] string wzBundleTag, |
| 174 | [MarshalAs(UnmanagedType.Bool)] bool fPerMachine, | 165 | [MarshalAs(UnmanagedType.Bool)] bool fPerMachine, |
| 175 | [MarshalAs(UnmanagedType.LPWStr)] string wzVersion, | 166 | [MarshalAs(UnmanagedType.LPWStr)] string wzVersion, |
| 176 | [MarshalAs(UnmanagedType.U4)] RelatedOperation operation, | ||
| 177 | [MarshalAs(UnmanagedType.Bool)] bool fMissingFromCache, | 167 | [MarshalAs(UnmanagedType.Bool)] bool fMissingFromCache, |
| 178 | [MarshalAs(UnmanagedType.Bool)] ref bool fCancel | 168 | [MarshalAs(UnmanagedType.Bool)] ref bool fCancel |
| 179 | ); | 169 | ); |
| @@ -289,11 +279,6 @@ namespace WixToolset.Mba.Core | |||
| 289 | /// <summary> | 279 | /// <summary> |
| 290 | /// See <see cref="IDefaultBootstrapperApplication.PlanRelatedBundle"/>. | 280 | /// See <see cref="IDefaultBootstrapperApplication.PlanRelatedBundle"/>. |
| 291 | /// </summary> | 281 | /// </summary> |
| 292 | /// <param name="wzBundleId"></param> | ||
| 293 | /// <param name="recommendedState"></param> | ||
| 294 | /// <param name="pRequestedState"></param> | ||
| 295 | /// <param name="fCancel"></param> | ||
| 296 | /// <returns></returns> | ||
| 297 | [PreserveSig] | 282 | [PreserveSig] |
| 298 | [return: MarshalAs(UnmanagedType.I4)] | 283 | [return: MarshalAs(UnmanagedType.I4)] |
| 299 | int OnPlanRelatedBundle( | 284 | int OnPlanRelatedBundle( |
diff --git a/src/api/burn/balutil/inc/BalBaseBAFunctions.h b/src/api/burn/balutil/inc/BalBaseBAFunctions.h index 7f52f76e..22e16f1b 100644 --- a/src/api/burn/balutil/inc/BalBaseBAFunctions.h +++ b/src/api/burn/balutil/inc/BalBaseBAFunctions.h | |||
| @@ -167,7 +167,6 @@ public: // IBootstrapperApplication | |||
| 167 | __in_z LPCWSTR /*wzBundleTag*/, | 167 | __in_z LPCWSTR /*wzBundleTag*/, |
| 168 | __in BOOL /*fPerMachine*/, | 168 | __in BOOL /*fPerMachine*/, |
| 169 | __in LPCWSTR /*wzVersion*/, | 169 | __in LPCWSTR /*wzVersion*/, |
| 170 | __in BOOTSTRAPPER_RELATED_OPERATION /*operation*/, | ||
| 171 | __in BOOL /*fMissingFromCache*/, | 170 | __in BOOL /*fMissingFromCache*/, |
| 172 | __inout BOOL* /*pfCancel*/ | 171 | __inout BOOL* /*pfCancel*/ |
| 173 | ) | 172 | ) |
diff --git a/src/api/burn/balutil/inc/BalBaseBootstrapperApplication.h b/src/api/burn/balutil/inc/BalBaseBootstrapperApplication.h index 5665fee3..631d3c62 100644 --- a/src/api/burn/balutil/inc/BalBaseBootstrapperApplication.h +++ b/src/api/burn/balutil/inc/BalBaseBootstrapperApplication.h | |||
| @@ -172,7 +172,6 @@ public: // IBootstrapperApplication | |||
| 172 | __in_z LPCWSTR /*wzBundleTag*/, | 172 | __in_z LPCWSTR /*wzBundleTag*/, |
| 173 | __in BOOL /*fPerMachine*/, | 173 | __in BOOL /*fPerMachine*/, |
| 174 | __in LPCWSTR /*wzVersion*/, | 174 | __in LPCWSTR /*wzVersion*/, |
| 175 | __in BOOTSTRAPPER_RELATED_OPERATION /*operation*/, | ||
| 176 | __in BOOL /*fMissingFromCache*/, | 175 | __in BOOL /*fMissingFromCache*/, |
| 177 | __inout BOOL* pfCancel | 176 | __inout BOOL* pfCancel |
| 178 | ) | 177 | ) |
diff --git a/src/api/burn/balutil/inc/BalBaseBootstrapperApplicationProc.h b/src/api/burn/balutil/inc/BalBaseBootstrapperApplicationProc.h index 2292cd64..b9866e4b 100644 --- a/src/api/burn/balutil/inc/BalBaseBootstrapperApplicationProc.h +++ b/src/api/burn/balutil/inc/BalBaseBootstrapperApplicationProc.h | |||
| @@ -114,7 +114,7 @@ static HRESULT BalBaseBAProcOnDetectRelatedBundle( | |||
| 114 | __inout BA_ONDETECTRELATEDBUNDLE_RESULTS* pResults | 114 | __inout BA_ONDETECTRELATEDBUNDLE_RESULTS* pResults |
| 115 | ) | 115 | ) |
| 116 | { | 116 | { |
| 117 | return pBA->OnDetectRelatedBundle(pArgs->wzBundleId, pArgs->relationType, pArgs->wzBundleTag, pArgs->fPerMachine, pArgs->wzVersion, pArgs->operation, pArgs->fMissingFromCache, &pResults->fCancel); | 117 | return pBA->OnDetectRelatedBundle(pArgs->wzBundleId, pArgs->relationType, pArgs->wzBundleTag, pArgs->fPerMachine, pArgs->wzVersion, pArgs->fMissingFromCache, &pResults->fCancel); |
| 118 | } | 118 | } |
| 119 | 119 | ||
| 120 | static HRESULT BalBaseBAProcOnDetectPackageBegin( | 120 | static HRESULT BalBaseBAProcOnDetectPackageBegin( |
diff --git a/src/api/burn/balutil/inc/IBootstrapperApplication.h b/src/api/burn/balutil/inc/IBootstrapperApplication.h index 2ba1f503..577a705b 100644 --- a/src/api/burn/balutil/inc/IBootstrapperApplication.h +++ b/src/api/burn/balutil/inc/IBootstrapperApplication.h | |||
| @@ -91,7 +91,6 @@ DECLARE_INTERFACE_IID_(IBootstrapperApplication, IUnknown, "53C31D56-49C0-426B-A | |||
| 91 | __in_z LPCWSTR wzBundleTag, | 91 | __in_z LPCWSTR wzBundleTag, |
| 92 | __in BOOL fPerMachine, | 92 | __in BOOL fPerMachine, |
| 93 | __in_z LPCWSTR wzVersion, | 93 | __in_z LPCWSTR wzVersion, |
| 94 | __in BOOTSTRAPPER_RELATED_OPERATION operation, | ||
| 95 | __in BOOL fMissingFromCache, | 94 | __in BOOL fMissingFromCache, |
| 96 | __inout BOOL* pfCancel | 95 | __inout BOOL* pfCancel |
| 97 | ) = 0; | 96 | ) = 0; |
