aboutsummaryrefslogtreecommitdiff
path: root/src/api
diff options
context:
space:
mode:
authorSean Hall <r.sean.hall@gmail.com>2021-10-27 15:29:47 -0500
committerSean Hall <r.sean.hall@gmail.com>2021-11-01 16:34:09 -0500
commit3d73efba15565f5995a492e660dff72286e0b672 (patch)
treefc2364f88aed27d0bdf633f837c5b9ac29511760 /src/api
parentdce1c97c7d3e76c18e4f80d4ffe288d2933a74bc (diff)
downloadwix-3d73efba15565f5995a492e660dff72286e0b672.tar.gz
wix-3d73efba15565f5995a492e660dff72286e0b672.tar.bz2
wix-3d73efba15565f5995a492e660dff72286e0b672.zip
Remove dutil types from BAFunctions.
Diffstat (limited to 'src/api')
-rw-r--r--src/api/burn/balutil/inc/BAFunctions.h7
-rw-r--r--src/api/burn/balutil/inc/BalBaseBAFunctions.h30
-rw-r--r--src/api/burn/balutil/inc/BalBaseBAFunctionsProc.h4
-rw-r--r--src/api/burn/balutil/inc/IBAFunctions.h8
-rw-r--r--src/api/burn/test/BalUtilUnitTest/precomp.h2
5 files changed, 18 insertions, 33 deletions
diff --git a/src/api/burn/balutil/inc/BAFunctions.h b/src/api/burn/balutil/inc/BAFunctions.h
index 0eda95a1..149a12f8 100644
--- a/src/api/burn/balutil/inc/BAFunctions.h
+++ b/src/api/burn/balutil/inc/BAFunctions.h
@@ -178,8 +178,7 @@ struct BA_FUNCTIONS_ONTHEMECONTROLWMNOTIFY_RESULTS
178struct BA_FUNCTIONS_ONTHEMELOADED_ARGS 178struct BA_FUNCTIONS_ONTHEMELOADED_ARGS
179{ 179{
180 DWORD cbSize; 180 DWORD cbSize;
181 THEME* pTheme; 181 HWND hWnd;
182 WIX_LOCALIZATION* pWixLoc;
183}; 182};
184 183
185struct BA_FUNCTIONS_ONTHEMELOADED_RESULTS 184struct BA_FUNCTIONS_ONTHEMELOADED_RESULTS
@@ -190,7 +189,6 @@ struct BA_FUNCTIONS_ONTHEMELOADED_RESULTS
190struct BA_FUNCTIONS_WNDPROC_ARGS 189struct BA_FUNCTIONS_WNDPROC_ARGS
191{ 190{
192 DWORD cbSize; 191 DWORD cbSize;
193 THEME* pTheme;
194 HWND hWnd; 192 HWND hWnd;
195 UINT uMsg; 193 UINT uMsg;
196 WPARAM wParam; 194 WPARAM wParam;
@@ -200,7 +198,8 @@ struct BA_FUNCTIONS_WNDPROC_ARGS
200struct BA_FUNCTIONS_WNDPROC_RESULTS 198struct BA_FUNCTIONS_WNDPROC_RESULTS
201{ 199{
202 DWORD cbSize; 200 DWORD cbSize;
203 LRESULT lres; 201 BOOL fProcessed;
202 LRESULT lResult;
204}; 203};
205 204
206typedef HRESULT(WINAPI *PFN_BA_FUNCTIONS_CREATE)( 205typedef HRESULT(WINAPI *PFN_BA_FUNCTIONS_CREATE)(
diff --git a/src/api/burn/balutil/inc/BalBaseBAFunctions.h b/src/api/burn/balutil/inc/BalBaseBAFunctions.h
index d97df350..1493253b 100644
--- a/src/api/burn/balutil/inc/BalBaseBAFunctions.h
+++ b/src/api/burn/balutil/inc/BalBaseBAFunctions.h
@@ -5,9 +5,6 @@
5#include <windows.h> 5#include <windows.h>
6#include <msiquery.h> 6#include <msiquery.h>
7 7
8#include "dutil.h"
9#include "locutil.h"
10#include "thmutil.h"
11#include "BAFunctions.h" 8#include "BAFunctions.h"
12#include "IBAFunctions.h" 9#include "IBAFunctions.h"
13#include "BootstrapperEngine.h" 10#include "BootstrapperEngine.h"
@@ -803,32 +800,26 @@ public: // IBAFunctions
803 } 800 }
804 801
805 virtual STDMETHODIMP OnThemeLoaded( 802 virtual STDMETHODIMP OnThemeLoaded(
806 THEME* pTheme, 803 __in HWND hWnd
807 WIX_LOCALIZATION* pWixLoc
808 ) 804 )
809 { 805 {
810 HRESULT hr = S_OK; 806 HRESULT hr = S_OK;
811 807
812 m_pTheme = pTheme; 808 m_hwndParent = hWnd;
813 m_pWixLoc = pWixLoc;
814 809
815 return hr; 810 return hr;
816 } 811 }
817 812
818 virtual STDMETHODIMP WndProc( 813 virtual STDMETHODIMP WndProc(
819 __in THEME* pTheme, 814 __in HWND /*hWnd*/,
820 __in HWND hWnd, 815 __in UINT /*uMsg*/,
821 __in UINT uMsg, 816 __in WPARAM /*wParam*/,
822 __in WPARAM wParam, 817 __in LPARAM /*lParam*/,
823 __in LPARAM lParam, 818 __inout BOOL* /*pfProcessed*/,
824 __inout LRESULT* plRes 819 __inout LRESULT* /*plResult*/
825 ) 820 )
826 { 821 {
827 HRESULT hr = S_OK; 822 return S_OK;
828
829 *plRes = ThemeDefWindowProc(pTheme, hWnd, uMsg, wParam, lParam);
830
831 return hr;
832 } 823 }
833 824
834 virtual STDMETHODIMP BAFunctionsProc( 825 virtual STDMETHODIMP BAFunctionsProc(
@@ -917,6 +908,5 @@ protected:
917 BA_FUNCTIONS_CREATE_ARGS m_bafCreateArgs; 908 BA_FUNCTIONS_CREATE_ARGS m_bafCreateArgs;
918 BOOTSTRAPPER_CREATE_ARGS m_baCreateArgs; 909 BOOTSTRAPPER_CREATE_ARGS m_baCreateArgs;
919 BOOTSTRAPPER_COMMAND m_command; 910 BOOTSTRAPPER_COMMAND m_command;
920 THEME* m_pTheme; 911 HWND m_hwndParent;
921 WIX_LOCALIZATION* m_pWixLoc;
922}; 912};
diff --git a/src/api/burn/balutil/inc/BalBaseBAFunctionsProc.h b/src/api/burn/balutil/inc/BalBaseBAFunctionsProc.h
index 2af231e8..135f7c76 100644
--- a/src/api/burn/balutil/inc/BalBaseBAFunctionsProc.h
+++ b/src/api/burn/balutil/inc/BalBaseBAFunctionsProc.h
@@ -12,7 +12,7 @@ static HRESULT BalBaseBAFunctionsProcOnThemeLoaded(
12 __inout BA_FUNCTIONS_ONTHEMELOADED_RESULTS* /*pResults*/ 12 __inout BA_FUNCTIONS_ONTHEMELOADED_RESULTS* /*pResults*/
13 ) 13 )
14{ 14{
15 return pBAFunctions->OnThemeLoaded(pArgs->pTheme, pArgs->pWixLoc); 15 return pBAFunctions->OnThemeLoaded(pArgs->hWnd);
16} 16}
17 17
18static HRESULT BalBaseBAFunctionsProcWndProc( 18static HRESULT BalBaseBAFunctionsProcWndProc(
@@ -21,7 +21,7 @@ static HRESULT BalBaseBAFunctionsProcWndProc(
21 __inout BA_FUNCTIONS_WNDPROC_RESULTS* pResults 21 __inout BA_FUNCTIONS_WNDPROC_RESULTS* pResults
22 ) 22 )
23{ 23{
24 return pBAFunctions->WndProc(pArgs->pTheme, pArgs->hWnd, pArgs->uMsg, pArgs->wParam, pArgs->lParam, &pResults->lres); 24 return pBAFunctions->WndProc(pArgs->hWnd, pArgs->uMsg, pArgs->wParam, pArgs->lParam, &pResults->fProcessed, &pResults->lResult);
25} 25}
26 26
27static HRESULT BalBaseBAFunctionsProcOnThemeControlLoading( 27static HRESULT BalBaseBAFunctionsProcOnThemeControlLoading(
diff --git a/src/api/burn/balutil/inc/IBAFunctions.h b/src/api/burn/balutil/inc/IBAFunctions.h
index 2e71608d..50126ba1 100644
--- a/src/api/burn/balutil/inc/IBAFunctions.h
+++ b/src/api/burn/balutil/inc/IBAFunctions.h
@@ -7,20 +7,18 @@ DECLARE_INTERFACE_IID_(IBAFunctions, IBootstrapperApplication, "0FB445ED-17BD-49
7 // OnThemeLoaded - Called after the BA finished loading all the controls for the theme. 7 // OnThemeLoaded - Called after the BA finished loading all the controls for the theme.
8 // 8 //
9 STDMETHOD(OnThemeLoaded)( 9 STDMETHOD(OnThemeLoaded)(
10 THEME* pTheme, 10 __in HWND hWnd
11 WIX_LOCALIZATION* pWixLoc
12 ) = 0; 11 ) = 0;
13 12
14 // WndProc - Called if the BA hasn't handled the message. 13 // WndProc - Called if the BA hasn't handled the message.
15 // The implementation must either return E_NOTIMPL or call ThemeDefWindowProc for unhandled messages.
16 // 14 //
17 STDMETHOD(WndProc)( 15 STDMETHOD(WndProc)(
18 __in THEME* pTheme,
19 __in HWND hWnd, 16 __in HWND hWnd,
20 __in UINT uMsg, 17 __in UINT uMsg,
21 __in WPARAM wParam, 18 __in WPARAM wParam,
22 __in LPARAM lParam, 19 __in LPARAM lParam,
23 __inout LRESULT* plRes 20 __inout BOOL* pfProcessed,
21 __inout LRESULT* plResult
24 ) = 0; 22 ) = 0;
25 23
26 // BAFunctionsProc - The PFN_BA_FUNCTIONS_PROC can call this method to give the BAFunctions raw access to the callback from WixStdBA. 24 // BAFunctionsProc - The PFN_BA_FUNCTIONS_PROC can call this method to give the BAFunctions raw access to the callback from WixStdBA.
diff --git a/src/api/burn/test/BalUtilUnitTest/precomp.h b/src/api/burn/test/BalUtilUnitTest/precomp.h
index f4a35e20..ce893906 100644
--- a/src/api/burn/test/BalUtilUnitTest/precomp.h
+++ b/src/api/burn/test/BalUtilUnitTest/precomp.h
@@ -14,8 +14,6 @@
14 14
15#include <dutil.h> 15#include <dutil.h>
16#include <dictutil.h> 16#include <dictutil.h>
17#include <locutil.h>
18#include <thmutil.h>
19 17
20#include <BootstrapperEngine.h> 18#include <BootstrapperEngine.h>
21#include <BootstrapperApplication.h> 19#include <BootstrapperApplication.h>