Change ARP property Installed to 0 when registrationType is InProgress.

Being registered in ARP and "installed" were always separate concepts, and some things like fEligibleForCleanup were looking at the wrong thing. This also allows the BA to tell the difference.

2 files changed, 6 insertions, 6 deletions

diff --git a/src/burn/test/BurnUnitTest/PlanTest.cpp b/src/burn/test/BurnUnitTest/PlanTest.cpp
index ba28713f..685d2ca9 100644
--- a/src/burn/test/BurnUnitTest/PlanTest.cpp
+++ b/src/burn/test/BurnUnitTest/PlanTest.cpp
@@ -792,7 +792,7 @@ namespace Bootstrapper
             InitializeEngineStateForCorePlan(wzSingleMsiManifestFileName, pEngineState);
             DetectPackagesAsAbsent(pEngineState);
 
-            pEngineState->registration.fInstalled = TRUE;
+            pEngineState->registration.detectedRegistrationType = BOOTSTRAPPER_REGISTRATION_TYPE_FULL;
 
             hr = CorePlan(pEngineState, BOOTSTRAPPER_ACTION_MODIFY);
             NativeAssert::Succeeded(hr, "CorePlan failed");
@@ -1457,7 +1457,7 @@ namespace Bootstrapper
         {
             PlanTestDetect(pEngineState);
 
-            pEngineState->registration.fInstalled = TRUE;
+            pEngineState->registration.detectedRegistrationType = BOOTSTRAPPER_REGISTRATION_TYPE_FULL;
 
             for (DWORD i = 0; i < pEngineState->packages.cPackages; ++i)
             {
@@ -1486,7 +1486,7 @@ namespace Bootstrapper
         {
             PlanTestDetect(pEngineState);
 
-            pEngineState->registration.fInstalled = TRUE;
+            pEngineState->registration.detectedRegistrationType = BOOTSTRAPPER_REGISTRATION_TYPE_FULL;
 
             for (DWORD i = 0; i < pEngineState->packages.cPackages; ++i)
             {
diff --git a/src/burn/test/BurnUnitTest/RegistrationTest.cpp b/src/burn/test/BurnUnitTest/RegistrationTest.cpp
index 6a10961d..86ea86b0 100644
--- a/src/burn/test/BurnUnitTest/RegistrationTest.cpp
+++ b/src/burn/test/BurnUnitTest/RegistrationTest.cpp
@@ -218,7 +218,7 @@ namespace Bootstrapper
 
                 // verify that registration was updated
                 this->ValidateUninstallKeyResume(Int32(BURN_RESUME_MODE_ARP));
-                this->ValidateUninstallKeyInstalled(1);
+                this->ValidateUninstallKeyInstalled(0);
                 this->ValidateRunOnceKeyString(TEST_BUNDLE_ID, nullptr);
 
                 //
@@ -231,7 +231,7 @@ namespace Bootstrapper
 
                 // verify that registration was updated
                 this->ValidateUninstallKeyResume(Int32(BURN_RESUME_MODE_ACTIVE));
-                this->ValidateUninstallKeyInstalled(1);
+                this->ValidateUninstallKeyInstalled(0);
                 this->ValidateRunOnceKeyEntry(cacheExePath);
 
                 // delete registration
@@ -337,7 +337,7 @@ namespace Bootstrapper
 
                 // verify that registration variables were updated
                 this->ValidateUninstallKeyDisplayName(L"Product1");
-                registration.fInstalled = TRUE;
+                registration.detectedRegistrationType = BOOTSTRAPPER_REGISTRATION_TYPE_FULL;
 
                 hr = RegistrationSetVariables(&registration, &variables);
                 TestThrowOnFailure(hr, L"Failed to set registration variables.");