aboutsummaryrefslogtreecommitdiff
path: root/src/engine/engine.mc
diff options
context:
space:
mode:
authorSean Hall <r.sean.hall@gmail.com>2021-04-16 09:40:18 -0500
committerSean Hall <r.sean.hall@gmail.com>2021-04-19 23:12:55 -0500
commit941c47e5a3f57ce9626b447a95740b1444e69343 (patch)
tree6225b78f5fc7c8f88a2abf187a6a76d45b36ec26 /src/engine/engine.mc
parentd32f770ca05748df9e356444c7e617d5eeedb60c (diff)
downloadwix-941c47e5a3f57ce9626b447a95740b1444e69343.tar.gz
wix-941c47e5a3f57ce9626b447a95740b1444e69343.tar.bz2
wix-941c47e5a3f57ce9626b447a95740b1444e69343.zip
Detect a package as cached if any of its payloads exist.
Detect is supposed to be fast, so it can't fully verify every payload for every package. The engine was wasting its time by trying to verify file sizes without the hash. Even worse, it was making decisions during planning based on that insufficient verification. Contributes to #3640
Diffstat (limited to 'src/engine/engine.mc')
-rw-r--r--src/engine/engine.mc8
1 files changed, 4 insertions, 4 deletions
diff --git a/src/engine/engine.mc b/src/engine/engine.mc
index d0897a95..365da1d9 100644
--- a/src/engine/engine.mc
+++ b/src/engine/engine.mc
@@ -242,16 +242,16 @@ Detected forward compatible bundle: %1!ls!, type: %2!hs!, scope: %3!hs!, version
242 242
243MessageId=108 243MessageId=108
244Severity=Warning 244Severity=Warning
245SymbolicName=MSG_DETECT_RELATED_BUNDLE_NOT_FULLY_CACHED 245SymbolicName=MSG_DETECT_RELATED_BUNDLE_NOT_CACHED
246Language=English 246Language=English
247Detected partially cached related bundle: %1!ls!, cache path: %2!ls!, reason: 0x%3!x! 247Detected related bundle missing from cache: %1!ls!, cache path: %2!ls!
248. 248.
249 249
250MessageId=120 250MessageId=120
251Severity=Warning 251Severity=Warning
252SymbolicName=MSG_DETECT_PACKAGE_NOT_FULLY_CACHED 252SymbolicName=MSG_DETECT_PACKAGE_NOT_FULLY_CACHED
253Language=English 253Language=English
254Detected partially cached package: %1!ls!, invalid payload: %2!ls!, reason: 0x%3!x! 254Detected partially cached package: %1!ls!, missing payload: %2!ls!
255. 255.
256 256
257MessageId=121 257MessageId=121
@@ -363,7 +363,7 @@ MessageId=208
363Severity=Warning 363Severity=Warning
364SymbolicName=MSG_PLAN_DISABLING_ROLLBACK_NO_CACHE 364SymbolicName=MSG_PLAN_DISABLING_ROLLBACK_NO_CACHE
365Language=English 365Language=English
366Plan disabled rollback for package: %1!ls!, due to incomplete cache: %2!hs!, original rollback action: %3!hs! 366Plan disabled rollback due to incomplete cache for package: %1!ls!, original rollback action: %2!hs!
367. 367.
368 368
369MessageId=209 369MessageId=209