diff options
| author | Rob Mensching <rob@firegiant.com> | 2025-11-01 20:24:25 -0700 |
|---|---|---|
| committer | Rob Mensching <rob@firegiant.com> | 2025-11-03 14:49:39 -0800 |
| commit | 4d626c294c4783d454e27ea4e5614037dac8576e (patch) | |
| tree | 51d822f48716e4c5ef2a51ca28925896f221b521 /src/ext/Bal | |
| parent | 33c12fa386aa7ace7a6bd06a45bc3ecf17e9c8f5 (diff) | |
| download | wix-4d626c294c4783d454e27ea4e5614037dac8576e.tar.gz wix-4d626c294c4783d454e27ea4e5614037dac8576e.tar.bz2 wix-4d626c294c4783d454e27ea4e5614037dac8576e.zip | |
Use CompareStringOrdinal() instead of CompareString() case-insensitive
This commit moves to the modern CompareStringOrdinal() for all case-insensitve
uses of CompareString() with the invariant locale.
Partially resolves 6947
Diffstat (limited to 'src/ext/Bal')
| -rw-r--r-- | src/ext/Bal/stdbas/WixStandardBootstrapperApplication.cpp | 4 | ||||
| -rw-r--r-- | src/ext/Bal/test/examples/TestEngine/ExampleTestEngine.cpp | 6 |
2 files changed, 5 insertions, 5 deletions
diff --git a/src/ext/Bal/stdbas/WixStandardBootstrapperApplication.cpp b/src/ext/Bal/stdbas/WixStandardBootstrapperApplication.cpp index 59b2d8de..9ddab7c0 100644 --- a/src/ext/Bal/stdbas/WixStandardBootstrapperApplication.cpp +++ b/src/ext/Bal/stdbas/WixStandardBootstrapperApplication.cpp | |||
| @@ -2928,7 +2928,7 @@ private: | |||
| 2928 | 2928 | ||
| 2929 | if (argv[i][0] == L'-' || argv[i][0] == L'/') | 2929 | if (argv[i][0] == L'-' || argv[i][0] == L'/') |
| 2930 | { | 2930 | { |
| 2931 | if (CSTR_EQUAL == ::CompareStringW(LOCALE_INVARIANT, NORM_IGNORECASE, &argv[i][1], -1, L"lang", -1)) | 2931 | if (CSTR_EQUAL == ::CompareStringOrdinal(&argv[i][1], -1, L"lang", -1, TRUE)) |
| 2932 | { | 2932 | { |
| 2933 | if (i + 1 >= argc) | 2933 | if (i + 1 >= argc) |
| 2934 | { | 2934 | { |
| @@ -2941,7 +2941,7 @@ private: | |||
| 2941 | hr = StrAllocString(psczLanguage, &argv[i][0], 0); | 2941 | hr = StrAllocString(psczLanguage, &argv[i][0], 0); |
| 2942 | BalExitOnFailure(hr, "Failed to copy language."); | 2942 | BalExitOnFailure(hr, "Failed to copy language."); |
| 2943 | } | 2943 | } |
| 2944 | else if (CSTR_EQUAL == ::CompareStringW(LOCALE_INVARIANT, NORM_IGNORECASE, &argv[i][1], -1, L"cache", -1)) | 2944 | else if (CSTR_EQUAL == ::CompareStringOrdinal(&argv[i][1], -1, L"cache", -1, TRUE)) |
| 2945 | { | 2945 | { |
| 2946 | m_fRequestedCacheOnly = TRUE; | 2946 | m_fRequestedCacheOnly = TRUE; |
| 2947 | } | 2947 | } |
diff --git a/src/ext/Bal/test/examples/TestEngine/ExampleTestEngine.cpp b/src/ext/Bal/test/examples/TestEngine/ExampleTestEngine.cpp index fc1938fe..9ad4e91f 100644 --- a/src/ext/Bal/test/examples/TestEngine/ExampleTestEngine.cpp +++ b/src/ext/Bal/test/examples/TestEngine/ExampleTestEngine.cpp | |||
| @@ -19,15 +19,15 @@ int __cdecl wmain(int argc, LPWSTR argv[]) | |||
| 19 | { | 19 | { |
| 20 | fShowUsage = TRUE; | 20 | fShowUsage = TRUE; |
| 21 | } | 21 | } |
| 22 | else if (CSTR_EQUAL == ::CompareString(LOCALE_INVARIANT, NORM_IGNORECASE, argv[1], -1, L"reload", -1)) | 22 | else if (CSTR_EQUAL == ::CompareStringOrdinal(argv[1], -1, L"reload", -1, TRUE)) |
| 23 | { | 23 | { |
| 24 | hr = RunReloadEngine(argv[2], argv[3]); | 24 | hr = RunReloadEngine(argv[2], argv[3]); |
| 25 | } | 25 | } |
| 26 | else if (CSTR_EQUAL == ::CompareString(LOCALE_INVARIANT, NORM_IGNORECASE, argv[1], -1, L"shutdown", -1)) | 26 | else if (CSTR_EQUAL == ::CompareStringOrdinal(argv[1], -1, L"shutdown", -1, TRUE)) |
| 27 | { | 27 | { |
| 28 | hr = RunShutdownEngine(argv[2], argv[3]); | 28 | hr = RunShutdownEngine(argv[2], argv[3]); |
| 29 | } | 29 | } |
| 30 | else if (CSTR_EQUAL == ::CompareString(LOCALE_INVARIANT, NORM_IGNORECASE, argv[1], -1, L"waitforquit", -1)) | 30 | else if (CSTR_EQUAL == ::CompareStringOrdinal(argv[1], -1, L"waitforquit", -1, TRUE)) |
| 31 | { | 31 | { |
| 32 | hr = RunWaitForQuitEngine(argv[2], argv[3]); | 32 | hr = RunWaitForQuitEngine(argv[2], argv[3]); |
| 33 | } | 33 | } |
