diff options
author | Bob Arnson <bob@firegiant.com> | 2023-04-27 21:06:35 -0400 |
---|---|---|
committer | Rob Mensching <rob@firegiant.com> | 2023-06-03 01:24:39 -0700 |
commit | 1d7ca4c4d7edfb16be7ca24ca680c9b630d56e7c (patch) | |
tree | 0c6788530d37f1f683314e90a21019a8cd788ef5 /src/test | |
parent | 1da29b425658bf1ddc774154d9bccaf940d0bc66 (diff) | |
download | wix-1d7ca4c4d7edfb16be7ca24ca680c9b630d56e7c.tar.gz wix-1d7ca4c4d7edfb16be7ca24ca680c9b630d56e7c.tar.bz2 wix-1d7ca4c4d7edfb16be7ca24ca680c9b630d56e7c.zip |
Fix XmlConfig lookup logic.
Fixes https://github.com/wixtoolset/issues/issues/7377.
Requires fix for https://github.com/wixtoolset/issues/issues/7444.
Diffstat (limited to 'src/test')
4 files changed, 98 insertions, 0 deletions
diff --git a/src/test/msi/TestData/XmlConfigTests/XmlConfig/Package.wxs b/src/test/msi/TestData/XmlConfigTests/XmlConfig/Package.wxs new file mode 100644 index 00000000..e5223ea8 --- /dev/null +++ b/src/test/msi/TestData/XmlConfigTests/XmlConfig/Package.wxs | |||
@@ -0,0 +1,27 @@ | |||
1 | <Wix xmlns="http://wixtoolset.org/schemas/v4/wxs" xmlns:util="http://wixtoolset.org/schemas/v4/wxs/util"> | ||
2 | <Package Name="XmlConfig" Language="1033" Version="1.0.0.0" Manufacturer="Example Corporation" UpgradeCode="047730a5-30fe-4a62-a520-da9381b8226a"> | ||
3 | <MajorUpgrade DowngradeErrorMessage="A newer version of [ProductName] is already installed." /> | ||
4 | |||
5 | <Feature Id="ProductFeature" Title="XmlConfig"> | ||
6 | <Component Directory="INSTALLFOLDER"> | ||
7 | <File Id="MyXmlFile" Source="my.xml" /> | ||
8 | </Component> | ||
9 | |||
10 | <Component Id="Del" Directory="INSTALLFOLDER" Guid="3613414c-11f5-40fa-a1f1-a0ba722a6895"> | ||
11 | <util:XmlConfig Id="DelElement" File="[#MyXmlFile]" Action="delete" Node="element" VerifyPath="grandchild1" ElementPath="//root/child1" On="install" /> | ||
12 | </Component> | ||
13 | |||
14 | <Component Id="Add" Directory="INSTALLFOLDER" Guid="30A9FF8B-7AC8-47F3-BB24-9EA81AA38856"> | ||
15 | <util:XmlConfig Id="AddElement" File="[#MyXmlFile]" Action="create" Node="element" ElementPath="//root/child2" Name="grandchild3" On="install" Sequence="2" /> | ||
16 | <util:XmlConfig ElementId="AddElement" File="[#MyXmlFile]" Name="TheAttribute1" Value="AttributeValue1" Sequence="3" /> | ||
17 | <util:XmlConfig Id="AddAttribute2" ElementId="AddElement" File="[INSTALLFOLDER]my.xml" Name="TheAttribute2" Value="AttributeValue2" Sequence="4" /> | ||
18 | </Component> | ||
19 | </Feature> | ||
20 | </Package> | ||
21 | |||
22 | <Fragment> | ||
23 | <StandardDirectory Id="ProgramFilesFolder"> | ||
24 | <Directory Id="INSTALLFOLDER" Name="XmlConfig" /> | ||
25 | </StandardDirectory> | ||
26 | </Fragment> | ||
27 | </Wix> | ||
diff --git a/src/test/msi/TestData/XmlConfigTests/XmlConfig/XmlConfig.wixproj b/src/test/msi/TestData/XmlConfigTests/XmlConfig/XmlConfig.wixproj new file mode 100644 index 00000000..58321e7e --- /dev/null +++ b/src/test/msi/TestData/XmlConfigTests/XmlConfig/XmlConfig.wixproj | |||
@@ -0,0 +1,6 @@ | |||
1 | <!-- Copyright (c) .NET Foundation and contributors. All rights reserved. Licensed under the Microsoft Reciprocal License. See LICENSE.TXT file in the project root for full license information. --> | ||
2 | <Project Sdk="WixToolset.Sdk"> | ||
3 | <ItemGroup> | ||
4 | <PackageReference Include="WixToolset.Util.wixext" /> | ||
5 | </ItemGroup> | ||
6 | </Project> \ No newline at end of file | ||
diff --git a/src/test/msi/TestData/XmlConfigTests/XmlConfig/my.xml b/src/test/msi/TestData/XmlConfigTests/XmlConfig/my.xml new file mode 100644 index 00000000..3f44c27c --- /dev/null +++ b/src/test/msi/TestData/XmlConfigTests/XmlConfig/my.xml | |||
@@ -0,0 +1,11 @@ | |||
1 | <root> | ||
2 | <child1> | ||
3 | <grandchild1> | ||
4 | </grandchild1> | ||
5 | </child1> | ||
6 | |||
7 | <child2> | ||
8 | <grandchild2> | ||
9 | </grandchild2> | ||
10 | </child2> | ||
11 | </root> | ||
diff --git a/src/test/msi/WixToolsetTest.MsiE2E/XmlConfigTests.cs b/src/test/msi/WixToolsetTest.MsiE2E/XmlConfigTests.cs new file mode 100644 index 00000000..9b90cf46 --- /dev/null +++ b/src/test/msi/WixToolsetTest.MsiE2E/XmlConfigTests.cs | |||
@@ -0,0 +1,54 @@ | |||
1 | // Copyright (c) .NET Foundation and contributors. All rights reserved. Licensed under the Microsoft Reciprocal License. See LICENSE.TXT file in the project root for full license information. | ||
2 | |||
3 | namespace WixToolsetTest.MsiE2E; | ||
4 | |||
5 | using System; | ||
6 | using System.IO; | ||
7 | using System.Xml.Linq; | ||
8 | using WixTestTools; | ||
9 | using Xunit; | ||
10 | using Xunit.Abstractions; | ||
11 | |||
12 | public class XmlConfigTests : MsiE2ETests | ||
13 | { | ||
14 | public XmlConfigTests(ITestOutputHelper testOutputHelper) : base(testOutputHelper) | ||
15 | { | ||
16 | } | ||
17 | |||
18 | [RuntimeFact] | ||
19 | public void CanModifyXmlFileWithXmlConfig() | ||
20 | { | ||
21 | var product = this.CreatePackageInstaller("XmlConfig"); | ||
22 | |||
23 | product.InstallProduct(MSIExec.MSIExecReturnCode.SUCCESS); | ||
24 | |||
25 | // Validate the expected changes in my.xml. | ||
26 | var myXmlPath = Path.Combine(Environment.GetFolderPath(Environment.SpecialFolder.ProgramFilesX86), "XmlConfig", "my.xml"); | ||
27 | var content = File.ReadAllText(myXmlPath); | ||
28 | var xDoc = XDocument.Parse(content); | ||
29 | |||
30 | var xRoot = xDoc.Element("root"); | ||
31 | var xChild1 = xRoot.Element("child1"); | ||
32 | Assert.NotNull(xChild1); | ||
33 | |||
34 | var xGrandchild1 = xChild1.Element("grandchild1"); | ||
35 | Assert.Null(xGrandchild1); | ||
36 | |||
37 | var xChild2 = xRoot.Element("child2"); | ||
38 | Assert.NotNull(xChild2); | ||
39 | |||
40 | var xGrandchild3 = xChild2.Element("grandchild3"); | ||
41 | Assert.NotNull(xGrandchild3); | ||
42 | Assert.True(xGrandchild3.HasAttributes); | ||
43 | |||
44 | var xAttribute1 = xGrandchild3.Attribute("TheAttribute1"); | ||
45 | Assert.NotNull(xAttribute1); | ||
46 | Assert.Equal("AttributeValue1", xAttribute1.Value); | ||
47 | |||
48 | var xAttribute2 = xGrandchild3.Attribute("TheAttribute2"); | ||
49 | Assert.NotNull(xAttribute2); | ||
50 | Assert.Equal("AttributeValue2", xAttribute2.Value); | ||
51 | |||
52 | product.UninstallProduct(MSIExec.MSIExecReturnCode.SUCCESS); | ||
53 | } | ||
54 | } | ||