diff options
author | Bob Arnson <bob@firegiant.com> | 2024-02-17 17:56:57 -0500 |
---|---|---|
committer | Bob Arnson <github@bobs.org> | 2024-02-17 18:39:07 -0500 |
commit | a38b07af45eb36cc13fcd2546ac45e6f769e4d6f (patch) | |
tree | f3f872f0154bd09a589becc0a45c597445911c50 /src/test | |
parent | e98ff251390fe60946576b4dced9565ae3a43e43 (diff) | |
download | wix-a38b07af45eb36cc13fcd2546ac45e6f769e4d6f.tar.gz wix-a38b07af45eb36cc13fcd2546ac45e6f769e4d6f.tar.bz2 wix-a38b07af45eb36cc13fcd2546ac45e6f769e4d6f.zip |
Allow MsiProperty/@Value to be an empty string.
Fixes https://github.com/wixtoolset/issues/issues/7798.
Diffstat (limited to 'src/test')
-rw-r--r-- | src/test/burn/TestData/VariableTests/BundleA/BundleA.wxs | 1 | ||||
-rw-r--r-- | src/test/burn/WixToolsetTest.BurnE2E/VariableTests.cs | 2 |
2 files changed, 2 insertions, 1 deletions
diff --git a/src/test/burn/TestData/VariableTests/BundleA/BundleA.wxs b/src/test/burn/TestData/VariableTests/BundleA/BundleA.wxs index f243c97d..86772ae9 100644 --- a/src/test/burn/TestData/VariableTests/BundleA/BundleA.wxs +++ b/src/test/burn/TestData/VariableTests/BundleA/BundleA.wxs | |||
@@ -8,6 +8,7 @@ | |||
8 | <MsiPackage Id="PackageA" SourceFile="$(var.PackageA.TargetPath)"> | 8 | <MsiPackage Id="PackageA" SourceFile="$(var.PackageA.TargetPath)"> |
9 | <MsiProperty Name="INSTALLLOCATION" Value="[INSTALLLOCATION]" /> | 9 | <MsiProperty Name="INSTALLLOCATION" Value="[INSTALLLOCATION]" /> |
10 | <MsiProperty Name="LICENSEKEY" Value="[LICENSEKEY]" /> | 10 | <MsiProperty Name="LICENSEKEY" Value="[LICENSEKEY]" /> |
11 | <MsiProperty Name="BLANKPROPERTY" Value="" /> | ||
11 | </MsiPackage> | 12 | </MsiPackage> |
12 | </PackageGroup> | 13 | </PackageGroup> |
13 | 14 | ||
diff --git a/src/test/burn/WixToolsetTest.BurnE2E/VariableTests.cs b/src/test/burn/WixToolsetTest.BurnE2E/VariableTests.cs index 22e94260..fcd46e0b 100644 --- a/src/test/burn/WixToolsetTest.BurnE2E/VariableTests.cs +++ b/src/test/burn/WixToolsetTest.BurnE2E/VariableTests.cs | |||
@@ -30,7 +30,7 @@ namespace WixToolsetTest.BurnE2E | |||
30 | // Burn logging its command line. | 30 | // Burn logging its command line. |
31 | Assert.True(LogVerifier.MessageInLogFile(logFilePath, "InstallLocation=nothingtoseehere licensekey=*****")); | 31 | Assert.True(LogVerifier.MessageInLogFile(logFilePath, "InstallLocation=nothingtoseehere licensekey=*****")); |
32 | // Burn logging the MSI install command line. | 32 | // Burn logging the MSI install command line. |
33 | Assert.True(LogVerifier.MessageInLogFile(logFilePath, "INSTALLLOCATION=\"nothingtoseehere\" LICENSEKEY=\"*****\"")); | 33 | Assert.True(LogVerifier.MessageInLogFile(logFilePath, "INSTALLLOCATION=\"nothingtoseehere\" LICENSEKEY=\"*****\" BLANKPROPERTY=\"\"")); |
34 | Assert.False(LogVerifier.MessageInLogFile(logFilePath, "supersecretkey")); | 34 | Assert.False(LogVerifier.MessageInLogFile(logFilePath, "supersecretkey")); |
35 | } | 35 | } |
36 | 36 | ||