diff options
| author | Sean Hall <r.sean.hall@gmail.com> | 2018-12-10 22:52:03 -0600 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2018-12-10 22:52:03 -0600 |
| commit | db8641b5ab125679b028848d1747d7a4cef6fc37 (patch) | |
| tree | e01af02b7bcee79de4c768c3e92b3552b61e45fd /src/test | |
| parent | 06a7caade34cba18629024ea2ccce567d85898d7 (diff) | |
| download | wix-db8641b5ab125679b028848d1747d7a4cef6fc37.tar.gz wix-db8641b5ab125679b028848d1747d7a4cef6fc37.tar.bz2 wix-db8641b5ab125679b028848d1747d7a4cef6fc37.zip | |
Make WixCop move Directory/@ShortName to @Name. (#7)
Fixes wixtoolset/issues#5652.
Diffstat (limited to 'src/test')
| -rw-r--r-- | src/test/WixToolsetTest.WixCop/ConverterFixture.cs | 28 |
1 files changed, 28 insertions, 0 deletions
diff --git a/src/test/WixToolsetTest.WixCop/ConverterFixture.cs b/src/test/WixToolsetTest.WixCop/ConverterFixture.cs index 863a781a..ceac07d6 100644 --- a/src/test/WixToolsetTest.WixCop/ConverterFixture.cs +++ b/src/test/WixToolsetTest.WixCop/ConverterFixture.cs | |||
| @@ -421,6 +421,34 @@ namespace WixToolsetTest.WixCop | |||
| 421 | } | 421 | } |
| 422 | 422 | ||
| 423 | [Fact] | 423 | [Fact] |
| 424 | public void CanConvertShortNameDirectoryWithoutName() | ||
| 425 | { | ||
| 426 | var parse = String.Join(Environment.NewLine, | ||
| 427 | "<?xml version='1.0' encoding='utf-8'?>", | ||
| 428 | "<Wix xmlns='http://wixtoolset.org/schemas/v4/wxs'>", | ||
| 429 | " <Directory ShortName='iamshort' />", | ||
| 430 | "</Wix>"); | ||
| 431 | |||
| 432 | var expected = String.Join(Environment.NewLine, | ||
| 433 | "<?xml version=\"1.0\" encoding=\"utf-16\"?>", | ||
| 434 | "<Wix xmlns=\"http://wixtoolset.org/schemas/v4/wxs\">", | ||
| 435 | " <Directory Name=\"iamshort\" />", | ||
| 436 | "</Wix>"); | ||
| 437 | |||
| 438 | var document = XDocument.Parse(parse, LoadOptions.PreserveWhitespace | LoadOptions.SetLineInfo); | ||
| 439 | |||
| 440 | var messaging = new DummyMessaging(); | ||
| 441 | var converter = new Converter(messaging, 2, null, null); | ||
| 442 | |||
| 443 | var errors = converter.ConvertDocument(document); | ||
| 444 | |||
| 445 | var actual = UnformattedDocumentString(document); | ||
| 446 | |||
| 447 | Assert.Equal(1, errors); | ||
| 448 | Assert.Equal(expected, actual); | ||
| 449 | } | ||
| 450 | |||
| 451 | [Fact] | ||
| 424 | public void CanConvertSuppressSignatureValidationNo() | 452 | public void CanConvertSuppressSignatureValidationNo() |
| 425 | { | 453 | { |
| 426 | var parse = String.Join(Environment.NewLine, | 454 | var parse = String.Join(Environment.NewLine, |
