aboutsummaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorSean Hall <r.sean.hall@gmail.com>2020-04-13 13:36:49 +1000
committerSean Hall <r.sean.hall@gmail.com>2020-04-13 20:32:16 +1000
commit0a596a3cd67e5e7749cb529b3eb1ee2ea38901b3 (patch)
treefc766a6eab7926d82a6069d230db39483c62f425 /src
parentd7650a48368f15468d721f4d0729bbf60c7c1666 (diff)
downloadwix-0a596a3cd67e5e7749cb529b3eb1ee2ea38901b3.tar.gz
wix-0a596a3cd67e5e7749cb529b3eb1ee2ea38901b3.tar.bz2
wix-0a596a3cd67e5e7749cb529b3eb1ee2ea38901b3.zip
Fix changes to TableDefinition.
Diffstat (limited to 'src')
-rw-r--r--src/WixToolset.Core.WindowsInstaller/Bind/LoadTableDefinitionsCommand.cs2
-rw-r--r--src/WixToolset.Core.WindowsInstaller/Unbind/UnbindDatabaseCommand.cs2
-rw-r--r--src/WixToolset.Core/ExtensibilityServices/WindowsInstallerBackendHelper.cs2
-rw-r--r--src/test/Example.Extension/Example.Extension.csproj6
-rw-r--r--src/test/Example.Extension/ExampleTableDefinitions.cs3
5 files changed, 10 insertions, 5 deletions
diff --git a/src/WixToolset.Core.WindowsInstaller/Bind/LoadTableDefinitionsCommand.cs b/src/WixToolset.Core.WindowsInstaller/Bind/LoadTableDefinitionsCommand.cs
index 024857ab..eba7bdbe 100644
--- a/src/WixToolset.Core.WindowsInstaller/Bind/LoadTableDefinitionsCommand.cs
+++ b/src/WixToolset.Core.WindowsInstaller/Bind/LoadTableDefinitionsCommand.cs
@@ -230,7 +230,7 @@ namespace WixToolset.Core.WindowsInstaller.Bind
230 columns.Add(columnDefinition); 230 columns.Add(columnDefinition);
231 } 231 }
232 232
233 var customTable = new TableDefinition(tuple.Id.Id, columns, tuple.Unreal); 233 var customTable = new TableDefinition(tuple.Id.Id, null, columns, tuple.Unreal);
234 return customTable; 234 return customTable;
235 } 235 }
236 } 236 }
diff --git a/src/WixToolset.Core.WindowsInstaller/Unbind/UnbindDatabaseCommand.cs b/src/WixToolset.Core.WindowsInstaller/Unbind/UnbindDatabaseCommand.cs
index 1f43a025..d5601fad 100644
--- a/src/WixToolset.Core.WindowsInstaller/Unbind/UnbindDatabaseCommand.cs
+++ b/src/WixToolset.Core.WindowsInstaller/Unbind/UnbindDatabaseCommand.cs
@@ -421,7 +421,7 @@ namespace WixToolset.Core.WindowsInstaller.Unbind
421 } 421 }
422 } 422 }
423 423
424 return new TableDefinition(tableName, columns, false); 424 return new TableDefinition(tableName, null, columns, false);
425 } 425 }
426 426
427 /// <summary> 427 /// <summary>
diff --git a/src/WixToolset.Core/ExtensibilityServices/WindowsInstallerBackendHelper.cs b/src/WixToolset.Core/ExtensibilityServices/WindowsInstallerBackendHelper.cs
index 753b8b34..a923a8cc 100644
--- a/src/WixToolset.Core/ExtensibilityServices/WindowsInstallerBackendHelper.cs
+++ b/src/WixToolset.Core/ExtensibilityServices/WindowsInstallerBackendHelper.cs
@@ -21,7 +21,7 @@ namespace WixToolset.Core.ExtensibilityServices
21 21
22 public bool TryAddTupleToOutputMatchingTableDefinitions(IntermediateSection section, IntermediateTuple tuple, WindowsInstallerData output, TableDefinitionCollection tableDefinitions) 22 public bool TryAddTupleToOutputMatchingTableDefinitions(IntermediateSection section, IntermediateTuple tuple, WindowsInstallerData output, TableDefinitionCollection tableDefinitions)
23 { 23 {
24 var tableDefinition = tableDefinitions.FirstOrDefault(t => t.TupleDefinitionName == tuple.Definition.Name); 24 var tableDefinition = tableDefinitions.FirstOrDefault(t => t.TupleDefinition?.Name == tuple.Definition.Name);
25 if (tableDefinition == null) 25 if (tableDefinition == null)
26 { 26 {
27 return false; 27 return false;
diff --git a/src/test/Example.Extension/Example.Extension.csproj b/src/test/Example.Extension/Example.Extension.csproj
index 7f375cb6..fe05fcb2 100644
--- a/src/test/Example.Extension/Example.Extension.csproj
+++ b/src/test/Example.Extension/Example.Extension.csproj
@@ -6,9 +6,14 @@
6 <TargetFramework>netstandard2.0</TargetFramework> 6 <TargetFramework>netstandard2.0</TargetFramework>
7 <IsPackable>false</IsPackable> 7 <IsPackable>false</IsPackable>
8 <DebugType>embedded</DebugType> 8 <DebugType>embedded</DebugType>
9 <CompileWixlibExePath>$(OutputPath)net472\CompileCoreTestExtensionWixlib.exe</CompileWixlibExePath>
9 </PropertyGroup> 10 </PropertyGroup>
10 11
11 <ItemGroup> 12 <ItemGroup>
13 <!-- Try to hack around VS up-to-date detection -->
14 <Content Include="$(CompileWixlibExePath)" CopyToOutputDirectory="PreserveNewest">
15 <Visible>false</Visible>
16 </Content>
12 <ExtensionWxs Include="Data\example.wxs" /> 17 <ExtensionWxs Include="Data\example.wxs" />
13 </ItemGroup> 18 </ItemGroup>
14 19
@@ -24,7 +29,6 @@
24 29
25 <Target Name="SetExtensionWixlib"> 30 <Target Name="SetExtensionWixlib">
26 <PropertyGroup> 31 <PropertyGroup>
27 <CompileWixlibExePath>$(OutputPath)..\net472\CompileCoreTestExtensionWixlib.exe</CompileWixlibExePath>
28 <WixlibPath>$(IntermediateOutputPath)Example.wixlib</WixlibPath> 32 <WixlibPath>$(IntermediateOutputPath)Example.wixlib</WixlibPath>
29 </PropertyGroup> 33 </PropertyGroup>
30 34
diff --git a/src/test/Example.Extension/ExampleTableDefinitions.cs b/src/test/Example.Extension/ExampleTableDefinitions.cs
index 3532ffc3..f204e5b6 100644
--- a/src/test/Example.Extension/ExampleTableDefinitions.cs
+++ b/src/test/Example.Extension/ExampleTableDefinitions.cs
@@ -8,17 +8,18 @@ namespace Example.Extension
8 { 8 {
9 public static readonly TableDefinition ExampleTable = new TableDefinition( 9 public static readonly TableDefinition ExampleTable = new TableDefinition(
10 "Wix4Example", 10 "Wix4Example",
11 ExampleTupleDefinitions.Example,
11 new[] 12 new[]
12 { 13 {
13 new ColumnDefinition("Example", ColumnType.String, 72, true, false, ColumnCategory.Identifier), 14 new ColumnDefinition("Example", ColumnType.String, 72, true, false, ColumnCategory.Identifier),
14 new ColumnDefinition("Value", ColumnType.String, 0, false, false, ColumnCategory.Formatted), 15 new ColumnDefinition("Value", ColumnType.String, 0, false, false, ColumnCategory.Formatted),
15 }, 16 },
16 tupleDefinitionName: ExampleTupleDefinitions.Example.Name,
17 tupleIdIsPrimaryKey: true 17 tupleIdIsPrimaryKey: true
18 ); 18 );
19 19
20 public static readonly TableDefinition NotInAll = new TableDefinition( 20 public static readonly TableDefinition NotInAll = new TableDefinition(
21 "TableDefinitionNotExposedByExtension", 21 "TableDefinitionNotExposedByExtension",
22 null,
22 new[] 23 new[]
23 { 24 {
24 new ColumnDefinition("Example", ColumnType.String, 72, true, false, ColumnCategory.Identifier), 25 new ColumnDefinition("Example", ColumnType.String, 72, true, false, ColumnCategory.Identifier),