aboutsummaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorSean Hall <r.sean.hall@gmail.com>2020-12-02 12:09:29 -0600
committerSean Hall <r.sean.hall@gmail.com>2020-12-02 14:46:46 -0600
commit3523c9d809b86737a18a6c43845cbd894c5e1a97 (patch)
treefacd69bf1a2cf163be71f14f474bd678a829ccb3 /src
parent94b9e961d988c67e0d95925049ae245cc4a2b269 (diff)
downloadwix-3523c9d809b86737a18a6c43845cbd894c5e1a97.tar.gz
wix-3523c9d809b86737a18a6c43845cbd894c5e1a97.tar.bz2
wix-3523c9d809b86737a18a6c43845cbd894c5e1a97.zip
Add warning for MSI transactions.
Diffstat (limited to 'src')
-rw-r--r--src/WixToolset.Data/WarningMessages.cs6
-rw-r--r--src/WixToolset.Data/WixToolset.Data.csproj2
2 files changed, 7 insertions, 1 deletions
diff --git a/src/WixToolset.Data/WarningMessages.cs b/src/WixToolset.Data/WarningMessages.cs
index 438dc8f3..2deaeb7d 100644
--- a/src/WixToolset.Data/WarningMessages.cs
+++ b/src/WixToolset.Data/WarningMessages.cs
@@ -397,6 +397,11 @@ namespace WixToolset.Data
397 return Message(sourceLineNumbers, Ids.MissingUpgradeCode, "The Product/@UpgradeCode attribute was not found; it is strongly recommended to ensure that this product can be upgraded."); 397 return Message(sourceLineNumbers, Ids.MissingUpgradeCode, "The Product/@UpgradeCode attribute was not found; it is strongly recommended to ensure that this product can be upgraded.");
398 } 398 }
399 399
400 public static Message MsiTransactionLimitations(SourceLineNumber sourceLineNumbers)
401 {
402 return Message(sourceLineNumbers, Ids.MsiTransactionLimitations, "MSI transactions have limitations that make it hard to use them successfully in a bundle. Test the bundle thoroughly, especially in upgrade scenarios and the scenario that required them in the first place.");
403 }
404
400 public static Message NestedInstall(SourceLineNumber sourceLineNumbers, string tableName, string columnName, Object value) 405 public static Message NestedInstall(SourceLineNumber sourceLineNumbers, string tableName, string columnName, Object value)
401 { 406 {
402 return Message(sourceLineNumbers, Ids.NestedInstall, "The {0}.{1} column's value, '{2}', indicates a nested install. Nested installations are not supported by the WiX team. This action will be left out of the decompiled output.", tableName, columnName, value); 407 return Message(sourceLineNumbers, Ids.NestedInstall, "The {0}.{1} column's value, '{2}', indicates a nested install. Nested installations are not supported by the WiX team. This action will be left out of the decompiled output.", tableName, columnName, value);
@@ -780,6 +785,7 @@ namespace WixToolset.Data
780 VersionTruncated = 1148, 785 VersionTruncated = 1148,
781 ServiceConfigFamilyNotSupported = 1149, 786 ServiceConfigFamilyNotSupported = 1149,
782 SymbolNotTranslatedToOutput = 1150, 787 SymbolNotTranslatedToOutput = 1150,
788 MsiTransactionLimitations = 1151,
783 } 789 }
784 } 790 }
785} 791}
diff --git a/src/WixToolset.Data/WixToolset.Data.csproj b/src/WixToolset.Data/WixToolset.Data.csproj
index 598803fe..19310aea 100644
--- a/src/WixToolset.Data/WixToolset.Data.csproj
+++ b/src/WixToolset.Data/WixToolset.Data.csproj
@@ -18,7 +18,7 @@
18 18
19 <ItemGroup> 19 <ItemGroup>
20 <PackageReference Include="Microsoft.SourceLink.GitHub" Version="1.0.0" PrivateAssets="All" /> 20 <PackageReference Include="Microsoft.SourceLink.GitHub" Version="1.0.0" PrivateAssets="All" />
21 <PackageReference Include="Nerdbank.GitVersioning" Version="3.1.91" PrivateAssets="all" /> 21 <PackageReference Include="Nerdbank.GitVersioning" Version="3.3.37" PrivateAssets="all" />
22 </ItemGroup> 22 </ItemGroup>
23 23
24 <ItemGroup> 24 <ItemGroup>