Remove unnecessary SuppressMessage attributes

4 files changed, 0 insertions, 33 deletions

diff --git a/src/WixToolset.Core/Compiler.cs b/src/WixToolset.Core/Compiler.cs
index 62ea8aaf..14b28034 100644
--- a/src/WixToolset.Core/Compiler.cs
+++ b/src/WixToolset.Core/Compiler.cs
@@ -676,7 +676,6 @@ namespace WixToolset.Core
         /// </summary>
         /// <param name="node">Element to parse.</param>
         /// <returns>Identifier for the new row.</returns>
-        [SuppressMessage("Microsoft.Performance", "CA1800:DoNotCastUnnecessarily")]
         private Identifier ParseBinaryElement(XElement node)
         {
             var sourceLineNumbers = Preprocessor.GetSourceLineNumbers(node);
@@ -2102,7 +2101,6 @@ namespace WixToolset.Core
         /// <param name="diskId">Optional disk id inherited from parent directory.</param>
         /// <param name="directoryId">Optional identifier for component's directory.</param>
         /// <param name="srcPath">Optional source path for files up to this point.</param>
-        [SuppressMessage("Microsoft.Performance", "CA1800:DoNotCastUnnecessarily")]
         private void ParseComponentElement(XElement node, ComplexReferenceParentType parentType, string parentId, string parentLanguage, int diskId, string directoryId, string srcPath)
         {
             var sourceLineNumbers = Preprocessor.GetSourceLineNumbers(node);
@@ -2573,7 +2571,6 @@ namespace WixToolset.Core
         /// <param name="node">Element to parse.</param>
         /// <param name="parentType"></param>
         /// <param name="parentId"></param>
-        [SuppressMessage("Microsoft.Performance", "CA1800:DoNotCastUnnecessarily")]
         private void ParseComponentGroupElement(XElement node, ComplexReferenceParentType parentType, string parentId)
         {
             var sourceLineNumbers = Preprocessor.GetSourceLineNumbers(node);
@@ -4135,7 +4132,6 @@ namespace WixToolset.Core
         /// <param name="parentId">Optional identifier of parent directory.</param>
         /// <param name="diskId">Disk id inherited from parent directory.</param>
         /// <param name="fileSource">Path to source file as of yet.</param>
-        [SuppressMessage("Microsoft.Performance", "CA1820:TestForEmptyStringsUsingStringLength")]
         private void ParseDirectoryElement(XElement node, string parentId, int diskId, string fileSource)
         {
             var sourceLineNumbers = Preprocessor.GetSourceLineNumbers(node);
@@ -4363,7 +4359,6 @@ namespace WixToolset.Core
         /// Parses a directory reference element.
         /// </summary>
         /// <param name="node">Element to parse.</param>
-        [System.Diagnostics.CodeAnalysis.SuppressMessage("Microsoft.Performance", "CA1800:DoNotCastUnnecessarily")]
         private void ParseDirectoryRefElement(XElement node)
         {
             var sourceLineNumbers = Preprocessor.GetSourceLineNumbers(node);
@@ -4711,7 +4706,6 @@ namespace WixToolset.Core
         /// <param name="parentId">Optional identifer for parent feature.</param>
         /// <param name="lastDisplay">Display value for last feature used to get the features to display in the same order as specified
         /// in the source code.</param>
-        [SuppressMessage("Microsoft.Performance", "CA1800:DoNotCastUnnecessarily")]
         private void ParseFeatureElement(XElement node, ComplexReferenceParentType parentType, string parentId, ref int lastDisplay)
         {
             var sourceLineNumbers = Preprocessor.GetSourceLineNumbers(node);
@@ -4935,7 +4929,6 @@ namespace WixToolset.Core
         /// <param name="node">Element to parse.</param>
         /// <param name="parentType">The type of parent.</param>
         /// <param name="parentId">Optional identifier for parent feature.</param>
-        [System.Diagnostics.CodeAnalysis.SuppressMessage("Microsoft.Performance", "CA1800:DoNotCastUnnecessarily")]
         private void ParseFeatureRefElement(XElement node, ComplexReferenceParentType parentType, string parentId)
         {
             var sourceLineNumbers = Preprocessor.GetSourceLineNumbers(node);
@@ -5029,7 +5022,6 @@ namespace WixToolset.Core
         /// <param name="node">Element to parse.</param>
         /// <param name="parentType"></param>
         /// <param name="parentId"></param>
-        [System.Diagnostics.CodeAnalysis.SuppressMessage("Microsoft.Performance", "CA1800:DoNotCastUnnecessarily")]
         private void ParseFeatureGroupElement(XElement node, ComplexReferenceParentType parentType, string parentId)
         {
             var sourceLineNumbers = Preprocessor.GetSourceLineNumbers(node);
@@ -5484,7 +5476,6 @@ namespace WixToolset.Core
         /// <param name="win64Component">true if the component is 64-bit.</param>
         /// <param name="componentGuid"></param>
         /// <returns>Yes if this element was marked as the parent component's key path, No if explicitly marked as not being a key path, or NotSet otherwise.</returns>
-        [SuppressMessage("Microsoft.Performance", "CA1800:DoNotCastUnnecessarily")]
         private YesNoType ParseFileElement(XElement node, string componentId, string directoryId, int diskId, string sourcePath, out string possibleKeyPath, bool win64Component, string componentGuid)
         {
             var sourceLineNumbers = Preprocessor.GetSourceLineNumbers(node);
diff --git a/src/WixToolset.Core/CompilerCore.cs b/src/WixToolset.Core/CompilerCore.cs
index 50b88e51..1f6d6329 100644
--- a/src/WixToolset.Core/CompilerCore.cs
+++ b/src/WixToolset.Core/CompilerCore.cs
@@ -493,7 +493,6 @@ namespace WixToolset.Core
         /// <param name="attribute">The attribute containing the value to get.</param>
         /// <param name="emptyRule">A rule for the contents of the value. If the contents do not follow the rule, an error is thrown.</param>
         /// <returns>The attribute's value.</returns>
-        [SuppressMessage("Microsoft.Design", "CA1059:MembersShouldNotExposeCertainConcreteTypes")]
         public string GetAttributeValue(SourceLineNumber sourceLineNumbers, XAttribute attribute, EmptyRule emptyRule = EmptyRule.CanBeWhitespaceOnly)
         {
             return this.parseHelper.GetAttributeValue(sourceLineNumbers, attribute, emptyRule);
@@ -505,7 +504,6 @@ namespace WixToolset.Core
         /// <param name="sourceLineNumbers">Source line information about the owner element.</param>
         /// <param name="attribute">The attribute containing the value to get.</param>
         /// <returns>A valid code page integer value.</returns>
-        [SuppressMessage("Microsoft.Design", "CA1059:MembersShouldNotExposeCertainConcreteTypes")]
         public int GetAttributeCodePageValue(SourceLineNumber sourceLineNumbers, XAttribute attribute)
         {
             if (null == attribute)
@@ -535,7 +533,6 @@ namespace WixToolset.Core
         /// <param name="attribute">The attribute containing the value to get.</param>
         /// <param name="onlyAnsi">Whether to allow Unicode (UCS) or UTF code pages.</param>
         /// <returns>A valid code page integer value or variable expression.</returns>
-        [SuppressMessage("Microsoft.Design", "CA1059:MembersShouldNotExposeCertainConcreteTypes")]
         public string GetAttributeLocalizableCodePageValue(SourceLineNumber sourceLineNumbers, XAttribute attribute, bool onlyAnsi = false)
         {
             if (null == attribute)
@@ -577,7 +574,6 @@ namespace WixToolset.Core
         /// <param name="minimum">The minimum legal value.</param>
         /// <param name="maximum">The maximum legal value.</param>
         /// <returns>The attribute's integer value or a special value if an error occurred during conversion.</returns>
-        [SuppressMessage("Microsoft.Design", "CA1059:MembersShouldNotExposeCertainConcreteTypes")]
         public int GetAttributeIntegerValue(SourceLineNumber sourceLineNumbers, XAttribute attribute, int minimum, int maximum)
         {
             return this.parseHelper.GetAttributeIntegerValue(sourceLineNumbers, attribute, minimum, maximum);
@@ -602,7 +598,6 @@ namespace WixToolset.Core
         /// <param name="sourceLineNumbers">Source line information about the owner element.</param>
         /// <param name="attribute">The attribute containing the value to get.</param>
         /// <returns>Int representation of the date time.</returns>
-        [SuppressMessage("Microsoft.Design", "CA1059:MembersShouldNotExposeCertainConcreteTypes")]
         public int GetAttributeDateTimeValue(SourceLineNumber sourceLineNumbers, XAttribute attribute)
         {
             if (null == attribute)
@@ -748,7 +743,6 @@ namespace WixToolset.Core
         /// <param name="sourceLineNumbers">Source line information about the owner element.</param>
         /// <param name="attribute">The attribute containing the value to get.</param>
         /// <returns>The attribute's YesNoDefaultType value.</returns>
-        [SuppressMessage("Microsoft.Design", "CA1059:MembersShouldNotExposeCertainConcreteTypes")]
         public YesNoDefaultType GetAttributeYesNoDefaultValue(SourceLineNumber sourceLineNumbers, XAttribute attribute)
         {
             return this.parseHelper.GetAttributeYesNoDefaultValue(sourceLineNumbers, attribute);
@@ -793,7 +787,6 @@ namespace WixToolset.Core
         /// <param name="allowWildcards">true if wildcards are allowed in the filename.</param>
         /// <param name="allowRelative">true if relative paths are allowed in the filename.</param>
         /// <returns>The attribute's long filename value.</returns>
-        [SuppressMessage("Microsoft.Design", "CA1059:MembersShouldNotExposeCertainConcreteTypes")]
         public string GetAttributeLongFilename(SourceLineNumber sourceLineNumbers, XAttribute attribute, bool allowWildcards = false, bool allowRelative = false)
         {
             return this.parseHelper.GetAttributeLongFilename(sourceLineNumbers, attribute, allowWildcards, allowRelative);
@@ -817,7 +810,6 @@ namespace WixToolset.Core
         /// <param name="attribute">The attribute containing the value to get.</param>
         /// <param name="allowHkmu">Whether HKMU is returned as -1 (true), or treated as an error (false).</param>
         /// <returns>The attribute's RegisitryRootType value.</returns>
-        [SuppressMessage("Microsoft.Design", "CA1059:MembersShouldNotExposeCertainConcreteTypes")]
         public RegistryRootType? GetAttributeRegistryRootValue(SourceLineNumber sourceLineNumbers, XAttribute attribute, bool allowHkmu)
         {
             return this.parseHelper.GetAttributeRegistryRootValue(sourceLineNumbers, attribute, allowHkmu);
@@ -829,7 +821,6 @@ namespace WixToolset.Core
         /// <param name="sourceLineNumbers">Source line information about the owner element.</param>
         /// <param name="attribute">The attribute containing the value to get.</param>
         /// <returns>The attribute's value.</returns>
-        [SuppressMessage("Microsoft.Design", "CA1059:MembersShouldNotExposeCertainConcreteTypes")]
         public string GetAttributeBundleVariableValue(SourceLineNumber sourceLineNumbers, XAttribute attribute)
         {
             string value = this.GetAttributeValue(sourceLineNumbers, attribute);
@@ -852,7 +843,6 @@ namespace WixToolset.Core
         /// <param name="sourceLineNumbers">Source line information about the owner element.</param>
         /// <param name="attribute">The attribute containing the value to get.</param>
         /// <returns>The attribute's value.</returns>
-        [SuppressMessage("Microsoft.Design", "CA1059:MembersShouldNotExposeCertainConcreteTypes")]
         public string GetAttributeMsiPropertyNameValue(SourceLineNumber sourceLineNumbers, XAttribute attribute)
         {
             string value = this.GetAttributeValue(sourceLineNumbers, attribute);
@@ -885,7 +875,6 @@ namespace WixToolset.Core
         /// <param name="prefix">Three letter or less prefix for generated row identifier.</param>
         /// <param name="args">Information to hash.</param>
         /// <returns>The generated identifier.</returns>
-        [SuppressMessage("Microsoft.Globalization", "CA1303:DoNotPassLiteralsAsLocalizedParameters", MessageId = "System.InvalidOperationException.#ctor(System.String)")]
         public Identifier CreateIdentifier(string prefix, params string[] args)
         {
             return this.parseHelper.CreateIdentifier(prefix, args);
diff --git a/src/WixToolset.Core/Compiler_2.cs b/src/WixToolset.Core/Compiler_2.cs
index d2a6bb83..af56f0ef 100644
--- a/src/WixToolset.Core/Compiler_2.cs
+++ b/src/WixToolset.Core/Compiler_2.cs
@@ -1523,9 +1523,6 @@ namespace WixToolset.Core
         /// <param name="win64Component">true if the component is 64-bit.</param>
         /// <param name="possibleKeyPath">Identifier of this registry key since it could be the component's keypath.</param>
         /// <returns>Yes if this element was marked as the parent component's key path, No if explicitly marked as not being a key path, or NotSet otherwise.</returns>
-        [SuppressMessage("Microsoft.Globalization", "CA1308:NormalizeStringsToUppercase", Justification = "Changing the way this string normalizes would result " +
-                         "in a change to the way the Registry table is generated, potentially causing extra churn in patches on an MSI built from an older version of WiX. " +
-                         "Furthermore, there is no security hole here, as the strings won't need to make a round trip")]
         private YesNoType ParseRegistryKeyElement(XElement node, string componentId, RegistryRootType? root, string parentKey, bool win64Component, out string possibleKeyPath)
         {
             var sourceLineNumbers = Preprocessor.GetSourceLineNumbers(node);
@@ -1718,9 +1715,6 @@ namespace WixToolset.Core
         /// <param name="win64Component">true if the component is 64-bit.</param>
         /// <param name="possibleKeyPath">Identifier of this registry key since it could be the component's keypath.</param>
         /// <returns>Yes if this element was marked as the parent component's key path, No if explicitly marked as not being a key path, or NotSet otherwise.</returns>
-        [SuppressMessage("Microsoft.Globalization", "CA1308:NormalizeStringsToUppercase", Justification = "Changing the way this string normalizes would result " +
-                         "in a change to the way the Registry table is generated, potentially causing extra churn in patches on an MSI built from an older version of WiX. " +
-                         "Furthermore, there is no security hole here, as the strings won't need to make a round trip")]
         private YesNoType ParseRegistryValueElement(XElement node, string componentId, RegistryRootType? root, string parentKey, bool win64Component, out string possibleKeyPath)
         {
             var sourceLineNumbers = Preprocessor.GetSourceLineNumbers(node);
@@ -1994,9 +1988,6 @@ namespace WixToolset.Core
         /// </summary>
         /// <param name="node">The element to parse.</param>
         /// <param name="componentId">The component identifier of the parent element.</param>
-        [SuppressMessage("Microsoft.Globalization", "CA1308:NormalizeStringsToUppercase", Justification = "Changing the way this string normalizes would result " +
-                         "in a change to the way the Registry table is generated, potentially causing extra churn in patches on an MSI built from an older version of WiX. " +
-                         "Furthermore, there is no security hole here, as the strings won't need to make a round trip")]
         private void ParseRemoveRegistryKeyElement(XElement node, string componentId)
         {
             var sourceLineNumbers = Preprocessor.GetSourceLineNumbers(node);
@@ -2097,9 +2088,6 @@ namespace WixToolset.Core
         /// </summary>
         /// <param name="node">The element to parse.</param>
         /// <param name="componentId">The component identifier of the parent element.</param>
-        [SuppressMessage("Microsoft.Globalization", "CA1308:NormalizeStringsToUppercase", Justification = "Changing the way this string normalizes would result " +
-                         "in a change to the way the Registry table is generated, potentially causing extra churn in patches on an MSI built from an older version of WiX. " +
-                         "Furthermore, there is no security hole here, as the strings won't need to make a round trip")]
         private void ParseRemoveRegistryValueElement(XElement node, string componentId)
         {
             var sourceLineNumbers = Preprocessor.GetSourceLineNumbers(node);
diff --git a/src/WixToolset.Core/Compiler_Patch.cs b/src/WixToolset.Core/Compiler_Patch.cs
index eb99d5c4..2fb1affb 100644
--- a/src/WixToolset.Core/Compiler_Patch.cs
+++ b/src/WixToolset.Core/Compiler_Patch.cs
@@ -448,7 +448,6 @@ namespace WixToolset.Core
         /// <param name="node">Element to parse.</param>
         /// <param name="parentType"></param>
         /// <param name="parentId"></param>
-        [System.Diagnostics.CodeAnalysis.SuppressMessage("Microsoft.Performance", "CA1800:DoNotCastUnnecessarily")]
         private void ParsePatchFamilyGroupElement(XElement node, ComplexReferenceParentType parentType, string parentId)
         {
             var sourceLineNumbers = Preprocessor.GetSourceLineNumbers(node);