diff options
| author | Rob Mensching <rob@firegiant.com> | 2022-09-03 11:00:16 -0700 |
|---|---|---|
| committer | Rob Mensching <rob@firegiant.com> | 2022-09-23 09:50:52 -0700 |
| commit | 7074da16f85458e535f38c68830ee56361f119f6 (patch) | |
| tree | a091727bf7e41683d87be0aab49033b23bdc980e /src | |
| parent | 7a86b33a38f29b315e8f08759eba42e8fe296fd7 (diff) | |
| download | wix-7074da16f85458e535f38c68830ee56361f119f6.tar.gz wix-7074da16f85458e535f38c68830ee56361f119f6.tar.bz2 wix-7074da16f85458e535f38c68830ee56361f119f6.zip | |
Re-enable and update a patching test fixed previously
Diffstat (limited to 'src')
| -rw-r--r-- | src/wix/test/WixToolsetTest.CoreIntegration/PatchFixture.cs | 17 | ||||
| -rw-r--r-- | src/wix/test/WixToolsetTest.CoreIntegration/TestData/PatchFromWixlib/Package.wxs | 8 |
2 files changed, 12 insertions, 13 deletions
diff --git a/src/wix/test/WixToolsetTest.CoreIntegration/PatchFixture.cs b/src/wix/test/WixToolsetTest.CoreIntegration/PatchFixture.cs index 334d03dc..aa1ea6b3 100644 --- a/src/wix/test/WixToolsetTest.CoreIntegration/PatchFixture.cs +++ b/src/wix/test/WixToolsetTest.CoreIntegration/PatchFixture.cs | |||
| @@ -191,20 +191,21 @@ namespace WixToolsetTest.CoreIntegration | |||
| 191 | } | 191 | } |
| 192 | } | 192 | } |
| 193 | 193 | ||
| 194 | [Fact(Skip = "https://github.com/wixtoolset/issues/issues/6387")] | 194 | [Fact] |
| 195 | public void CanBuildPatchFromProductWithFilesFromWixlib() | 195 | public void CanBuildPatchFromProductWithFilesFromWixlib() |
| 196 | { | 196 | { |
| 197 | var folder = TestData.Get(@"TestData\PatchFromWixlib"); | 197 | var sourceFolder = TestData.Get(@"TestData", "PatchFromWixlib"); |
| 198 | 198 | ||
| 199 | using (var fs = new DisposableFileSystem()) | 199 | using (var fs = new DisposableFileSystem()) |
| 200 | { | 200 | { |
| 201 | var tempFolderBaseline = fs.GetFolder(); | 201 | var baseFolder = fs.GetFolder(); |
| 202 | var tempFolderUpdate = fs.GetFolder(); | 202 | var tempFolderBaseline = Path.Combine(baseFolder, "baseline"); |
| 203 | var tempFolderPatch = fs.GetFolder(); | 203 | var tempFolderUpdate = Path.Combine(baseFolder, "update"); |
| 204 | var tempFolderPatch = Path.Combine(baseFolder, "patch"); | ||
| 204 | 205 | ||
| 205 | var baselinePdb = BuildMsi("Baseline.msi", folder, tempFolderBaseline, "1.0.0", "1.0.0", "1.0.0"); | 206 | var baselinePdb = BuildMsi("Baseline.msi", sourceFolder, tempFolderBaseline, "1.0.0", "1.0.0", "1.0.0"); |
| 206 | var update1Pdb = BuildMsi("Update.msi", folder, tempFolderUpdate, "1.0.1", "1.0.1", "1.0.1"); | 207 | var update1Pdb = BuildMsi("Update.msi", sourceFolder, tempFolderUpdate, "1.0.1", "1.0.1", "1.0.1"); |
| 207 | var patchPdb = BuildMsp("Patch1.msp", folder, tempFolderPatch, "1.0.1", bindpaths: new[] { Path.GetDirectoryName(baselinePdb), Path.GetDirectoryName(update1Pdb) }, hasNoFiles: true); | 208 | var patchPdb = BuildMsp("Patch1.msp", sourceFolder, tempFolderPatch, "1.0.1", bindpaths: new[] { Path.GetDirectoryName(baselinePdb), Path.GetDirectoryName(update1Pdb) }, hasNoFiles: true); |
| 208 | var patchPath = Path.ChangeExtension(patchPdb, ".msp"); | 209 | var patchPath = Path.ChangeExtension(patchPdb, ".msp"); |
| 209 | 210 | ||
| 210 | Assert.True(File.Exists(baselinePdb)); | 211 | Assert.True(File.Exists(baselinePdb)); |
diff --git a/src/wix/test/WixToolsetTest.CoreIntegration/TestData/PatchFromWixlib/Package.wxs b/src/wix/test/WixToolsetTest.CoreIntegration/TestData/PatchFromWixlib/Package.wxs index 5cb8ede8..5cab1dbd 100644 --- a/src/wix/test/WixToolsetTest.CoreIntegration/TestData/PatchFromWixlib/Package.wxs +++ b/src/wix/test/WixToolsetTest.CoreIntegration/TestData/PatchFromWixlib/Package.wxs | |||
| @@ -5,11 +5,9 @@ | |||
| 5 | 5 | ||
| 6 | <CustomAction Id="CAFromExtension" DllEntry="DoesntExist" BinaryRef="BinFromWir" /> | 6 | <CustomAction Id="CAFromExtension" DllEntry="DoesntExist" BinaryRef="BinFromWir" /> |
| 7 | 7 | ||
| 8 | <Directory Id="TARGETDIR" Name="SourceDir"> | 8 | <StandardDirectory Id="ProgramFilesFolder"> |
| 9 | <Directory Id="ProgramFilesFolder"> | 9 | <Directory Id="INSTALLFOLDER" Name="~Test App" /> |
| 10 | <Directory Id="INSTALLFOLDER" Name="~Test App" /> | 10 | </StandardDirectory> |
| 11 | </Directory> | ||
| 12 | </Directory> | ||
| 13 | 11 | ||
| 14 | <Feature Id="Main"> | 12 | <Feature Id="Main"> |
| 15 | <ComponentGroupRef Id="Components" /> | 13 | <ComponentGroupRef Id="Components" /> |
