diff options
author | Rob Mensching <rob@firegiant.com> | 2021-04-10 15:06:58 -0700 |
---|---|---|
committer | Rob Mensching <rob@firegiant.com> | 2021-04-12 10:11:51 -0700 |
commit | 98c54e6a6dbf6dd8944eef12fa43a5cf79a2895d (patch) | |
tree | 1fbf6908626cd4c55ccd463b0657032d3b19707b /src | |
parent | b21d9d170e21c7a22e484f8d3740bca8bcaba47e (diff) | |
download | wix-98c54e6a6dbf6dd8944eef12fa43a5cf79a2895d.tar.gz wix-98c54e6a6dbf6dd8944eef12fa43a5cf79a2895d.tar.bz2 wix-98c54e6a6dbf6dd8944eef12fa43a5cf79a2895d.zip |
Improve duplicate GUID messages
Diffstat (limited to 'src')
-rw-r--r-- | src/WixToolset.Data/ErrorMessages.cs | 6 | ||||
-rw-r--r-- | src/WixToolset.Data/WarningMessages.cs | 4 |
2 files changed, 5 insertions, 5 deletions
diff --git a/src/WixToolset.Data/ErrorMessages.cs b/src/WixToolset.Data/ErrorMessages.cs index ffd975e3..86504f60 100644 --- a/src/WixToolset.Data/ErrorMessages.cs +++ b/src/WixToolset.Data/ErrorMessages.cs | |||
@@ -278,9 +278,9 @@ namespace WixToolset.Data | |||
278 | return Message(null, Ids.DuplicateCommandLineOptionInExtension, "The command line option '{0}' has already been loaded by another Heat extension.", arg); | 278 | return Message(null, Ids.DuplicateCommandLineOptionInExtension, "The command line option '{0}' has already been loaded by another Heat extension.", arg); |
279 | } | 279 | } |
280 | 280 | ||
281 | public static Message DuplicateComponentGuids(SourceLineNumber sourceLineNumbers, string componentId, string guid) | 281 | public static Message DuplicateComponentGuids(SourceLineNumber sourceLineNumbers, string componentId, string guid, string type, string keyPath) |
282 | { | 282 | { |
283 | return Message(sourceLineNumbers, Ids.DuplicateComponentGuids, "Component/@Id='{0}' has a @Guid value '{1}' that duplicates another component in this package. It is recommended to give each component its own unique GUID.", componentId, guid); | 283 | return Message(sourceLineNumbers, Ids.DuplicateComponentGuids, "Component/@Id='{0}' with {2} '{3}' has a @Guid value '{1}' that duplicates another component in this package. It is recommended to give each component its own unique GUID.", componentId, guid, type, keyPath); |
284 | } | 284 | } |
285 | 285 | ||
286 | public static Message DuplicateContextValue(SourceLineNumber sourceLineNumbers, string contextValue) | 286 | public static Message DuplicateContextValue(SourceLineNumber sourceLineNumbers, string contextValue) |
@@ -686,7 +686,7 @@ namespace WixToolset.Data | |||
686 | 686 | ||
687 | public static Message FinishCabFailed() | 687 | public static Message FinishCabFailed() |
688 | { | 688 | { |
689 | return Message(null, Ids.FinishCabFailed, "An error (E_FAIL) was returned while finalizing a CAB file. This most commonly happens when creating a CAB file with more than 65535 files in it. Either reduce the number of files in your installation package or split your installation package's files into more than one CAB file using the Media element."); | 689 | return Message(null, Ids.FinishCabFailed, "An error (E_FAIL) was returned while finalizing a CAB file. This most commonly happens when creating a CAB file with more than 65535 files in it or a compressed size greater than 2GB. Either reduce the number of files in your installation package or split your installation package's files into more than one CAB file using the Media element."); |
690 | } | 690 | } |
691 | 691 | ||
692 | public static Message FullTempDirectory(string prefix, string directory) | 692 | public static Message FullTempDirectory(string prefix, string directory) |
diff --git a/src/WixToolset.Data/WarningMessages.cs b/src/WixToolset.Data/WarningMessages.cs index 35f95af6..cf8fdfd9 100644 --- a/src/WixToolset.Data/WarningMessages.cs +++ b/src/WixToolset.Data/WarningMessages.cs | |||
@@ -242,9 +242,9 @@ namespace WixToolset.Data | |||
242 | return Message(sourceLineNumbers, Ids.DownloadUrlNotSupportedForEmbeddedPayloads, "The Payload '{0}' is embedded but included a @DownloadUrl attribute. Embedded Payloads cannot be downloaded so the download URL is being ignored.", payloadId); | 242 | return Message(sourceLineNumbers, Ids.DownloadUrlNotSupportedForEmbeddedPayloads, "The Payload '{0}' is embedded but included a @DownloadUrl attribute. Embedded Payloads cannot be downloaded so the download URL is being ignored.", payloadId); |
243 | } | 243 | } |
244 | 244 | ||
245 | public static Message DuplicateComponentGuidsMustHaveMutuallyExclusiveConditions(SourceLineNumber sourceLineNumbers, string componentId, string guid) | 245 | public static Message DuplicateComponentGuidsMustHaveMutuallyExclusiveConditions(SourceLineNumber sourceLineNumbers, string componentId, string guid, string type, string keyPath) |
246 | { | 246 | { |
247 | return Message(sourceLineNumbers, Ids.DuplicateComponentGuidsMustHaveMutuallyExclusiveConditions, "Component/@Id='{0}' has a @Guid value '{1}' that duplicates another component in this package. This is not officially supported by Windows Installer but works as long as all components have mutually-exclusive conditions. It is recommended to give each component its own unique GUID.", componentId, guid); | 247 | return Message(sourceLineNumbers, Ids.DuplicateComponentGuidsMustHaveMutuallyExclusiveConditions, "Component/@Id='{0}' with {2} '{3}' has a @Guid value '{1}' that duplicates another component in this package. This is not officially supported by Windows Installer and cannot be used when creating patches. It otherwise works as long as all components with the same GUID have mutually-exclusive conditions. It is recommended to give each component its own unique GUID.", componentId, guid, type, keyPath); |
248 | } | 248 | } |
249 | 249 | ||
250 | public static Message DuplicatePrimaryKey(SourceLineNumber sourceLineNumbers, string primaryKey, string tableName) | 250 | public static Message DuplicatePrimaryKey(SourceLineNumber sourceLineNumbers, string primaryKey, string tableName) |