Detect Inability to write to output file

Fixes wixtoolset/issues#6425

2 files changed, 35 insertions, 9 deletions

diff --git a/src/WixToolset.Converters/WixConverter.cs b/src/WixToolset.Converters/WixConverter.cs
index 80784807..6080eeb9 100644
--- a/src/WixToolset.Converters/WixConverter.cs
+++ b/src/WixToolset.Converters/WixConverter.cs
@@ -1848,8 +1848,8 @@ namespace WixToolset.Converters
         {
             // Ignore the error if explicitly ignored or outside the range of the current operation.
             if (this.IgnoreErrors.Contains(converterTestType) ||
-                (this.Operation == ConvertOperation.Convert && converterTestType < ConverterTestType.DeclarationPresent) ||
-                (this.Operation == ConvertOperation.Format && converterTestType > ConverterTestType.DeclarationPresent))
+                (this.Operation == ConvertOperation.Convert && converterTestType < ConverterTestType.EndIgnoreInConvert) ||
+                (this.Operation == ConvertOperation.Format && converterTestType > ConverterTestType.BeginIgnoreInFormat))
             {
                 return false;
             }
@@ -2033,11 +2033,6 @@ namespace WixToolset.Converters
             XmlException,
 
             /// <summary>
-            /// Displayed when a file cannot be accessed; typically when trying to save back a fixed file.
-            /// </summary>
-            UnauthorizedAccessException,
-
-            /// <summary>
             /// Displayed when the whitespace preceding a node is wrong.
             /// </summary>
             WhitespacePrecedingNodeWrong,
@@ -2047,14 +2042,21 @@ namespace WixToolset.Converters
             /// </summary>
             WhitespacePrecedingEndElementWrong,
 
-            // Before this point, ignore errors on convert operation
+            /// Before this point, ignore errors on convert operation
+            EndIgnoreInConvert,
 
             /// <summary>
             /// Displayed when the XML declaration is present in the source file.
             /// </summary>
             DeclarationPresent,
 
-            // After this point, ignore errors on format operation
+            /// <summary>
+            /// Displayed when a file cannot be accessed; typically when trying to save back a fixed file.
+            /// </summary>
+            UnauthorizedAccessException,
+
+            /// After this point, ignore errors on format operation
+            BeginIgnoreInFormat,
 
             /// <summary>
             /// Displayed when the xmlns attribute is missing from the document element.
diff --git a/src/test/WixToolsetTest.Converters/ConverterIntegrationFixture.cs b/src/test/WixToolsetTest.Converters/ConverterIntegrationFixture.cs
index cabc89ee..acd7991e 100644
--- a/src/test/WixToolsetTest.Converters/ConverterIntegrationFixture.cs
+++ b/src/test/WixToolsetTest.Converters/ConverterIntegrationFixture.cs
@@ -8,6 +8,7 @@ namespace WixToolsetTest.Converters
     using WixBuildTools.TestSupport;
     using WixToolset.Converters;
     using WixToolset.Core;
+    using WixToolset.Core.ExtensibilityServices;
     using WixToolset.Core.TestPackage;
     using WixToolsetTest.Converters.Mocks;
     using Xunit;
@@ -69,6 +70,29 @@ namespace WixToolsetTest.Converters
         }
 
         [Fact]
+        public void CanDetectReadOnlyOutputFile()
+        {
+            const string beforeFileName = "SingleFile.wxs";
+            var folder = TestData.Get(@"TestData\SingleFile");
+
+            using (var fs = new DisposableFileSystem())
+            {
+                var baseFolder = fs.GetFolder(true);
+                var targetFile = Path.Combine(baseFolder, beforeFileName);
+                File.Copy(Path.Combine(folder, beforeFileName), Path.Combine(baseFolder, beforeFileName));
+
+                var info = new FileInfo(targetFile);
+                info.IsReadOnly = true;
+
+                var messaging = new MockMessaging();
+                var converter = new WixConverter(messaging, 4);
+                var errors = converter.ConvertFile(targetFile, true);
+
+                Assert.Equal(10, errors);
+            }
+        }
+
+        [Fact]
         public void RetainsPreprocessorInstructions()
         {
             const string beforeFileName = "Preprocessor.wxs";