aboutsummaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorBob Arnson <bob@firegiant.com>2020-01-21 19:12:53 -0500
committerBob Arnson <bob@firegiant.com>2020-01-21 19:21:06 -0500
commitc2bc01b47cca2a70ddeb2cc9e9b2e3b9906bb647 (patch)
tree3008926e61606108768fa7df0e67d7ca5be11fb1 /src
parent772ed422f3195c899246f16c9c2e5b5a839d06cd (diff)
downloadwix-c2bc01b47cca2a70ddeb2cc9e9b2e3b9906bb647.tar.gz
wix-c2bc01b47cca2a70ddeb2cc9e9b2e3b9906bb647.tar.bz2
wix-c2bc01b47cca2a70ddeb2cc9e9b2e3b9906bb647.zip
Fix ServiceControl/@Wait translation.
Diffstat (limited to 'src')
-rw-r--r--src/WixToolset.Core.WindowsInstaller/Bind/CreateOutputFromIRCommand.cs5
-rw-r--r--src/test/WixToolsetTest.CoreIntegration/MsiQueryFixture.cs5
-rw-r--r--src/test/WixToolsetTest.CoreIntegration/TestData/ServiceInstall/OwnProcess.wxs3
3 files changed, 9 insertions, 4 deletions
diff --git a/src/WixToolset.Core.WindowsInstaller/Bind/CreateOutputFromIRCommand.cs b/src/WixToolset.Core.WindowsInstaller/Bind/CreateOutputFromIRCommand.cs
index 16517e91..31d0b3a6 100644
--- a/src/WixToolset.Core.WindowsInstaller/Bind/CreateOutputFromIRCommand.cs
+++ b/src/WixToolset.Core.WindowsInstaller/Bind/CreateOutputFromIRCommand.cs
@@ -803,7 +803,10 @@ namespace WixToolset.Core.WindowsInstaller.Bind
803 row[1] = tuple.Name; 803 row[1] = tuple.Name;
804 row[2] = events; 804 row[2] = events;
805 row[3] = tuple.Arguments; 805 row[3] = tuple.Arguments;
806 row[4] = tuple.Wait; 806 if (tuple.Wait.HasValue)
807 {
808 row[4] = tuple.Wait.Value ? 1 : 0;
809 }
807 row[5] = tuple.ComponentRef; 810 row[5] = tuple.ComponentRef;
808 } 811 }
809 812
diff --git a/src/test/WixToolsetTest.CoreIntegration/MsiQueryFixture.cs b/src/test/WixToolsetTest.CoreIntegration/MsiQueryFixture.cs
index 200ba7b8..18380417 100644
--- a/src/test/WixToolsetTest.CoreIntegration/MsiQueryFixture.cs
+++ b/src/test/WixToolsetTest.CoreIntegration/MsiQueryFixture.cs
@@ -817,7 +817,7 @@ namespace WixToolsetTest.CoreIntegration
817 } 817 }
818 818
819 [Fact] 819 [Fact]
820 public void PopulatesServiceInstallTable() 820 public void PopulatesServiceTables()
821 { 821 {
822 var folder = TestData.Get(@"TestData"); 822 var folder = TestData.Get(@"TestData");
823 823
@@ -841,9 +841,10 @@ namespace WixToolsetTest.CoreIntegration
841 result.AssertSuccess(); 841 result.AssertSuccess();
842 842
843 Assert.True(File.Exists(msiPath)); 843 Assert.True(File.Exists(msiPath));
844 var results = Query.QueryDatabase(msiPath, new[] { "ServiceInstall" }); 844 var results = Query.QueryDatabase(msiPath, new[] { "ServiceInstall", "ServiceControl" });
845 Assert.Equal(new[] 845 Assert.Equal(new[]
846 { 846 {
847 "ServiceControl:SampleService\tSampleService\t161\t\t1\ttest.txt",
847 "ServiceInstall:SampleService\tSampleService\t\t16\t4\t0\t\t\t\t\t\ttest.txt\t", 848 "ServiceInstall:SampleService\tSampleService\t\t16\t4\t0\t\t\t\t\t\ttest.txt\t",
848 }, results); 849 }, results);
849 } 850 }
diff --git a/src/test/WixToolsetTest.CoreIntegration/TestData/ServiceInstall/OwnProcess.wxs b/src/test/WixToolsetTest.CoreIntegration/TestData/ServiceInstall/OwnProcess.wxs
index 596e98a6..65cba20e 100644
--- a/src/test/WixToolsetTest.CoreIntegration/TestData/ServiceInstall/OwnProcess.wxs
+++ b/src/test/WixToolsetTest.CoreIntegration/TestData/ServiceInstall/OwnProcess.wxs
@@ -4,7 +4,8 @@
4 <ComponentGroup Id="ProductComponents"> 4 <ComponentGroup Id="ProductComponents">
5 <Component Directory="INSTALLFOLDER"> 5 <Component Directory="INSTALLFOLDER">
6 <File Id="test.txt" Source="test.txt" /> 6 <File Id="test.txt" Source="test.txt" />
7 <ServiceInstall Name="SampleService" ErrorControl="ignore" Start="disabled" Type="ownProcess"></ServiceInstall> 7 <ServiceInstall Name="SampleService" ErrorControl="ignore" Start="disabled" Type="ownProcess" />
8 <ServiceControl Name="SampleService" Start="install" Stop="uninstall" Remove="uninstall" Wait="yes" />
8 </Component> 9 </Component>
9 </ComponentGroup> 10 </ComponentGroup>
10 </Fragment> 11 </Fragment>