aboutsummaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorBob Arnson <bob@firegiant.com>2019-12-11 21:52:38 -0500
committerBob Arnson <bob@firegiant.com>2019-12-11 21:57:08 -0500
commitc53d0d1cc57ce3ed1450adb2c469e2b747584159 (patch)
treeeddf0d1145c0abca3bafc0ca317d27ad4110b079 /src
parent54ade276db9bd437375a57bddc9eb88a21a6ea7a (diff)
downloadwix-c53d0d1cc57ce3ed1450adb2c469e2b747584159.tar.gz
wix-c53d0d1cc57ce3ed1450adb2c469e2b747584159.tar.bz2
wix-c53d0d1cc57ce3ed1450adb2c469e2b747584159.zip
Exclude null output from report of extracted files.
Diffstat (limited to 'src')
-rw-r--r--src/WixToolset.Core.Native/Cabinet.cs2
-rw-r--r--src/test/WixToolsetTest.Core.Native/CabinetFixture.cs14
2 files changed, 10 insertions, 6 deletions
diff --git a/src/WixToolset.Core.Native/Cabinet.cs b/src/WixToolset.Core.Native/Cabinet.cs
index 74ab7809..2d624658 100644
--- a/src/WixToolset.Core.Native/Cabinet.cs
+++ b/src/WixToolset.Core.Native/Cabinet.cs
@@ -108,7 +108,7 @@ namespace WixToolset.Core.Native
108 } 108 }
109 109
110 var wixnative = new WixNativeExe("extractcab", this.Path, outputFolder); 110 var wixnative = new WixNativeExe("extractcab", this.Path, outputFolder);
111 return wixnative.Run(); 111 return wixnative.Run().Where(output => !String.IsNullOrWhiteSpace(output));
112 } 112 }
113 113
114#if TOOD_ERROR_HANDLING 114#if TOOD_ERROR_HANDLING
diff --git a/src/test/WixToolsetTest.Core.Native/CabinetFixture.cs b/src/test/WixToolsetTest.Core.Native/CabinetFixture.cs
index fba0d5c9..4f5a3427 100644
--- a/src/test/WixToolsetTest.Core.Native/CabinetFixture.cs
+++ b/src/test/WixToolsetTest.Core.Native/CabinetFixture.cs
@@ -56,9 +56,9 @@ namespace WixToolsetTest.CoreNative
56 var extractFolder = fs.GetFolder(true); 56 var extractFolder = fs.GetFolder(true);
57 57
58 var cabinet = new Cabinet(cabinetPath); 58 var cabinet = new Cabinet(cabinetPath);
59 cabinet.Extract(extractFolder); 59 var reportedFiles = cabinet.Extract(extractFolder);
60
61 var files = Directory.EnumerateFiles(extractFolder); 60 var files = Directory.EnumerateFiles(extractFolder);
61 Assert.Equal(reportedFiles, files.Select(f => Path.GetFileName(f)));
62 62
63 var file = new FileInfo(files.Single()); 63 var file = new FileInfo(files.Single());
64 CabInterop.DateTimeToCabDateAndTime(file.CreationTime, out var date, out var time); 64 CabInterop.DateTimeToCabDateAndTime(file.CreationTime, out var date, out var time);
@@ -81,7 +81,10 @@ namespace WixToolsetTest.CoreNative
81 81
82 // Compress. 82 // Compress.
83 { 83 {
84 var files = new[] { new CabinetCompressFile(TestData.Get(@"TestData\test.txt"), "test.txt") }; 84 var files = new[] {
85 new CabinetCompressFile(TestData.Get(@"TestData\test.txt"), "test1.txt"),
86 new CabinetCompressFile(TestData.Get(@"TestData\test.txt"), "test2.txt"),
87 };
85 88
86 var cabinet = new Cabinet(cabinetPath); 89 var cabinet = new Cabinet(cabinetPath);
87 cabinet.Compress(files, CompressionLevel.Low); 90 cabinet.Compress(files, CompressionLevel.Low);
@@ -90,7 +93,8 @@ namespace WixToolsetTest.CoreNative
90 // Extract. 93 // Extract.
91 { 94 {
92 var cabinet = new Cabinet(cabinetPath); 95 var cabinet = new Cabinet(cabinetPath);
93 cabinet.Extract(extractFolder); 96 var reportedFiles = cabinet.Extract(extractFolder);
97 Assert.Equal(2, reportedFiles.Count());
94 } 98 }
95 99
96 // Enumerate to compare cabinet to extracted files. 100 // Enumerate to compare cabinet to extracted files.
@@ -100,7 +104,7 @@ namespace WixToolsetTest.CoreNative
100 104
101 var files = Directory.EnumerateFiles(extractFolder).OrderBy(f => f).ToArray(); 105 var files = Directory.EnumerateFiles(extractFolder).OrderBy(f => f).ToArray();
102 106
103 for (var i =0; i < enumerated.Length; ++i) 107 for (var i = 0; i < enumerated.Length; ++i)
104 { 108 {
105 var cabFileInfo = enumerated[i]; 109 var cabFileInfo = enumerated[i];
106 var fileInfo = new FileInfo(files[i]); 110 var fileInfo = new FileInfo(files[i]);