diff options
author | Rob Mensching <rob@firegiant.com> | 2019-10-07 13:21:29 -0700 |
---|---|---|
committer | Rob Mensching <rob@firegiant.com> | 2019-10-07 21:44:46 -0700 |
commit | d3b12de2f22eb552e073f0c949833a7ef4d4f13c (patch) | |
tree | 87e6148d06a07ea57ba20f4fa2f245a4f5a5546c /src | |
parent | 860676fa5b40a1904478151e9b4934c004e7db63 (diff) | |
download | wix-d3b12de2f22eb552e073f0c949833a7ef4d4f13c.tar.gz wix-d3b12de2f22eb552e073f0c949833a7ef4d4f13c.tar.bz2 wix-d3b12de2f22eb552e073f0c949833a7ef4d4f13c.zip |
Fix AppSearch related building
Diffstat (limited to 'src')
-rw-r--r-- | src/WixToolset.Core.WindowsInstaller/Bind/CreateOutputFromIRCommand.cs | 6 | ||||
-rw-r--r-- | src/WixToolset.Core/Compiler.cs | 7 | ||||
-rw-r--r-- | src/test/WixToolsetTest.CoreIntegration/MsiQueryFixture.cs | 10 |
3 files changed, 15 insertions, 8 deletions
diff --git a/src/WixToolset.Core.WindowsInstaller/Bind/CreateOutputFromIRCommand.cs b/src/WixToolset.Core.WindowsInstaller/Bind/CreateOutputFromIRCommand.cs index cd3a67fa..170b138d 100644 --- a/src/WixToolset.Core.WindowsInstaller/Bind/CreateOutputFromIRCommand.cs +++ b/src/WixToolset.Core.WindowsInstaller/Bind/CreateOutputFromIRCommand.cs | |||
@@ -152,6 +152,10 @@ namespace WixToolset.Core.WindowsInstaller.Bind | |||
152 | case TupleDefinitionType.Shortcut: | 152 | case TupleDefinitionType.Shortcut: |
153 | this.AddShortcutTuple((ShortcutTuple)tuple, output); | 153 | this.AddShortcutTuple((ShortcutTuple)tuple, output); |
154 | break; | 154 | break; |
155 | |||
156 | case TupleDefinitionType.Signature: | ||
157 | this.AddTupleDefaultly(tuple, output, true); | ||
158 | break; | ||
155 | 159 | ||
156 | case TupleDefinitionType.SummaryInformation: | 160 | case TupleDefinitionType.SummaryInformation: |
157 | this.AddTupleDefaultly(tuple, output, tableName: "_SummaryInformation"); | 161 | this.AddTupleDefaultly(tuple, output, tableName: "_SummaryInformation"); |
@@ -917,7 +921,7 @@ namespace WixToolset.Core.WindowsInstaller.Bind | |||
917 | { | 921 | { |
918 | if (i < tableDefinition.Columns.Length) | 922 | if (i < tableDefinition.Columns.Length) |
919 | { | 923 | { |
920 | var column = tableDefinition.Columns[i]; | 924 | var column = tableDefinition.Columns[i + rowOffset]; |
921 | 925 | ||
922 | switch (column.Type) | 926 | switch (column.Type) |
923 | { | 927 | { |
diff --git a/src/WixToolset.Core/Compiler.cs b/src/WixToolset.Core/Compiler.cs index 3ee87872..c4bbf86d 100644 --- a/src/WixToolset.Core/Compiler.cs +++ b/src/WixToolset.Core/Compiler.cs | |||
@@ -322,8 +322,9 @@ namespace WixToolset.Core | |||
322 | this.Core.Write(ErrorMessages.SearchPropertyNotUppercase(sourceLineNumbers, "Property", "Id", propertyId.Id)); | 322 | this.Core.Write(ErrorMessages.SearchPropertyNotUppercase(sourceLineNumbers, "Property", "Id", propertyId.Id)); |
323 | } | 323 | } |
324 | 324 | ||
325 | var tuple = new AppSearchTuple(sourceLineNumbers, propertyId) | 325 | var tuple = new AppSearchTuple(sourceLineNumbers, new Identifier(propertyId.Access, propertyId.Id, signature)) |
326 | { | 326 | { |
327 | PropertyRef = propertyId.Id, | ||
327 | SignatureRef = signature | 328 | SignatureRef = signature |
328 | }; | 329 | }; |
329 | 330 | ||
@@ -2905,6 +2906,7 @@ namespace WixToolset.Core | |||
2905 | { | 2906 | { |
2906 | var tuple = new CompLocatorTuple(sourceLineNumbers, id) | 2907 | var tuple = new CompLocatorTuple(sourceLineNumbers, id) |
2907 | { | 2908 | { |
2909 | SignatureRef = id.Id, | ||
2908 | ComponentId = componentId, | 2910 | ComponentId = componentId, |
2909 | Type = type, | 2911 | Type = type, |
2910 | }; | 2912 | }; |
@@ -4482,7 +4484,7 @@ namespace WixToolset.Core | |||
4482 | signature = id.Id; | 4484 | signature = id.Id; |
4483 | } | 4485 | } |
4484 | 4486 | ||
4485 | var tuple = new DrLocatorTuple(sourceLineNumbers) | 4487 | var tuple = new DrLocatorTuple(sourceLineNumbers, new Identifier(access, rowId, parentSignature, path)) |
4486 | { | 4488 | { |
4487 | SignatureRef = rowId, | 4489 | SignatureRef = rowId, |
4488 | Parent = parentSignature, | 4490 | Parent = parentSignature, |
@@ -6793,6 +6795,7 @@ namespace WixToolset.Core | |||
6793 | { | 6795 | { |
6794 | var tuple = new IniLocatorTuple(sourceLineNumbers, id) | 6796 | var tuple = new IniLocatorTuple(sourceLineNumbers, id) |
6795 | { | 6797 | { |
6798 | SignatureRef = id.Id, | ||
6796 | FileName = this.GetMsiFilenameValue(shortName, name), | 6799 | FileName = this.GetMsiFilenameValue(shortName, name), |
6797 | Section = section, | 6800 | Section = section, |
6798 | Key = key, | 6801 | Key = key, |
diff --git a/src/test/WixToolsetTest.CoreIntegration/MsiQueryFixture.cs b/src/test/WixToolsetTest.CoreIntegration/MsiQueryFixture.cs index 826d8985..6ff4e237 100644 --- a/src/test/WixToolsetTest.CoreIntegration/MsiQueryFixture.cs +++ b/src/test/WixToolsetTest.CoreIntegration/MsiQueryFixture.cs | |||
@@ -9,7 +9,7 @@ namespace WixToolsetTest.CoreIntegration | |||
9 | 9 | ||
10 | public class MsiQueryFixture | 10 | public class MsiQueryFixture |
11 | { | 11 | { |
12 | [Fact(Skip = "Test demonstrates failure")] | 12 | [Fact] |
13 | public void PopulatesAppSearchTablesFromComponentSearch() | 13 | public void PopulatesAppSearchTablesFromComponentSearch() |
14 | { | 14 | { |
15 | var folder = TestData.Get(@"TestData"); | 15 | var folder = TestData.Get(@"TestData"); |
@@ -43,7 +43,7 @@ namespace WixToolsetTest.CoreIntegration | |||
43 | } | 43 | } |
44 | } | 44 | } |
45 | 45 | ||
46 | [Fact(Skip = "Test demonstrates failure")] | 46 | [Fact] |
47 | public void PopulatesAppSearchTablesFromDirectorySearch() | 47 | public void PopulatesAppSearchTablesFromDirectorySearch() |
48 | { | 48 | { |
49 | var folder = TestData.Get(@"TestData"); | 49 | var folder = TestData.Get(@"TestData"); |
@@ -71,13 +71,13 @@ namespace WixToolsetTest.CoreIntegration | |||
71 | var results = Query.QueryDatabase(msiPath, new[] { "AppSearch", "DrLocator" }); | 71 | var results = Query.QueryDatabase(msiPath, new[] { "AppSearch", "DrLocator" }); |
72 | Assert.Equal(new[] | 72 | Assert.Equal(new[] |
73 | { | 73 | { |
74 | "AppSearch:SAMPLECOMPFOUND\tSampleCompSearch", | 74 | "AppSearch:SAMPLEDIRFOUND\tSampleDirSearch", |
75 | "DrLocator:SampleDirSearch\t\tC:\\SampleDir\t", | 75 | "DrLocator:SampleDirSearch\t\tC:\\SampleDir\t", |
76 | }, results); | 76 | }, results); |
77 | } | 77 | } |
78 | } | 78 | } |
79 | 79 | ||
80 | [Fact(Skip = "Test demonstrates failure")] | 80 | [Fact] |
81 | public void PopulatesAppSearchTablesFromFileSearch() | 81 | public void PopulatesAppSearchTablesFromFileSearch() |
82 | { | 82 | { |
83 | var folder = TestData.Get(@"TestData"); | 83 | var folder = TestData.Get(@"TestData"); |
@@ -112,7 +112,7 @@ namespace WixToolsetTest.CoreIntegration | |||
112 | } | 112 | } |
113 | } | 113 | } |
114 | 114 | ||
115 | [Fact(Skip = "Test demonstrates failure")] | 115 | [Fact] |
116 | public void PopulatesAppSearchTablesFromRegistrySearch() | 116 | public void PopulatesAppSearchTablesFromRegistrySearch() |
117 | { | 117 | { |
118 | var folder = TestData.Get(@"TestData"); | 118 | var folder = TestData.Get(@"TestData"); |