aboutsummaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorSean Hall <r.sean.hall@gmail.com>2021-04-19 23:29:22 -0500
committerSean Hall <r.sean.hall@gmail.com>2021-04-19 23:29:22 -0500
commite87091209c6155c0d326c29bafe8a35356d8031a (patch)
treec39c3a7d5cacb6c66c97d3f2b7bf8aba8c87740a /src
parent89050b0cbf7bb7f1bc428376d76f3bea2022d274 (diff)
downloadwix-e87091209c6155c0d326c29bafe8a35356d8031a.tar.gz
wix-e87091209c6155c0d326c29bafe8a35356d8031a.tar.bz2
wix-e87091209c6155c0d326c29bafe8a35356d8031a.zip
Improve CacheId collision error messages.
Diffstat (limited to 'src')
-rw-r--r--src/WixToolset.Core.Burn/Bind/BindBundleCommand.cs4
-rw-r--r--src/WixToolset.Core.Burn/BurnBackendErrors.cs8
2 files changed, 6 insertions, 6 deletions
diff --git a/src/WixToolset.Core.Burn/Bind/BindBundleCommand.cs b/src/WixToolset.Core.Burn/Bind/BindBundleCommand.cs
index d8062008..4be72eec 100644
--- a/src/WixToolset.Core.Burn/Bind/BindBundleCommand.cs
+++ b/src/WixToolset.Core.Burn/Bind/BindBundleCommand.cs
@@ -594,8 +594,8 @@ namespace WixToolset.Core.Burn
594 { 594 {
595 if (duplicateCacheIdDetector.TryGetValue(facade.PackageSymbol.CacheId, out var collisionPackage)) 595 if (duplicateCacheIdDetector.TryGetValue(facade.PackageSymbol.CacheId, out var collisionPackage))
596 { 596 {
597 this.Messaging.Write(BurnBackendErrors.DuplicateCacheIds(collisionPackage.SourceLineNumbers, facade.PackageSymbol.CacheId)); 597 this.Messaging.Write(BurnBackendErrors.DuplicateCacheIds(facade.PackageSymbol.SourceLineNumbers, facade.PackageSymbol.CacheId, facade.PackageId));
598 this.Messaging.Write(BurnBackendErrors.DuplicateCacheIds2(facade.PackageSymbol.SourceLineNumbers, facade.PackageSymbol.CacheId)); 598 this.Messaging.Write(BurnBackendErrors.DuplicateCacheIds2(collisionPackage.SourceLineNumbers));
599 } 599 }
600 else 600 else
601 { 601 {
diff --git a/src/WixToolset.Core.Burn/BurnBackendErrors.cs b/src/WixToolset.Core.Burn/BurnBackendErrors.cs
index 4c846e8a..02ab1b5d 100644
--- a/src/WixToolset.Core.Burn/BurnBackendErrors.cs
+++ b/src/WixToolset.Core.Burn/BurnBackendErrors.cs
@@ -6,14 +6,14 @@ namespace WixToolset.Core.Burn
6 6
7 internal static class BurnBackendErrors 7 internal static class BurnBackendErrors
8 { 8 {
9 public static Message DuplicateCacheIds(SourceLineNumber originalLineNumber, string cacheId) 9 public static Message DuplicateCacheIds(SourceLineNumber originalLineNumber, string cacheId, string packageId)
10 { 10 {
11 return Message(originalLineNumber, Ids.DuplicateCacheIds, "The cache id '{0}' has been duplicated as indicated in the following message.", cacheId); 11 return Message(originalLineNumber, Ids.DuplicateCacheIds, "The CacheId '{0}' for package '{1}' is duplicated. Each package must have a unique CacheId.", cacheId, packageId);
12 } 12 }
13 13
14 public static Message DuplicateCacheIds2(SourceLineNumber duplicateLineNumber, string cacheId) 14 public static Message DuplicateCacheIds2(SourceLineNumber duplicateLineNumber)
15 { 15 {
16 return Message(duplicateLineNumber, Ids.DuplicateCacheIds2, "Each cache id must be unique. '{0}' has been used before as indicated in the previous message.", cacheId); 16 return Message(duplicateLineNumber, Ids.DuplicateCacheIds2, "The location of the package related to the previous error.");
17 } 17 }
18 18
19 private static Message Message(SourceLineNumber sourceLineNumber, Ids id, string format, params object[] args) 19 private static Message Message(SourceLineNumber sourceLineNumber, Ids id, string format, params object[] args)