diff options
| author | Rob Mensching <rob@firegiant.com> | 2022-12-13 14:31:15 -0800 |
|---|---|---|
| committer | Rob Mensching <rob@firegiant.com> | 2022-12-13 15:29:03 -0800 |
| commit | f41e1ec53f706551e6f747e42b2e926ee8624791 (patch) | |
| tree | 8fa6b3b70b2b43bbae2a3c0b12596265bb0aac67 /src | |
| parent | eacaa8794ba90b3df4ac344e96ec8da155d90d19 (diff) | |
| download | wix-f41e1ec53f706551e6f747e42b2e926ee8624791.tar.gz wix-f41e1ec53f706551e6f747e42b2e926ee8624791.tar.bz2 wix-f41e1ec53f706551e6f747e42b2e926ee8624791.zip | |
Ensure engine inscribe path is different from the original engine path
Fixes 7085
Diffstat (limited to 'src')
| -rw-r--r-- | src/wix/WixToolset.Sdk/tools/WixToolset.Signing.targets | 8 | ||||
| -rw-r--r-- | src/wix/test/WixToolsetTest.Sdk/MsbuildFixture.cs | 4 |
2 files changed, 6 insertions, 6 deletions
diff --git a/src/wix/WixToolset.Sdk/tools/WixToolset.Signing.targets b/src/wix/WixToolset.Sdk/tools/WixToolset.Signing.targets index c414bcf1..0fc05851 100644 --- a/src/wix/WixToolset.Sdk/tools/WixToolset.Signing.targets +++ b/src/wix/WixToolset.Sdk/tools/WixToolset.Signing.targets | |||
| @@ -246,7 +246,7 @@ | |||
| 246 | 246 | ||
| 247 | <DetachBundleEngineForSigning | 247 | <DetachBundleEngineForSigning |
| 248 | BundleFile="@(SignTargetPath)" | 248 | BundleFile="@(SignTargetPath)" |
| 249 | OutputFile="$(IntermediateOutputPath)%(SignTargetPath.Filename)%(SignTargetPath.Extension)" | 249 | OutputFile="$(IntermediateOutputPath)%(SignTargetPath.Filename)-engine%(SignTargetPath.Extension)" |
| 250 | IntermediateDirectory="%(SignTargetPath.RootDir)%(SignTargetPath.Directory)" | 250 | IntermediateDirectory="%(SignTargetPath.RootDir)%(SignTargetPath.Directory)" |
| 251 | 251 | ||
| 252 | NoLogo="$(InscribeNoLogo)" | 252 | NoLogo="$(InscribeNoLogo)" |
| @@ -264,7 +264,7 @@ | |||
| 264 | 264 | ||
| 265 | <!-- Explicitly add output to FileWrites to ensure it is included even when the target is up to date. --> | 265 | <!-- Explicitly add output to FileWrites to ensure it is included even when the target is up to date. --> |
| 266 | <ItemGroup> | 266 | <ItemGroup> |
| 267 | <FileWrites Include="$(IntermediateOutputPath)%(SignTargetPath.Filename)%(SignTargetPath.Extension)" /> | 267 | <FileWrites Include="$(IntermediateOutputPath)%(SignTargetPath.Filename)-engine%(SignTargetPath.Extension)" /> |
| 268 | </ItemGroup> | 268 | </ItemGroup> |
| 269 | </Target> | 269 | </Target> |
| 270 | 270 | ||
| @@ -275,7 +275,7 @@ | |||
| 275 | To be called after signing the bundle engine to reattach the attached container. | 275 | To be called after signing the bundle engine to reattach the attached container. |
| 276 | 276 | ||
| 277 | [IN] | 277 | [IN] |
| 278 | @(Inscribe) - The bundle to inscribe. | 278 | @(SignBundleEngine) - The bundle to inscribe. |
| 279 | 279 | ||
| 280 | [OUT] | 280 | [OUT] |
| 281 | @(SignBundle) - The bundle engine file to be signed. | 281 | @(SignBundle) - The bundle engine file to be signed. |
| @@ -288,7 +288,7 @@ | |||
| 288 | <Target | 288 | <Target |
| 289 | Name="InscribeBundle" | 289 | Name="InscribeBundle" |
| 290 | DependsOnTargets="$(InscribeBundleDependsOn)" | 290 | DependsOnTargets="$(InscribeBundleDependsOn)" |
| 291 | Inputs="@(SignTargetPath)" | 291 | Inputs="@(SignTargetPath);@(SignBundleEngine)" |
| 292 | Outputs="$(SignedFilePath)"> | 292 | Outputs="$(SignedFilePath)"> |
| 293 | 293 | ||
| 294 | <ReattachSignedBundleEngine | 294 | <ReattachSignedBundleEngine |
diff --git a/src/wix/test/WixToolsetTest.Sdk/MsbuildFixture.cs b/src/wix/test/WixToolsetTest.Sdk/MsbuildFixture.cs index a259298c..2c106015 100644 --- a/src/wix/test/WixToolsetTest.Sdk/MsbuildFixture.cs +++ b/src/wix/test/WixToolsetTest.Sdk/MsbuildFixture.cs | |||
| @@ -41,7 +41,7 @@ namespace WixToolsetTest.Sdk | |||
| 41 | var testMessages = result.Output.Where(line => line.Contains("TEST:")).Select(line => line.Trim()).ToArray(); | 41 | var testMessages = result.Output.Where(line => line.Contains("TEST:")).Select(line => line.Trim()).ToArray(); |
| 42 | WixAssert.CompareLineByLine(new[] | 42 | WixAssert.CompareLineByLine(new[] |
| 43 | { | 43 | { |
| 44 | @"TEST: SignBundleEngine: obj\x86\Release\SimpleBundle.exe", | 44 | @"TEST: SignBundleEngine: obj\x86\Release\SimpleBundle-engine.exe", |
| 45 | @"TEST: SignBundle: obj\x86\Release\SimpleBundle.exe", | 45 | @"TEST: SignBundle: obj\x86\Release\SimpleBundle.exe", |
| 46 | }, testMessages); | 46 | }, testMessages); |
| 47 | 47 | ||
| @@ -84,7 +84,7 @@ namespace WixToolsetTest.Sdk | |||
| 84 | var testMessages = result.Output.Where(line => line.Contains("TEST:")).Select(line => line.Trim()).ToArray(); | 84 | var testMessages = result.Output.Where(line => line.Contains("TEST:")).Select(line => line.Trim()).ToArray(); |
| 85 | WixAssert.CompareLineByLine(new[] | 85 | WixAssert.CompareLineByLine(new[] |
| 86 | { | 86 | { |
| 87 | @"TEST: SignBundleEngine: obj\x86\Release\UncompressedBundle.exe", | 87 | @"TEST: SignBundleEngine: obj\x86\Release\UncompressedBundle-engine.exe", |
| 88 | }, testMessages); | 88 | }, testMessages); |
| 89 | 89 | ||
| 90 | var paths = Directory.EnumerateFiles(binFolder, @"*.*", SearchOption.AllDirectories) | 90 | var paths = Directory.EnumerateFiles(binFolder, @"*.*", SearchOption.AllDirectories) |
