diff options
| author | Rob Mensching <rob@firegiant.com> | 2022-02-06 09:38:13 -0800 |
|---|---|---|
| committer | Rob Mensching <rob@firegiant.com> | 2022-02-08 09:42:04 -0800 |
| commit | fe689d65adcb20c5f1cfc0eedfe75559c686adbb (patch) | |
| tree | fa874d24d3f8bc2f0a998b5a2c0b26bf963c19e0 /src | |
| parent | 69e750b3e6cc6e91e2a24075e19d644143c852f9 (diff) | |
| download | wix-fe689d65adcb20c5f1cfc0eedfe75559c686adbb.tar.gz wix-fe689d65adcb20c5f1cfc0eedfe75559c686adbb.tar.bz2 wix-fe689d65adcb20c5f1cfc0eedfe75559c686adbb.zip | |
Quick automated code clean up
Diffstat (limited to 'src')
3 files changed, 23 insertions, 17 deletions
diff --git a/src/wix/WixToolset.Core.WindowsInstaller/Bind/CreateWindowsInstallerDataFromIRCommand.cs b/src/wix/WixToolset.Core.WindowsInstaller/Bind/CreateWindowsInstallerDataFromIRCommand.cs index d34ca3fe..98950a05 100644 --- a/src/wix/WixToolset.Core.WindowsInstaller/Bind/CreateWindowsInstallerDataFromIRCommand.cs +++ b/src/wix/WixToolset.Core.WindowsInstaller/Bind/CreateWindowsInstallerDataFromIRCommand.cs | |||
| @@ -1552,12 +1552,15 @@ namespace WixToolset.Core.WindowsInstaller.Bind | |||
| 1552 | } | 1552 | } |
| 1553 | } | 1553 | } |
| 1554 | 1554 | ||
| 1555 | private Row CreateRow(IntermediateSymbol symbol, string tableDefinitionName) => | 1555 | private Row CreateRow(IntermediateSymbol symbol, string tableDefinitionName) |
| 1556 | this.CreateRow(symbol, this.TableDefinitions[tableDefinitionName]); | 1556 | { |
| 1557 | 1557 | return this.CreateRow(symbol, this.TableDefinitions[tableDefinitionName]); | |
| 1558 | private Row CreateRow(IntermediateSymbol symbol, TableDefinition tableDefinition) => | 1558 | } |
| 1559 | this.BackendHelper.CreateRow(this.Section, symbol, this.Data, tableDefinition); | ||
| 1560 | 1559 | ||
| 1560 | private Row CreateRow(IntermediateSymbol symbol, TableDefinition tableDefinition) | ||
| 1561 | { | ||
| 1562 | return this.BackendHelper.CreateRow(this.Section, symbol, this.Data, tableDefinition); | ||
| 1563 | } | ||
| 1561 | 1564 | ||
| 1562 | private string CreateShortName(string longName, bool keepExtension, params string[] args) | 1565 | private string CreateShortName(string longName, bool keepExtension, params string[] args) |
| 1563 | { | 1566 | { |
diff --git a/src/wix/WixToolset.Core.WindowsInstaller/MspBackend.cs b/src/wix/WixToolset.Core.WindowsInstaller/MspBackend.cs index 76328bb1..1ef9671b 100644 --- a/src/wix/WixToolset.Core.WindowsInstaller/MspBackend.cs +++ b/src/wix/WixToolset.Core.WindowsInstaller/MspBackend.cs | |||
| @@ -69,7 +69,10 @@ namespace WixToolset.Core.WindowsInstaller | |||
| 69 | } | 69 | } |
| 70 | } | 70 | } |
| 71 | 71 | ||
| 72 | public IDecompileResult Decompile(IDecompileContext context) => throw new NotImplementedException(); | 72 | public IDecompileResult Decompile(IDecompileContext context) |
| 73 | { | ||
| 74 | throw new NotImplementedException(); | ||
| 75 | } | ||
| 73 | 76 | ||
| 74 | public Intermediate Unbind(IUnbindContext context) | 77 | public Intermediate Unbind(IUnbindContext context) |
| 75 | { | 78 | { |
diff --git a/src/wix/heat/RegFileHarvester.cs b/src/wix/heat/RegFileHarvester.cs index 1377d413..b7ad8c7b 100644 --- a/src/wix/heat/RegFileHarvester.cs +++ b/src/wix/heat/RegFileHarvester.cs | |||
| @@ -141,19 +141,19 @@ namespace WixToolset.Harvesters | |||
| 141 | { | 141 | { |
| 142 | string name = null; | 142 | string name = null; |
| 143 | string value = null; | 143 | string value = null; |
| 144 | Wix.RegistryValue.TypeType type; | 144 | var registryKey = new Wix.RegistryKey |
| 145 | Wix.RegistryKey registryKey = new Wix.RegistryKey(); | 145 | { |
| 146 | 146 | Root = root, | |
| 147 | registryKey.Root = root; | 147 | Key = line |
| 148 | registryKey.Key = line; | 148 | }; |
| 149 | 149 | ||
| 150 | while (this.GetValue(sr, ref name, ref value, out type)) | 150 | while (this.GetValue(sr, ref name, ref value, out var type)) |
| 151 | { | 151 | { |
| 152 | Wix.RegistryValue registryValue = new Wix.RegistryValue(); | 152 | Wix.RegistryValue registryValue = new Wix.RegistryValue(); |
| 153 | ArrayList charArray; | 153 | ArrayList charArray; |
| 154 | 154 | ||
| 155 | // Don't specifiy name for default attribute | 155 | // Don't specifiy name for default attribute |
| 156 | if (!string.IsNullOrEmpty(name)) | 156 | if (!String.IsNullOrEmpty(name)) |
| 157 | { | 157 | { |
| 158 | registryValue.Name = name; | 158 | registryValue.Name = name; |
| 159 | } | 159 | } |
| @@ -163,7 +163,7 @@ namespace WixToolset.Harvesters | |||
| 163 | switch (type) | 163 | switch (type) |
| 164 | { | 164 | { |
| 165 | case Wix.RegistryValue.TypeType.binary: | 165 | case Wix.RegistryValue.TypeType.binary: |
| 166 | registryValue.Value = value.Replace(",", string.Empty).ToUpper(); | 166 | registryValue.Value = value.Replace(",", String.Empty).ToUpper(); |
| 167 | break; | 167 | break; |
| 168 | 168 | ||
| 169 | case Wix.RegistryValue.TypeType.integer: | 169 | case Wix.RegistryValue.TypeType.integer: |
| @@ -172,7 +172,7 @@ namespace WixToolset.Harvesters | |||
| 172 | 172 | ||
| 173 | case Wix.RegistryValue.TypeType.expandable: | 173 | case Wix.RegistryValue.TypeType.expandable: |
| 174 | charArray = this.ConvertCharList(value); | 174 | charArray = this.ConvertCharList(value); |
| 175 | value = string.Empty; | 175 | value = String.Empty; |
| 176 | 176 | ||
| 177 | // create the string, remove the terminating null | 177 | // create the string, remove the terminating null |
| 178 | for (int i = 0; i < charArray.Count; i++) | 178 | for (int i = 0; i < charArray.Count; i++) |
| @@ -188,7 +188,7 @@ namespace WixToolset.Harvesters | |||
| 188 | 188 | ||
| 189 | case Wix.RegistryValue.TypeType.multiString: | 189 | case Wix.RegistryValue.TypeType.multiString: |
| 190 | charArray = this.ConvertCharList(value); | 190 | charArray = this.ConvertCharList(value); |
| 191 | value = string.Empty; | 191 | value = String.Empty; |
| 192 | 192 | ||
| 193 | // Convert the character array to a string so we can simply split it at the nulls, ignore the final null null. | 193 | // Convert the character array to a string so we can simply split it at the nulls, ignore the final null null. |
| 194 | for (int i = 0; i < (charArray.Count - 2); i++) | 194 | for (int i = 0; i < (charArray.Count - 2); i++) |
| @@ -399,7 +399,7 @@ namespace WixToolset.Harvesters | |||
| 399 | /// <returns>Array of characters.</returns> | 399 | /// <returns>Array of characters.</returns> |
| 400 | private ArrayList ConvertCharList(string charList) | 400 | private ArrayList ConvertCharList(string charList) |
| 401 | { | 401 | { |
| 402 | if (string.IsNullOrEmpty(charList)) | 402 | if (String.IsNullOrEmpty(charList)) |
| 403 | { | 403 | { |
| 404 | return new ArrayList(); | 404 | return new ArrayList(); |
| 405 | } | 405 | } |
