diff options
-rw-r--r-- | appveyor.yml | 2 | ||||
-rw-r--r-- | src/Cpp.Build.props | 2 | ||||
-rw-r--r-- | src/FindLocalWix.props | 2 | ||||
-rw-r--r-- | src/ca/dependencyca.vcxproj | 8 | ||||
-rw-r--r-- | src/ca/packages.config | 4 | ||||
-rw-r--r-- | src/test/WixToolsetTest.Dependency/WixToolsetTest.Dependency.csproj | 15 | ||||
-rw-r--r-- | src/wixext/DependencyCompiler.cs | 13 | ||||
-rw-r--r-- | src/wixext/DependencyWindowsInstallerBackendBinderExtension.cs | 3 | ||||
-rw-r--r-- | src/wixlib/dependency.wixproj | 4 | ||||
-rw-r--r-- | src/wixlib/packages.config | 2 |
10 files changed, 31 insertions, 24 deletions
diff --git a/appveyor.yml b/appveyor.yml index 8d80c6af..522e5af3 100644 --- a/appveyor.yml +++ b/appveyor.yml | |||
@@ -8,7 +8,7 @@ branches: | |||
8 | - master | 8 | - master |
9 | - develop | 9 | - develop |
10 | 10 | ||
11 | image: Visual Studio 2017 | 11 | image: Visual Studio 2019 |
12 | 12 | ||
13 | version: 0.0.0.{build} | 13 | version: 0.0.0.{build} |
14 | configuration: Release | 14 | configuration: Release |
diff --git a/src/Cpp.Build.props b/src/Cpp.Build.props index 0e00132b..44a042c7 100644 --- a/src/Cpp.Build.props +++ b/src/Cpp.Build.props | |||
@@ -8,7 +8,7 @@ | |||
8 | <OutDir>$(OutputPath)$(Platform)\</OutDir> | 8 | <OutDir>$(OutputPath)$(Platform)\</OutDir> |
9 | </PropertyGroup> | 9 | </PropertyGroup> |
10 | 10 | ||
11 | <PropertyGroup Condition="'$(WindowsTargetPlatformVersion)'=='' AND '$(VisualStudioVersion)'=='15.0'"> | 11 | <PropertyGroup Condition="'$(WindowsTargetPlatformVersion)'=='' AND '$(VisualStudioVersion)'>='15.0'"> |
12 | <WindowsTargetPlatformVersion>$([Microsoft.Build.Utilities.ToolLocationHelper]::GetLatestSDKTargetPlatformVersion('Windows', '10.0'))</WindowsTargetPlatformVersion> | 12 | <WindowsTargetPlatformVersion>$([Microsoft.Build.Utilities.ToolLocationHelper]::GetLatestSDKTargetPlatformVersion('Windows', '10.0'))</WindowsTargetPlatformVersion> |
13 | </PropertyGroup> | 13 | </PropertyGroup> |
14 | 14 | ||
diff --git a/src/FindLocalWix.props b/src/FindLocalWix.props index a784e352..1666e4fe 100644 --- a/src/FindLocalWix.props +++ b/src/FindLocalWix.props | |||
@@ -3,6 +3,6 @@ | |||
3 | 3 | ||
4 | <Project xmlns="http://schemas.microsoft.com/developer/msbuild/2003"> | 4 | <Project xmlns="http://schemas.microsoft.com/developer/msbuild/2003"> |
5 | <PropertyGroup> | 5 | <PropertyGroup> |
6 | <WixTargetsPath Condition=" '$(Configuration)' == 'Debug' And Exists('$(MSBuildThisFileDirectory)..\..\Tools\README.md') ">$(MSBuildThisFileDirectory)..\..\Tools\build\Debug\net461\wix.targets</WixTargetsPath> | 6 | <WixTargetsPath Condition=" '$(Configuration)' == 'Debug' And Exists('$(MSBuildThisFileDirectory)..\..\Tools\README.md') And Exists('$(MSBuildThisFileDirectory)..\..\Tools\build\Debug\net461\wix.targets') ">$(MSBuildThisFileDirectory)..\..\Tools\build\Debug\net461\wix.targets</WixTargetsPath> |
7 | </PropertyGroup> | 7 | </PropertyGroup> |
8 | </Project> | 8 | </Project> |
diff --git a/src/ca/dependencyca.vcxproj b/src/ca/dependencyca.vcxproj index 480a1861..c8072f71 100644 --- a/src/ca/dependencyca.vcxproj +++ b/src/ca/dependencyca.vcxproj | |||
@@ -2,8 +2,8 @@ | |||
2 | <!-- Copyright (c) .NET Foundation and contributors. All rights reserved. Licensed under the Microsoft Reciprocal License. See LICENSE.TXT file in the project root for full license information. --> | 2 | <!-- Copyright (c) .NET Foundation and contributors. All rights reserved. Licensed under the Microsoft Reciprocal License. See LICENSE.TXT file in the project root for full license information. --> |
3 | 3 | ||
4 | <Project DefaultTargets="Build" ToolsVersion="15.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003"> | 4 | <Project DefaultTargets="Build" ToolsVersion="15.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003"> |
5 | <Import Project="..\..\packages\WixToolset.DUtil.4.0.16\build\WixToolset.DUtil.props" Condition="Exists('..\..\packages\WixToolset.DUtil.4.0.16\build\WixToolset.DUtil.props')" /> | 5 | <Import Project="..\..\packages\WixToolset.DUtil.4.0.18\build\WixToolset.DUtil.props" Condition="Exists('..\..\packages\WixToolset.DUtil.4.0.18\build\WixToolset.DUtil.props')" /> |
6 | <Import Project="..\..\packages\WixToolset.WcaUtil.4.0.2\build\WixToolset.WcaUtil.props" Condition="Exists('..\..\packages\WixToolset.WcaUtil.4.0.2\build\WixToolset.WcaUtil.props')" /> | 6 | <Import Project="..\..\packages\WixToolset.WcaUtil.4.0.8\build\WixToolset.WcaUtil.props" Condition="Exists('..\..\packages\WixToolset.WcaUtil.4.0.8\build\WixToolset.WcaUtil.props')" /> |
7 | 7 | ||
8 | <ItemGroup Label="ProjectConfigurations"> | 8 | <ItemGroup Label="ProjectConfigurations"> |
9 | <ProjectConfiguration Include="Debug|Win32"> | 9 | <ProjectConfiguration Include="Debug|Win32"> |
@@ -55,7 +55,7 @@ | |||
55 | <PropertyGroup> | 55 | <PropertyGroup> |
56 | <ErrorText>This project references NuGet package(s) that are missing on this computer. Use NuGet Package Restore to download them. For more information, see http://go.microsoft.com/fwlink/?LinkID=322105. The missing file is {0}.</ErrorText> | 56 | <ErrorText>This project references NuGet package(s) that are missing on this computer. Use NuGet Package Restore to download them. For more information, see http://go.microsoft.com/fwlink/?LinkID=322105. The missing file is {0}.</ErrorText> |
57 | </PropertyGroup> | 57 | </PropertyGroup> |
58 | <Error Condition="!Exists('..\..\packages\WixToolset.DUtil.4.0.16\build\WixToolset.DUtil.props')" Text="$([System.String]::Format('$(ErrorText)', '..\..\packages\WixToolset.DUtil.4.0.16\build\WixToolset.DUtil.props'))" /> | 58 | <Error Condition="!Exists('..\..\packages\WixToolset.DUtil.4.0.18\build\WixToolset.DUtil.props')" Text="$([System.String]::Format('$(ErrorText)', '..\..\packages\WixToolset.DUtil.4.0.18\build\WixToolset.DUtil.props'))" /> |
59 | <Error Condition="!Exists('..\..\packages\WixToolset.WcaUtil.4.0.2\build\WixToolset.WcaUtil.props')" Text="$([System.String]::Format('$(ErrorText)', '..\..\packages\WixToolset.WcaUtil.4.0.2\build\WixToolset.WcaUtil.props'))" /> | 59 | <Error Condition="!Exists('..\..\packages\WixToolset.WcaUtil.4.0.8\build\WixToolset.WcaUtil.props')" Text="$([System.String]::Format('$(ErrorText)', '..\..\packages\WixToolset.WcaUtil.4.0.8\build\WixToolset.WcaUtil.props'))" /> |
60 | </Target> | 60 | </Target> |
61 | </Project> | 61 | </Project> |
diff --git a/src/ca/packages.config b/src/ca/packages.config index ab964d2c..4e9403bf 100644 --- a/src/ca/packages.config +++ b/src/ca/packages.config | |||
@@ -1,5 +1,5 @@ | |||
1 | <?xml version="1.0" encoding="utf-8"?> | 1 | <?xml version="1.0" encoding="utf-8"?> |
2 | <packages> | 2 | <packages> |
3 | <package id="WixToolset.DUtil" version="4.0.16" targetFramework="native" /> | 3 | <package id="WixToolset.DUtil" version="4.0.18" targetFramework="native" /> |
4 | <package id="WixToolset.WcaUtil" version="4.0.2" targetFramework="native" /> | 4 | <package id="WixToolset.WcaUtil" version="4.0.8" targetFramework="native" /> |
5 | </packages> \ No newline at end of file | 5 | </packages> \ No newline at end of file |
diff --git a/src/test/WixToolsetTest.Dependency/WixToolsetTest.Dependency.csproj b/src/test/WixToolsetTest.Dependency/WixToolsetTest.Dependency.csproj index 342325df..7bedc47d 100644 --- a/src/test/WixToolsetTest.Dependency/WixToolsetTest.Dependency.csproj +++ b/src/test/WixToolsetTest.Dependency/WixToolsetTest.Dependency.csproj | |||
@@ -1,9 +1,9 @@ | |||
1 | <?xml version="1.0" encoding="utf-8"?> | 1 | <?xml version="1.0" encoding="utf-8"?> |
2 | <!-- Copyright (c) .NET Foundation and contributors. All rights reserved. Licensed under the Microsoft Reciprocal License. See LICENSE.TXT file in the project root for full license information. --> | 2 | <!-- Copyright (c) .NET Foundation and contributors. All rights reserved. Licensed under the Microsoft Reciprocal License. See LICENSE.TXT file in the project root for full license information. --> |
3 | 3 | ||
4 | <Project Sdk="Microsoft.NET.Sdk"> | 4 | <Project Sdk="Microsoft.NET.Sdk"> |
5 | <PropertyGroup> | 5 | <PropertyGroup> |
6 | <TargetFramework>netcoreapp2.1</TargetFramework> | 6 | <TargetFramework>netcoreapp3.1</TargetFramework> |
7 | <IsPackable>false</IsPackable> | 7 | <IsPackable>false</IsPackable> |
8 | </PropertyGroup> | 8 | </PropertyGroup> |
9 | 9 | ||
@@ -23,7 +23,10 @@ | |||
23 | </ItemGroup> | 23 | </ItemGroup> |
24 | 24 | ||
25 | <ItemGroup> | 25 | <ItemGroup> |
26 | <PackageReference Include="WixToolset.Core.TestPackage" Version="4.0.*" PrivateAssets="all" /> | 26 | <PackageReference Include="WixToolset.Core" Version="4.0.*" /> |
27 | <PackageReference Include="WixToolset.Core.Burn" Version="4.0.*" /> | ||
28 | <PackageReference Include="WixToolset.Core.WindowsInstaller" Version="4.0.*" /> | ||
29 | <PackageReference Include="WixToolset.Core.TestPackage" Version="4.0.*" /> | ||
27 | </ItemGroup> | 30 | </ItemGroup> |
28 | 31 | ||
29 | <ItemGroup> | 32 | <ItemGroup> |
@@ -31,8 +34,8 @@ | |||
31 | </ItemGroup> | 34 | </ItemGroup> |
32 | 35 | ||
33 | <ItemGroup> | 36 | <ItemGroup> |
34 | <PackageReference Include="Microsoft.NET.Test.Sdk" Version="15.8.0" /> | 37 | <PackageReference Include="Microsoft.NET.Test.Sdk" Version="16.3.0" /> |
35 | <PackageReference Include="xunit" Version="2.4.0" /> | 38 | <PackageReference Include="xunit" Version="2.4.1" /> |
36 | <PackageReference Include="xunit.runner.visualstudio" Version="2.4.0" /> | 39 | <PackageReference Include="xunit.runner.visualstudio" Version="2.4.1" PrivateAssets="All" /> |
37 | </ItemGroup> | 40 | </ItemGroup> |
38 | </Project> | 41 | </Project> |
diff --git a/src/wixext/DependencyCompiler.cs b/src/wixext/DependencyCompiler.cs index f866b589..dafcfb3e 100644 --- a/src/wixext/DependencyCompiler.cs +++ b/src/wixext/DependencyCompiler.cs | |||
@@ -125,10 +125,10 @@ namespace WixToolset.Dependency | |||
125 | /// <param name="element">Element to process.</param> | 125 | /// <param name="element">Element to process.</param> |
126 | /// <param name="context">Extra information about the context in which this element is being parsed.</param> | 126 | /// <param name="context">Extra information about the context in which this element is being parsed.</param> |
127 | /// <returns>The component key path type if set.</returns> | 127 | /// <returns>The component key path type if set.</returns> |
128 | public override ComponentKeyPath ParsePossibleKeyPathElement(Intermediate intermediate, IntermediateSection section, XElement parentElement, XElement element, IDictionary<string, string> context) | 128 | public override IComponentKeyPath ParsePossibleKeyPathElement(Intermediate intermediate, IntermediateSection section, XElement parentElement, XElement element, IDictionary<string, string> context) |
129 | { | 129 | { |
130 | SourceLineNumber sourceLineNumbers = this.ParseHelper.GetSourceLineNumbers(parentElement); | 130 | SourceLineNumber sourceLineNumbers = this.ParseHelper.GetSourceLineNumbers(parentElement); |
131 | ComponentKeyPath keyPath = null; | 131 | IComponentKeyPath keyPath = null; |
132 | 132 | ||
133 | switch (parentElement.Name.LocalName) | 133 | switch (parentElement.Name.LocalName) |
134 | { | 134 | { |
@@ -223,10 +223,10 @@ namespace WixToolset.Dependency | |||
223 | /// <param name="keyPath">Explicit key path.</param> | 223 | /// <param name="keyPath">Explicit key path.</param> |
224 | /// <param name="parentId">The identifier of the parent component or package.</param> | 224 | /// <param name="parentId">The identifier of the parent component or package.</param> |
225 | /// <returns>The type of key path if set.</returns> | 225 | /// <returns>The type of key path if set.</returns> |
226 | private ComponentKeyPath ParseProvidesElement(Intermediate intermediate, IntermediateSection section, XElement node, PackageType packageType, string parentId) | 226 | private IComponentKeyPath ParseProvidesElement(Intermediate intermediate, IntermediateSection section, XElement node, PackageType packageType, string parentId) |
227 | { | 227 | { |
228 | SourceLineNumber sourceLineNumbers = this.ParseHelper.GetSourceLineNumbers(node); | 228 | SourceLineNumber sourceLineNumbers = this.ParseHelper.GetSourceLineNumbers(node); |
229 | ComponentKeyPath keyPath = null; | 229 | IComponentKeyPath keyPath = null; |
230 | Identifier id = null; | 230 | Identifier id = null; |
231 | string key = null; | 231 | string key = null; |
232 | string version = null; | 232 | string version = null; |
@@ -387,7 +387,10 @@ namespace WixToolset.Dependency | |||
387 | 387 | ||
388 | // Use the Version registry value and use that as a potential key path. | 388 | // Use the Version registry value and use that as a potential key path. |
389 | Identifier idVersion = this.ParseHelper.CreateIdentifier("reg", id.Id, "Version"); | 389 | Identifier idVersion = this.ParseHelper.CreateIdentifier("reg", id.Id, "Version"); |
390 | keyPath = new ComponentKeyPath() { Id = idVersion.Id, Explicit = false, Type = ComponentKeyPathType.Registry }; | 390 | keyPath = this.CreateComponentKeyPath(); |
391 | keyPath.Id = idVersion.Id; | ||
392 | keyPath.Explicit = false; | ||
393 | keyPath.Type = PossibleKeyPathType.Registry; | ||
391 | 394 | ||
392 | row = this.ParseHelper.CreateRow(section, sourceLineNumbers, "Registry", idVersion); | 395 | row = this.ParseHelper.CreateRow(section, sourceLineNumbers, "Registry", idVersion); |
393 | row.Set(1, -1); | 396 | row.Set(1, -1); |
diff --git a/src/wixext/DependencyWindowsInstallerBackendBinderExtension.cs b/src/wixext/DependencyWindowsInstallerBackendBinderExtension.cs index 485453a1..265fdd4f 100644 --- a/src/wixext/DependencyWindowsInstallerBackendBinderExtension.cs +++ b/src/wixext/DependencyWindowsInstallerBackendBinderExtension.cs | |||
@@ -2,6 +2,7 @@ | |||
2 | 2 | ||
3 | namespace WixToolset.Dependency | 3 | namespace WixToolset.Dependency |
4 | { | 4 | { |
5 | using System.Collections.Generic; | ||
5 | using System.Linq; | 6 | using System.Linq; |
6 | using System.Xml; | 7 | using System.Xml; |
7 | using WixToolset.Data.WindowsInstaller; | 8 | using WixToolset.Data.WindowsInstaller; |
@@ -11,7 +12,7 @@ namespace WixToolset.Dependency | |||
11 | { | 12 | { |
12 | private static readonly TableDefinition[] Tables = LoadTables(); | 13 | private static readonly TableDefinition[] Tables = LoadTables(); |
13 | 14 | ||
14 | protected override TableDefinition[] TableDefinitionsForTuples => Tables; | 15 | public override IEnumerable<TableDefinition> TableDefinitions => Tables; |
15 | 16 | ||
16 | private static TableDefinition[] LoadTables() | 17 | private static TableDefinition[] LoadTables() |
17 | { | 18 | { |
diff --git a/src/wixlib/dependency.wixproj b/src/wixlib/dependency.wixproj index 6fa70e3d..72be9c16 100644 --- a/src/wixlib/dependency.wixproj +++ b/src/wixlib/dependency.wixproj | |||
@@ -1,7 +1,7 @@ | |||
1 | <?xml version="1.0" encoding="utf-8" ?> | 1 | <?xml version="1.0" encoding="utf-8" ?> |
2 | <!-- Copyright (c) .NET Foundation and contributors. All rights reserved. Licensed under the Microsoft Reciprocal License. See LICENSE.TXT file in the project root for full license information. --> | 2 | <!-- Copyright (c) .NET Foundation and contributors. All rights reserved. Licensed under the Microsoft Reciprocal License. See LICENSE.TXT file in the project root for full license information. --> |
3 | <Project DefaultTargets="Build" InitialTargets="EnsureWixToolsetInstalled" xmlns="http://schemas.microsoft.com/developer/msbuild/2003" ToolsVersion="15.0"> | 3 | <Project DefaultTargets="Build" InitialTargets="EnsureWixToolsetInstalled" xmlns="http://schemas.microsoft.com/developer/msbuild/2003" ToolsVersion="15.0"> |
4 | <Import Project="..\..\packages\WixToolset.MSBuild.4.0.0-build-0005\build\WixToolset.MSBuild.props" Condition="Exists('..\..\packages\WixToolset.MSBuild.4.0.0-build-0005\build\WixToolset.MSBuild.props')" /> | 4 | <Import Project="..\..\packages\WixToolset.MSBuild.4.0.0-build-0084\build\WixToolset.MSBuild.props" Condition="Exists('..\..\packages\WixToolset.MSBuild.4.0.0-build-0084\build\WixToolset.MSBuild.props')" /> |
5 | <Import Project="..\FindLocalWix.props" /> | 5 | <Import Project="..\FindLocalWix.props" /> |
6 | <PropertyGroup> | 6 | <PropertyGroup> |
7 | <ProjectGuid>{58ED0EC8-73F8-4EE1-8664-A53486D38EC8}</ProjectGuid> | 7 | <ProjectGuid>{58ED0EC8-73F8-4EE1-8664-A53486D38EC8}</ProjectGuid> |
@@ -37,7 +37,7 @@ | |||
37 | <ErrorText>This project references NuGet package(s) that are missing on this computer. Use NuGet Package Restore to download them. For more information, see http://go.microsoft.com/fwlink/?LinkID=322105. The missing file is {0}.</ErrorText> | 37 | <ErrorText>This project references NuGet package(s) that are missing on this computer. Use NuGet Package Restore to download them. For more information, see http://go.microsoft.com/fwlink/?LinkID=322105. The missing file is {0}.</ErrorText> |
38 | </PropertyGroup> | 38 | </PropertyGroup> |
39 | <Error Condition="!Exists('..\..\packages\Nerdbank.GitVersioning.2.1.65\build\Nerdbank.GitVersioning.targets')" Text="$([System.String]::Format('$(ErrorText)', '..\..\packages\Nerdbank.GitVersioning.2.1.65\build\Nerdbank.GitVersioning.targets'))" /> | 39 | <Error Condition="!Exists('..\..\packages\Nerdbank.GitVersioning.2.1.65\build\Nerdbank.GitVersioning.targets')" Text="$([System.String]::Format('$(ErrorText)', '..\..\packages\Nerdbank.GitVersioning.2.1.65\build\Nerdbank.GitVersioning.targets'))" /> |
40 | <Error Condition="!Exists('..\..\packages\WixToolset.MSBuild.4.0.0-build-0005\build\WixToolset.MSBuild.props')" Text="$([System.String]::Format('$(ErrorText)', '..\..\packages\WixToolset.MSBuild.4.0.0-build-0005\build\WixToolset.MSBuild.props'))" /> | 40 | <Error Condition="!Exists('..\..\packages\WixToolset.MSBuild.4.0.0-build-0084\build\WixToolset.MSBuild.props')" Text="$([System.String]::Format('$(ErrorText)', '..\..\packages\WixToolset.MSBuild.4.0.0-build-0084\build\WixToolset.MSBuild.props'))" /> |
41 | </Target> | 41 | </Target> |
42 | <Import Project="..\..\packages\Nerdbank.GitVersioning.2.1.65\build\Nerdbank.GitVersioning.targets" Condition="Exists('..\..\packages\Nerdbank.GitVersioning.2.1.65\build\Nerdbank.GitVersioning.targets')" /> | 42 | <Import Project="..\..\packages\Nerdbank.GitVersioning.2.1.65\build\Nerdbank.GitVersioning.targets" Condition="Exists('..\..\packages\Nerdbank.GitVersioning.2.1.65\build\Nerdbank.GitVersioning.targets')" /> |
43 | </Project> | 43 | </Project> |
diff --git a/src/wixlib/packages.config b/src/wixlib/packages.config index f3d424e1..e1b601f6 100644 --- a/src/wixlib/packages.config +++ b/src/wixlib/packages.config | |||
@@ -1,5 +1,5 @@ | |||
1 | <?xml version="1.0" encoding="utf-8"?> | 1 | <?xml version="1.0" encoding="utf-8"?> |
2 | <packages> | 2 | <packages> |
3 | <package id="Nerdbank.GitVersioning" version="2.1.65" developmentDependency="true" targetFramework="net40" /> | 3 | <package id="Nerdbank.GitVersioning" version="2.1.65" developmentDependency="true" targetFramework="net40" /> |
4 | <package id="WixToolset.MSBuild" version="4.0.0-build-0005" developmentDependency="true" targetFramework="net40" /> | 4 | <package id="WixToolset.MSBuild" version="4.0.0-build-0084" developmentDependency="true" targetFramework="net40" /> |
5 | </packages> \ No newline at end of file | 5 | </packages> \ No newline at end of file |