aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
-rw-r--r--src/wix/WixToolset.Converters/WixConverter.cs3
-rw-r--r--src/wix/test/WixToolsetTest.Converters/UIExtensionFixture.cs6
2 files changed, 5 insertions, 4 deletions
diff --git a/src/wix/WixToolset.Converters/WixConverter.cs b/src/wix/WixToolset.Converters/WixConverter.cs
index 9c4cffbe..37b99a95 100644
--- a/src/wix/WixToolset.Converters/WixConverter.cs
+++ b/src/wix/WixToolset.Converters/WixConverter.cs
@@ -1540,7 +1540,8 @@ namespace WixToolset.Converters
1540 { 1540 {
1541 var id = element.Attribute("Id")?.Value; 1541 var id = element.Attribute("Id")?.Value;
1542 1542
1543 if (id?.StartsWith("WixUI_") == true 1543 if (id != null
1544 && (id == "WixUI_Advanced" || id == "WixUI_FeatureTree" || id == "WixUI_InstallDir" || id == "WixUI_Minimal" || id == "WixUI_Mondo")
1544 && this.OnInformation(ConverterTestType.ReferencesReplaced, element, "UI, custom action, and property reference {0} has been replaced with strongly-typed element.", id)) 1545 && this.OnInformation(ConverterTestType.ReferencesReplaced, element, "UI, custom action, and property reference {0} has been replaced with strongly-typed element.", id))
1545 { 1546 {
1546 this.XRoot.SetAttributeValue(XNamespace.Xmlns + "ui", WixUiNamespace.NamespaceName); 1547 this.XRoot.SetAttributeValue(XNamespace.Xmlns + "ui", WixUiNamespace.NamespaceName);
diff --git a/src/wix/test/WixToolsetTest.Converters/UIExtensionFixture.cs b/src/wix/test/WixToolsetTest.Converters/UIExtensionFixture.cs
index 5f3809d4..786b18d8 100644
--- a/src/wix/test/WixToolsetTest.Converters/UIExtensionFixture.cs
+++ b/src/wix/test/WixToolsetTest.Converters/UIExtensionFixture.cs
@@ -34,11 +34,11 @@ namespace WixToolsetTest.Converters
34 " <Fragment>", 34 " <Fragment>",
35 " <ui:WixUI Id=\"WixUI_Advanced\" />", 35 " <ui:WixUI Id=\"WixUI_Advanced\" />",
36 " <ui:WixUI Id=\"WixUI_FeatureTree\" />", 36 " <ui:WixUI Id=\"WixUI_FeatureTree\" />",
37 " <ui:WixUI Id=\"WixUI_BobsSpecialUI\" />", 37 " <UIRef Id=\"WixUI_BobsSpecialUI\" />",
38 " <UI>", 38 " <UI>",
39 " <ui:WixUI Id=\"WixUI_Advanced\" />", 39 " <ui:WixUI Id=\"WixUI_Advanced\" />",
40 " <ui:WixUI Id=\"WixUI_FeatureTree\" />", 40 " <ui:WixUI Id=\"WixUI_FeatureTree\" />",
41 " <ui:WixUI Id=\"WixUI_BobsSpecialUI\" />", 41 " <UIRef Id=\"WixUI_BobsSpecialUI\" />",
42 " </UI>", 42 " </UI>",
43 " </Fragment>", 43 " </Fragment>",
44 "</Wix>" 44 "</Wix>"
@@ -50,7 +50,7 @@ namespace WixToolsetTest.Converters
50 var converter = new WixConverter(messaging, 2, null, null); 50 var converter = new WixConverter(messaging, 2, null, null);
51 51
52 var errors = converter.ConvertDocument(document); 52 var errors = converter.ConvertDocument(document);
53 Assert.Equal(7, errors); 53 Assert.Equal(5, errors);
54 54
55 var actualLines = UnformattedDocumentLines(document); 55 var actualLines = UnformattedDocumentLines(document);
56 WixAssert.CompareLineByLine(expected, actualLines); 56 WixAssert.CompareLineByLine(expected, actualLines);