aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
-rw-r--r--src/WixToolset.BuildTasks/DoIt.cs6
-rw-r--r--src/test/WixToolsetTest.WixCop/WixCopRunner.cs5
-rw-r--r--src/wix/Program.cs6
-rw-r--r--src/wixcop/CommandLine/ConvertCommand.cs4
-rw-r--r--src/wixcop/CommandLine/WixCopCommandLineParser.cs4
-rw-r--r--src/wixcop/Program.cs4
6 files changed, 15 insertions, 14 deletions
diff --git a/src/WixToolset.BuildTasks/DoIt.cs b/src/WixToolset.BuildTasks/DoIt.cs
index 3aa9f5a3..ad89cc2c 100644
--- a/src/WixToolset.BuildTasks/DoIt.cs
+++ b/src/WixToolset.BuildTasks/DoIt.cs
@@ -111,7 +111,7 @@ namespace WixToolset.BuildTasks
111 111
112 public override bool Execute() 112 public override bool Execute()
113 { 113 {
114 var serviceProvider = new WixToolsetServiceProvider(); 114 var serviceProvider = WixToolsetServiceProviderFactory.CreateServiceProvider();
115 115
116 var listener = new MsbuildMessageListener(this.Log, "WIX", this.BuildEngine.ProjectFileOfTaskNode); 116 var listener = new MsbuildMessageListener(this.Log, "WIX", this.BuildEngine.ProjectFileOfTaskNode);
117 117
@@ -136,7 +136,7 @@ namespace WixToolset.BuildTasks
136 return !this.Log.HasLoggedErrors; 136 return !this.Log.HasLoggedErrors;
137 } 137 }
138 138
139 private void ExecuteCore(IServiceProvider serviceProvider, IMessageListener listener) 139 private void ExecuteCore(IWixToolsetServiceProvider serviceProvider, IMessageListener listener)
140 { 140 {
141 var commandLineString = this.BuildCommandLine(); 141 var commandLineString = this.BuildCommandLine();
142 142
@@ -191,7 +191,7 @@ namespace WixToolset.BuildTasks
191 return commandLineBuilder.ToString(); 191 return commandLineBuilder.ToString();
192 } 192 }
193 193
194 private IExtensionManager CreateExtensionManagerWithStandardBackends(IServiceProvider serviceProvider, IMessaging messaging, string[] extensions) 194 private IExtensionManager CreateExtensionManagerWithStandardBackends(IWixToolsetServiceProvider serviceProvider, IMessaging messaging, string[] extensions)
195 { 195 {
196 var extensionManager = serviceProvider.GetService<IExtensionManager>(); 196 var extensionManager = serviceProvider.GetService<IExtensionManager>();
197 197
diff --git a/src/test/WixToolsetTest.WixCop/WixCopRunner.cs b/src/test/WixToolsetTest.WixCop/WixCopRunner.cs
index b831baa7..d2a0abbe 100644
--- a/src/test/WixToolsetTest.WixCop/WixCopRunner.cs
+++ b/src/test/WixToolsetTest.WixCop/WixCopRunner.cs
@@ -7,6 +7,7 @@ namespace WixToolsetTest.WixCop
7 using WixToolset.Core; 7 using WixToolset.Core;
8 using WixToolset.Core.TestPackage; 8 using WixToolset.Core.TestPackage;
9 using WixToolset.Extensibility; 9 using WixToolset.Extensibility;
10 using WixToolset.Extensibility.Services;
10 using WixToolset.Tools.WixCop; 11 using WixToolset.Tools.WixCop;
11 using WixToolset.Tools.WixCop.CommandLine; 12 using WixToolset.Tools.WixCop.CommandLine;
12 using WixToolset.Tools.WixCop.Interfaces; 13 using WixToolset.Tools.WixCop.Interfaces;
@@ -45,7 +46,7 @@ namespace WixToolsetTest.WixCop
45 { 46 {
46 var listener = new TestMessageListener(); 47 var listener = new TestMessageListener();
47 48
48 var serviceProvider = new WixToolsetServiceProvider(); 49 var serviceProvider = WixToolsetServiceProviderFactory.CreateServiceProvider();
49 serviceProvider.AddService<IMessageListener>((x, y) => listener); 50 serviceProvider.AddService<IMessageListener>((x, y) => listener);
50 serviceProvider.AddService<IWixCopCommandLineParser>((x, y) => new WixCopCommandLineParser(x)); 51 serviceProvider.AddService<IWixCopCommandLineParser>((x, y) => new WixCopCommandLineParser(x));
51 52
@@ -58,7 +59,7 @@ namespace WixToolsetTest.WixCop
58 }; 59 };
59 } 60 }
60 61
61 public static int Execute(IServiceProvider serviceProvider, string[] args) 62 public static int Execute(IWixToolsetServiceProvider serviceProvider, string[] args)
62 { 63 {
63 var wixcop = new Program(); 64 var wixcop = new Program();
64 return wixcop.Run(serviceProvider, args); 65 return wixcop.Run(serviceProvider, args);
diff --git a/src/wix/Program.cs b/src/wix/Program.cs
index a3251f84..e2012ad2 100644
--- a/src/wix/Program.cs
+++ b/src/wix/Program.cs
@@ -24,7 +24,7 @@ namespace WixToolset.Tools
24 [MTAThread] 24 [MTAThread]
25 public static int Main(string[] args) 25 public static int Main(string[] args)
26 { 26 {
27 var serviceProvider = new WixToolsetServiceProvider(); 27 var serviceProvider = WixToolsetServiceProviderFactory.CreateServiceProvider();
28 28
29 var listener = new ConsoleMessageListener("WIX", "wix.exe"); 29 var listener = new ConsoleMessageListener("WIX", "wix.exe");
30 30
@@ -58,7 +58,7 @@ namespace WixToolset.Tools
58 /// <param name="serviceProvider">Service provider to use throughout this execution.</param> 58 /// <param name="serviceProvider">Service provider to use throughout this execution.</param>
59 /// <param name="args">Command-line arguments to execute.</param> 59 /// <param name="args">Command-line arguments to execute.</param>
60 /// <returns>Returns the application error code.</returns> 60 /// <returns>Returns the application error code.</returns>
61 public int Run(IServiceProvider serviceProvider, IMessageListener listener, string[] args) 61 public int Run(IWixToolsetServiceProvider serviceProvider, IMessageListener listener, string[] args)
62 { 62 {
63 var messaging = serviceProvider.GetService<IMessaging>(); 63 var messaging = serviceProvider.GetService<IMessaging>();
64 messaging.SetListener(listener); 64 messaging.SetListener(listener);
@@ -73,7 +73,7 @@ namespace WixToolset.Tools
73 return command?.Execute() ?? 1; 73 return command?.Execute() ?? 1;
74 } 74 }
75 75
76 private static IExtensionManager CreateExtensionManagerWithStandardBackends(IServiceProvider serviceProvider, IMessaging messaging, string[] extensions) 76 private static IExtensionManager CreateExtensionManagerWithStandardBackends(IWixToolsetServiceProvider serviceProvider, IMessaging messaging, string[] extensions)
77 { 77 {
78 var extensionManager = serviceProvider.GetService<IExtensionManager>(); 78 var extensionManager = serviceProvider.GetService<IExtensionManager>();
79 79
diff --git a/src/wixcop/CommandLine/ConvertCommand.cs b/src/wixcop/CommandLine/ConvertCommand.cs
index a9a110fe..8b01faa7 100644
--- a/src/wixcop/CommandLine/ConvertCommand.cs
+++ b/src/wixcop/CommandLine/ConvertCommand.cs
@@ -14,7 +14,7 @@ namespace WixToolset.Tools.WixCop.CommandLine
14 { 14 {
15 private const string SettingsFileDefault = "wixcop.settings.xml"; 15 private const string SettingsFileDefault = "wixcop.settings.xml";
16 16
17 public ConvertCommand(IServiceProvider serviceProvider, bool fixErrors, int indentationAmount, List<string> searchPatterns, bool subDirectories, string settingsFile1, string settingsFile2) 17 public ConvertCommand(IWixToolsetServiceProvider serviceProvider, bool fixErrors, int indentationAmount, List<string> searchPatterns, bool subDirectories, string settingsFile1, string settingsFile2)
18 { 18 {
19 this.ErrorsAsWarnings = new HashSet<string>(); 19 this.ErrorsAsWarnings = new HashSet<string>();
20 this.ExemptFiles = new HashSet<string>(); 20 this.ExemptFiles = new HashSet<string>();
@@ -43,7 +43,7 @@ namespace WixToolset.Tools.WixCop.CommandLine
43 43
44 private List<string> SearchPatterns { get; } 44 private List<string> SearchPatterns { get; }
45 45
46 private IServiceProvider ServiceProvider { get; } 46 private IWixToolsetServiceProvider ServiceProvider { get; }
47 47
48 private string SettingsFile1 { get; } 48 private string SettingsFile1 { get; }
49 49
diff --git a/src/wixcop/CommandLine/WixCopCommandLineParser.cs b/src/wixcop/CommandLine/WixCopCommandLineParser.cs
index 73247dae..3d34a649 100644
--- a/src/wixcop/CommandLine/WixCopCommandLineParser.cs
+++ b/src/wixcop/CommandLine/WixCopCommandLineParser.cs
@@ -14,14 +14,14 @@ namespace WixToolset.Tools.WixCop.CommandLine
14 private bool fixErrors; 14 private bool fixErrors;
15 private int indentationAmount; 15 private int indentationAmount;
16 private readonly List<string> searchPatterns; 16 private readonly List<string> searchPatterns;
17 private readonly IServiceProvider serviceProvider; 17 private readonly IWixToolsetServiceProvider serviceProvider;
18 private string settingsFile1; 18 private string settingsFile1;
19 private string settingsFile2; 19 private string settingsFile2;
20 private bool showHelp; 20 private bool showHelp;
21 private bool showLogo; 21 private bool showLogo;
22 private bool subDirectories; 22 private bool subDirectories;
23 23
24 public WixCopCommandLineParser(IServiceProvider serviceProvider) 24 public WixCopCommandLineParser(IWixToolsetServiceProvider serviceProvider)
25 { 25 {
26 this.serviceProvider = serviceProvider; 26 this.serviceProvider = serviceProvider;
27 27
diff --git a/src/wixcop/Program.cs b/src/wixcop/Program.cs
index 8e9534f6..e2174272 100644
--- a/src/wixcop/Program.cs
+++ b/src/wixcop/Program.cs
@@ -24,7 +24,7 @@ namespace WixToolset.Tools.WixCop
24 [STAThread] 24 [STAThread]
25 public static int Main(string[] args) 25 public static int Main(string[] args)
26 { 26 {
27 var serviceProvider = new WixToolsetServiceProvider(); 27 var serviceProvider = WixToolsetServiceProviderFactory.CreateServiceProvider();
28 var listener = new ConsoleMessageListener("WXCP", "wixcop.exe"); 28 var listener = new ConsoleMessageListener("WXCP", "wixcop.exe");
29 29
30 serviceProvider.AddService<IMessageListener>((x, y) => listener); 30 serviceProvider.AddService<IMessageListener>((x, y) => listener);
@@ -40,7 +40,7 @@ namespace WixToolset.Tools.WixCop
40 /// <param name="serviceProvider">Service provider to use throughout this execution.</param> 40 /// <param name="serviceProvider">Service provider to use throughout this execution.</param>
41 /// <param name="args">The commandline arguments.</param> 41 /// <param name="args">The commandline arguments.</param>
42 /// <returns>The number of errors that were found.</returns> 42 /// <returns>The number of errors that were found.</returns>
43 public int Run(IServiceProvider serviceProvider, string[] args) 43 public int Run(IWixToolsetServiceProvider serviceProvider, string[] args)
44 { 44 {
45 try 45 try
46 { 46 {