aboutsummaryrefslogtreecommitdiff
path: root/src/WixToolset.Converters/WixConverter.cs
diff options
context:
space:
mode:
Diffstat (limited to 'src/WixToolset.Converters/WixConverter.cs')
-rw-r--r--src/WixToolset.Converters/WixConverter.cs17
1 files changed, 17 insertions, 0 deletions
diff --git a/src/WixToolset.Converters/WixConverter.cs b/src/WixToolset.Converters/WixConverter.cs
index c713045e..be09a683 100644
--- a/src/WixToolset.Converters/WixConverter.cs
+++ b/src/WixToolset.Converters/WixConverter.cs
@@ -687,6 +687,12 @@ namespace WixToolset.Converters
687 { 687 {
688 xSummaryInformation.Name = SummaryInformationElementName; 688 xSummaryInformation.Name = SummaryInformationElementName;
689 689
690 var xInstallerVersion = xSummaryInformation.Attribute("InstallerVersion");
691 if (this.SourceVersion < 4 && xInstallerVersion == null)
692 {
693 this.OnError(ConverterTestType.InstallerVersionBehaviorChange, element, "Breaking change: The default value for Package/@InstallerVersion has been changed to '500' regardless of build platform. If you need a lower version, set it manually in the Module element.");
694 }
695
690 RemoveAttribute(xSummaryInformation, "AdminImage"); 696 RemoveAttribute(xSummaryInformation, "AdminImage");
691 RemoveAttribute(xSummaryInformation, "Comments"); 697 RemoveAttribute(xSummaryInformation, "Comments");
692 MoveAttribute(xSummaryInformation, "Id", xModule, "Guid"); 698 MoveAttribute(xSummaryInformation, "Id", xModule, "Guid");
@@ -750,6 +756,12 @@ namespace WixToolset.Converters
750 { 756 {
751 xSummaryInformation.Name = SummaryInformationElementName; 757 xSummaryInformation.Name = SummaryInformationElementName;
752 758
759 var xInstallerVersion = xSummaryInformation.Attribute("InstallerVersion");
760 if (this.SourceVersion < 4 && xInstallerVersion == null)
761 {
762 this.OnError(ConverterTestType.InstallerVersionBehaviorChange, element, "Breaking change: The default value for Package/@InstallerVersion has been changed to '500' regardless of build platform. If you need a lower version, set it manually in the Package element.");
763 }
764
753 RemoveAttribute(xSummaryInformation, "AdminImage"); 765 RemoveAttribute(xSummaryInformation, "AdminImage");
754 RemoveAttribute(xSummaryInformation, "Comments"); 766 RemoveAttribute(xSummaryInformation, "Comments");
755 MoveAttribute(xSummaryInformation, "Compressed", xPackage, defaultValue: "no"); 767 MoveAttribute(xSummaryInformation, "Compressed", xPackage, defaultValue: "no");
@@ -1456,6 +1468,11 @@ namespace WixToolset.Converters
1456 /// DisplayInternalUI can't be converted. 1468 /// DisplayInternalUI can't be converted.
1457 /// </summary> 1469 /// </summary>
1458 DisplayInternalUiNotConvertable, 1470 DisplayInternalUiNotConvertable,
1471
1472 /// <summary>
1473 /// InstallerVersion has breaking change when missing.
1474 /// </summary>
1475 InstallerVersionBehaviorChange,
1459 } 1476 }
1460 } 1477 }
1461} 1478}