diff options
Diffstat (limited to 'src/burn')
-rw-r--r-- | src/burn/engine/package.cpp | 5 | ||||
-rw-r--r-- | src/burn/engine/package.h | 1 | ||||
-rw-r--r-- | src/burn/engine/plan.cpp | 24 | ||||
-rw-r--r-- | src/burn/engine/plan.h | 1 | ||||
-rw-r--r-- | src/burn/engine/userexperience.cpp | 2 | ||||
-rw-r--r-- | src/burn/engine/userexperience.h | 1 | ||||
-rw-r--r-- | src/burn/test/BurnUnitTest/PlanTest.cpp | 95 | ||||
-rw-r--r-- | src/burn/test/BurnUnitTest/TestData/PlanTest/BundlePackage_Multiple_manifest.xml | 2 | ||||
-rw-r--r-- | src/burn/test/BurnUnitTest/VariableTest.cpp | 1 |
9 files changed, 126 insertions, 6 deletions
diff --git a/src/burn/engine/package.cpp b/src/burn/engine/package.cpp index 89203ada..88e7cb9d 100644 --- a/src/burn/engine/package.cpp +++ b/src/burn/engine/package.cpp | |||
@@ -178,6 +178,10 @@ extern "C" HRESULT PackagesParseFromXml( | |||
178 | hr = XmlGetAttributeEx(pixnNode, L"InstallCondition", &pPackage->sczInstallCondition); | 178 | hr = XmlGetAttributeEx(pixnNode, L"InstallCondition", &pPackage->sczInstallCondition); |
179 | ExitOnOptionalXmlQueryFailure(hr, fFoundXml, "Failed to get @InstallCondition."); | 179 | ExitOnOptionalXmlQueryFailure(hr, fFoundXml, "Failed to get @InstallCondition."); |
180 | 180 | ||
181 | // @RepairCondition | ||
182 | hr = XmlGetAttributeEx(pixnNode, L"RepairCondition", &pPackage->sczRepairCondition); | ||
183 | ExitOnOptionalXmlQueryFailure(hr, fFoundXml, "Failed to get @RepairCondition."); | ||
184 | |||
181 | // @RollbackBoundaryForward | 185 | // @RollbackBoundaryForward |
182 | hr = XmlGetAttributeEx(pixnNode, L"RollbackBoundaryForward", &scz); | 186 | hr = XmlGetAttributeEx(pixnNode, L"RollbackBoundaryForward", &scz); |
183 | ExitOnOptionalXmlQueryFailure(hr, fFoundXml, "Failed to get @RollbackBoundaryForward."); | 187 | ExitOnOptionalXmlQueryFailure(hr, fFoundXml, "Failed to get @RollbackBoundaryForward."); |
@@ -362,6 +366,7 @@ extern "C" void PackageUninitialize( | |||
362 | ReleaseStr(pPackage->sczLogPathVariable); | 366 | ReleaseStr(pPackage->sczLogPathVariable); |
363 | ReleaseStr(pPackage->sczRollbackLogPathVariable); | 367 | ReleaseStr(pPackage->sczRollbackLogPathVariable); |
364 | ReleaseStr(pPackage->sczInstallCondition); | 368 | ReleaseStr(pPackage->sczInstallCondition); |
369 | ReleaseStr(pPackage->sczRepairCondition); | ||
365 | ReleaseStr(pPackage->sczCacheId); | 370 | ReleaseStr(pPackage->sczCacheId); |
366 | 371 | ||
367 | if (pPackage->rgDependencyProviders) | 372 | if (pPackage->rgDependencyProviders) |
diff --git a/src/burn/engine/package.h b/src/burn/engine/package.h index eb8e7543..3ec77baf 100644 --- a/src/burn/engine/package.h +++ b/src/burn/engine/package.h | |||
@@ -250,6 +250,7 @@ typedef struct _BURN_PACKAGE | |||
250 | LPWSTR sczRollbackLogPathVariable; // name of the variable that will be set to the rollback path. | 250 | LPWSTR sczRollbackLogPathVariable; // name of the variable that will be set to the rollback path. |
251 | 251 | ||
252 | LPWSTR sczInstallCondition; | 252 | LPWSTR sczInstallCondition; |
253 | LPWSTR sczRepairCondition; | ||
253 | BOOL fPerMachine; | 254 | BOOL fPerMachine; |
254 | BOOL fPermanent; | 255 | BOOL fPermanent; |
255 | BOOL fVital; | 256 | BOOL fVital; |
diff --git a/src/burn/engine/plan.cpp b/src/burn/engine/plan.cpp index 2c267415..47da22c0 100644 --- a/src/burn/engine/plan.cpp +++ b/src/burn/engine/plan.cpp | |||
@@ -347,6 +347,7 @@ extern "C" HRESULT PlanDefaultPackageRequestState( | |||
347 | __in BOOTSTRAPPER_PACKAGE_STATE currentState, | 347 | __in BOOTSTRAPPER_PACKAGE_STATE currentState, |
348 | __in BOOTSTRAPPER_ACTION action, | 348 | __in BOOTSTRAPPER_ACTION action, |
349 | __in BOOTSTRAPPER_PACKAGE_CONDITION_RESULT installCondition, | 349 | __in BOOTSTRAPPER_PACKAGE_CONDITION_RESULT installCondition, |
350 | __in BOOTSTRAPPER_PACKAGE_CONDITION_RESULT repairCondition, | ||
350 | __in BOOTSTRAPPER_RELATION_TYPE relationType, | 351 | __in BOOTSTRAPPER_RELATION_TYPE relationType, |
351 | __out BOOTSTRAPPER_REQUEST_STATE* pRequestState | 352 | __out BOOTSTRAPPER_REQUEST_STATE* pRequestState |
352 | ) | 353 | ) |
@@ -408,6 +409,10 @@ extern "C" HRESULT PlanDefaultPackageRequestState( | |||
408 | { | 409 | { |
409 | defaultRequestState = BOOTSTRAPPER_REQUEST_STATE_PRESENT <= defaultRequestState ? BOOTSTRAPPER_REQUEST_STATE_NONE : defaultRequestState; | 410 | defaultRequestState = BOOTSTRAPPER_REQUEST_STATE_PRESENT <= defaultRequestState ? BOOTSTRAPPER_REQUEST_STATE_NONE : defaultRequestState; |
410 | } | 411 | } |
412 | else if (BOOTSTRAPPER_ACTION_REPAIR == action && BOOTSTRAPPER_PACKAGE_CONDITION_FALSE == repairCondition) | ||
413 | { | ||
414 | defaultRequestState = BOOTSTRAPPER_REQUEST_STATE_PRESENT; | ||
415 | } | ||
411 | } | 416 | } |
412 | 417 | ||
413 | *pRequestState = defaultRequestState; | 418 | *pRequestState = defaultRequestState; |
@@ -905,7 +910,8 @@ static HRESULT InitializePackage( | |||
905 | { | 910 | { |
906 | HRESULT hr = S_OK; | 911 | HRESULT hr = S_OK; |
907 | BOOTSTRAPPER_PACKAGE_CONDITION_RESULT installCondition = BOOTSTRAPPER_PACKAGE_CONDITION_DEFAULT; | 912 | BOOTSTRAPPER_PACKAGE_CONDITION_RESULT installCondition = BOOTSTRAPPER_PACKAGE_CONDITION_DEFAULT; |
908 | BOOL fInstallCondition = FALSE; | 913 | BOOTSTRAPPER_PACKAGE_CONDITION_RESULT repairCondition = BOOTSTRAPPER_PACKAGE_CONDITION_DEFAULT; |
914 | BOOL fEvaluatedCondition = FALSE; | ||
909 | BOOL fBeginCalled = FALSE; | 915 | BOOL fBeginCalled = FALSE; |
910 | BOOTSTRAPPER_RELATION_TYPE relationType = pPlan->pCommand->relationType; | 916 | BOOTSTRAPPER_RELATION_TYPE relationType = pPlan->pCommand->relationType; |
911 | 917 | ||
@@ -927,20 +933,28 @@ static HRESULT InitializePackage( | |||
927 | 933 | ||
928 | if (pPackage->sczInstallCondition && *pPackage->sczInstallCondition) | 934 | if (pPackage->sczInstallCondition && *pPackage->sczInstallCondition) |
929 | { | 935 | { |
930 | hr = ConditionEvaluate(pVariables, pPackage->sczInstallCondition, &fInstallCondition); | 936 | hr = ConditionEvaluate(pVariables, pPackage->sczInstallCondition, &fEvaluatedCondition); |
931 | ExitOnFailure(hr, "Failed to evaluate install condition."); | 937 | ExitOnFailure(hr, "Failed to evaluate install condition."); |
932 | 938 | ||
933 | installCondition = fInstallCondition ? BOOTSTRAPPER_PACKAGE_CONDITION_TRUE : BOOTSTRAPPER_PACKAGE_CONDITION_FALSE; | 939 | installCondition = fEvaluatedCondition ? BOOTSTRAPPER_PACKAGE_CONDITION_TRUE : BOOTSTRAPPER_PACKAGE_CONDITION_FALSE; |
940 | } | ||
941 | |||
942 | if (pPackage->sczRepairCondition && *pPackage->sczRepairCondition) | ||
943 | { | ||
944 | hr = ConditionEvaluate(pVariables, pPackage->sczRepairCondition, &fEvaluatedCondition); | ||
945 | ExitOnFailure(hr, "Failed to evaluate repair condition."); | ||
946 | |||
947 | repairCondition = fEvaluatedCondition ? BOOTSTRAPPER_PACKAGE_CONDITION_TRUE : BOOTSTRAPPER_PACKAGE_CONDITION_FALSE; | ||
934 | } | 948 | } |
935 | 949 | ||
936 | // Remember the default requested state so the engine doesn't get blamed for planning the wrong thing if the BA changes it. | 950 | // Remember the default requested state so the engine doesn't get blamed for planning the wrong thing if the BA changes it. |
937 | hr = PlanDefaultPackageRequestState(pPackage->type, pPackage->currentState, pPlan->action, installCondition, relationType, &pPackage->defaultRequested); | 951 | hr = PlanDefaultPackageRequestState(pPackage->type, pPackage->currentState, pPlan->action, installCondition, repairCondition, relationType, &pPackage->defaultRequested); |
938 | ExitOnFailure(hr, "Failed to set default package state."); | 952 | ExitOnFailure(hr, "Failed to set default package state."); |
939 | 953 | ||
940 | pPackage->requested = pPackage->defaultRequested; | 954 | pPackage->requested = pPackage->defaultRequested; |
941 | fBeginCalled = TRUE; | 955 | fBeginCalled = TRUE; |
942 | 956 | ||
943 | hr = UserExperienceOnPlanPackageBegin(pUX, pPackage->sczId, pPackage->currentState, pPackage->fCached, installCondition, &pPackage->requested, &pPackage->cacheType); | 957 | hr = UserExperienceOnPlanPackageBegin(pUX, pPackage->sczId, pPackage->currentState, pPackage->fCached, installCondition, repairCondition, &pPackage->requested, &pPackage->cacheType); |
944 | ExitOnRootFailure(hr, "BA aborted plan package begin."); | 958 | ExitOnRootFailure(hr, "BA aborted plan package begin."); |
945 | 959 | ||
946 | if (BURN_PACKAGE_TYPE_MSI == pPackage->type) | 960 | if (BURN_PACKAGE_TYPE_MSI == pPackage->type) |
diff --git a/src/burn/engine/plan.h b/src/burn/engine/plan.h index 87214cc8..fbb7a5a1 100644 --- a/src/burn/engine/plan.h +++ b/src/burn/engine/plan.h | |||
@@ -342,6 +342,7 @@ HRESULT PlanDefaultPackageRequestState( | |||
342 | __in BOOTSTRAPPER_PACKAGE_STATE currentState, | 342 | __in BOOTSTRAPPER_PACKAGE_STATE currentState, |
343 | __in BOOTSTRAPPER_ACTION action, | 343 | __in BOOTSTRAPPER_ACTION action, |
344 | __in BOOTSTRAPPER_PACKAGE_CONDITION_RESULT installCondition, | 344 | __in BOOTSTRAPPER_PACKAGE_CONDITION_RESULT installCondition, |
345 | __in BOOTSTRAPPER_PACKAGE_CONDITION_RESULT repairCondition, | ||
345 | __in BOOTSTRAPPER_RELATION_TYPE relationType, | 346 | __in BOOTSTRAPPER_RELATION_TYPE relationType, |
346 | __out BOOTSTRAPPER_REQUEST_STATE* pRequestState | 347 | __out BOOTSTRAPPER_REQUEST_STATE* pRequestState |
347 | ); | 348 | ); |
diff --git a/src/burn/engine/userexperience.cpp b/src/burn/engine/userexperience.cpp index a1a010d2..a3cbcd4a 100644 --- a/src/burn/engine/userexperience.cpp +++ b/src/burn/engine/userexperience.cpp | |||
@@ -2169,6 +2169,7 @@ EXTERN_C BAAPI UserExperienceOnPlanPackageBegin( | |||
2169 | __in BOOTSTRAPPER_PACKAGE_STATE state, | 2169 | __in BOOTSTRAPPER_PACKAGE_STATE state, |
2170 | __in BOOL fCached, | 2170 | __in BOOL fCached, |
2171 | __in BOOTSTRAPPER_PACKAGE_CONDITION_RESULT installCondition, | 2171 | __in BOOTSTRAPPER_PACKAGE_CONDITION_RESULT installCondition, |
2172 | __in BOOTSTRAPPER_PACKAGE_CONDITION_RESULT repairCondition, | ||
2172 | __inout BOOTSTRAPPER_REQUEST_STATE* pRequestedState, | 2173 | __inout BOOTSTRAPPER_REQUEST_STATE* pRequestedState, |
2173 | __inout BOOTSTRAPPER_CACHE_TYPE* pRequestedCacheType | 2174 | __inout BOOTSTRAPPER_CACHE_TYPE* pRequestedCacheType |
2174 | ) | 2175 | ) |
@@ -2182,6 +2183,7 @@ EXTERN_C BAAPI UserExperienceOnPlanPackageBegin( | |||
2182 | args.state = state; | 2183 | args.state = state; |
2183 | args.fCached = fCached; | 2184 | args.fCached = fCached; |
2184 | args.installCondition = installCondition; | 2185 | args.installCondition = installCondition; |
2186 | args.repairCondition = repairCondition; | ||
2185 | args.recommendedState = *pRequestedState; | 2187 | args.recommendedState = *pRequestedState; |
2186 | args.recommendedCacheType = *pRequestedCacheType; | 2188 | args.recommendedCacheType = *pRequestedCacheType; |
2187 | 2189 | ||
diff --git a/src/burn/engine/userexperience.h b/src/burn/engine/userexperience.h index 90a047ed..2059b521 100644 --- a/src/burn/engine/userexperience.h +++ b/src/burn/engine/userexperience.h | |||
@@ -501,6 +501,7 @@ BAAPI UserExperienceOnPlanPackageBegin( | |||
501 | __in BOOTSTRAPPER_PACKAGE_STATE state, | 501 | __in BOOTSTRAPPER_PACKAGE_STATE state, |
502 | __in BOOL fCached, | 502 | __in BOOL fCached, |
503 | __in BOOTSTRAPPER_PACKAGE_CONDITION_RESULT installCondition, | 503 | __in BOOTSTRAPPER_PACKAGE_CONDITION_RESULT installCondition, |
504 | __in BOOTSTRAPPER_PACKAGE_CONDITION_RESULT repairCondition, | ||
504 | __inout BOOTSTRAPPER_REQUEST_STATE* pRequestedState, | 505 | __inout BOOTSTRAPPER_REQUEST_STATE* pRequestedState, |
505 | __inout BOOTSTRAPPER_CACHE_TYPE* pRequestedCacheType | 506 | __inout BOOTSTRAPPER_CACHE_TYPE* pRequestedCacheType |
506 | ); | 507 | ); |
diff --git a/src/burn/test/BurnUnitTest/PlanTest.cpp b/src/burn/test/BurnUnitTest/PlanTest.cpp index 87bbbffd..f69606a0 100644 --- a/src/burn/test/BurnUnitTest/PlanTest.cpp +++ b/src/burn/test/BurnUnitTest/PlanTest.cpp | |||
@@ -459,6 +459,101 @@ namespace Bootstrapper | |||
459 | } | 459 | } |
460 | 460 | ||
461 | [Fact] | 461 | [Fact] |
462 | void MultipleBundlePackageRepairTest() | ||
463 | { | ||
464 | HRESULT hr = S_OK; | ||
465 | BURN_ENGINE_STATE engineState = { }; | ||
466 | BURN_ENGINE_STATE* pEngineState = &engineState; | ||
467 | BURN_PLAN* pPlan = &engineState.plan; | ||
468 | |||
469 | InitializeEngineStateForCorePlan(wzMultipleBundlePackageManifestFileName, pEngineState); | ||
470 | DetectAttachedContainerAsAttached(pEngineState); | ||
471 | DetectPackagesAsPresentAndCached(pEngineState); | ||
472 | |||
473 | hr = CorePlan(pEngineState, BOOTSTRAPPER_ACTION_REPAIR); | ||
474 | NativeAssert::Succeeded(hr, "CorePlan failed"); | ||
475 | |||
476 | Assert::Equal<DWORD>(BOOTSTRAPPER_ACTION_REPAIR, pPlan->action); | ||
477 | NativeAssert::StringEqual(L"{35192ED0-C70A-49B2-9D12-3B1FA39B5E6F}", pPlan->wzBundleId); | ||
478 | NativeAssert::StringEqual(L"{35192ED0-C70A-49B2-9D12-3B1FA39B5E6F}", pPlan->wzBundleProviderKey); | ||
479 | Assert::Equal<BOOL>(FALSE, pPlan->fEnabledForwardCompatibleBundle); | ||
480 | Assert::Equal<BOOL>(TRUE, pPlan->fPerMachine); | ||
481 | Assert::Equal<BOOL>(TRUE, pPlan->fCanAffectMachineState); | ||
482 | Assert::Equal<BOOL>(FALSE, pPlan->fDisableRollback); | ||
483 | Assert::Equal<BOOL>(FALSE, pPlan->fDisallowRemoval); | ||
484 | Assert::Equal<BOOL>(FALSE, pPlan->fDowngrade); | ||
485 | Assert::Equal<DWORD>(BURN_REGISTRATION_ACTION_OPERATIONS_CACHE_BUNDLE | BURN_REGISTRATION_ACTION_OPERATIONS_WRITE_PROVIDER_KEY, pPlan->dwRegistrationOperations); | ||
486 | |||
487 | BOOL fRollback = FALSE; | ||
488 | DWORD dwIndex = 0; | ||
489 | Assert::Equal(dwIndex, pPlan->cRegistrationActions); | ||
490 | |||
491 | fRollback = TRUE; | ||
492 | dwIndex = 0; | ||
493 | Assert::Equal(dwIndex, pPlan->cRollbackRegistrationActions); | ||
494 | |||
495 | fRollback = FALSE; | ||
496 | dwIndex = 0; | ||
497 | ValidateCacheCheckpoint(pPlan, fRollback, dwIndex++, 2); | ||
498 | ValidateCachePackage(pPlan, fRollback, dwIndex++, L"PackageB"); | ||
499 | ValidateCacheSignalSyncpoint(pPlan, fRollback, dwIndex++); | ||
500 | Assert::Equal(dwIndex, pPlan->cCacheActions); | ||
501 | |||
502 | fRollback = TRUE; | ||
503 | dwIndex = 0; | ||
504 | Assert::Equal(dwIndex, pPlan->cRollbackCacheActions); | ||
505 | |||
506 | Assert::Equal(18575450ull, pPlan->qwEstimatedSize); | ||
507 | Assert::Equal(52254105ull, pPlan->qwCacheSizeTotal); | ||
508 | |||
509 | fRollback = FALSE; | ||
510 | dwIndex = 0; | ||
511 | DWORD dwExecuteCheckpointId = 1; | ||
512 | ValidateExecuteRollbackBoundaryStart(pPlan, fRollback, dwIndex++, L"WixDefaultBoundary", TRUE, FALSE); | ||
513 | ValidateExecutePackageDependency(pPlan, fRollback, dwIndex++, L"PackageA", L"{35192ED0-C70A-49B2-9D12-3B1FA39B5E6F}", registerActions1, 1); | ||
514 | ValidateExecuteCheckpoint(pPlan, fRollback, dwIndex++, dwExecuteCheckpointId++); | ||
515 | dwExecuteCheckpointId += 1; // cache checkpoints | ||
516 | ValidateExecuteCheckpoint(pPlan, fRollback, dwIndex++, dwExecuteCheckpointId++); | ||
517 | ValidateExecuteWaitCachePackage(pPlan, fRollback, dwIndex++, L"PackageB"); | ||
518 | ValidateExecuteBundlePackage(pPlan, fRollback, dwIndex++, L"PackageB", BOOTSTRAPPER_ACTION_STATE_REPAIR, L"{35192ED0-C70A-49B2-9D12-3B1FA39B5E6F}"); | ||
519 | ValidateExecutePackageDependency(pPlan, fRollback, dwIndex++, L"PackageB", L"{35192ED0-C70A-49B2-9D12-3B1FA39B5E6F}", registerActions1, 1); | ||
520 | ValidateExecuteCheckpoint(pPlan, fRollback, dwIndex++, dwExecuteCheckpointId++); | ||
521 | ValidateExecuteCheckpoint(pPlan, fRollback, dwIndex++, dwExecuteCheckpointId++); | ||
522 | ValidateExecuteRollbackBoundaryEnd(pPlan, fRollback, dwIndex++); | ||
523 | Assert::Equal(dwIndex, pPlan->cExecuteActions); | ||
524 | |||
525 | fRollback = TRUE; | ||
526 | dwIndex = 0; | ||
527 | dwExecuteCheckpointId = 1; | ||
528 | ValidateExecuteRollbackBoundaryStart(pPlan, fRollback, dwIndex++, L"WixDefaultBoundary", TRUE, FALSE); | ||
529 | ValidateExecuteCheckpoint(pPlan, fRollback, dwIndex++, dwExecuteCheckpointId++); | ||
530 | dwExecuteCheckpointId += 1; // cache checkpoints | ||
531 | ValidateExecuteCheckpoint(pPlan, fRollback, dwIndex++, dwExecuteCheckpointId++); | ||
532 | ValidateExecuteCheckpoint(pPlan, fRollback, dwIndex++, dwExecuteCheckpointId++); | ||
533 | ValidateExecuteCheckpoint(pPlan, fRollback, dwIndex++, dwExecuteCheckpointId++); | ||
534 | ValidateExecuteRollbackBoundaryEnd(pPlan, fRollback, dwIndex++); | ||
535 | Assert::Equal(dwIndex, pPlan->cRollbackActions); | ||
536 | |||
537 | Assert::Equal(1ul, pPlan->cExecutePackagesTotal); | ||
538 | Assert::Equal(2ul, pPlan->cOverallProgressTicksTotal); | ||
539 | |||
540 | dwIndex = 0; | ||
541 | Assert::Equal(dwIndex, pPlan->cRestoreRelatedBundleActions); | ||
542 | |||
543 | dwIndex = 0; | ||
544 | ValidateCleanAction(pPlan, dwIndex++, L"NetFx48Web"); | ||
545 | Assert::Equal(dwIndex, pPlan->cCleanActions); | ||
546 | |||
547 | UINT uIndex = 0; | ||
548 | ValidatePlannedProvider(pPlan, uIndex++, L"{35192ED0-C70A-49B2-9D12-3B1FA39B5E6F}", NULL); | ||
549 | Assert::Equal(uIndex, pPlan->cPlannedProviders); | ||
550 | |||
551 | Assert::Equal(3ul, pEngineState->packages.cPackages); | ||
552 | ValidateNonPermanentPackageExpectedStates(&pEngineState->packages.rgPackages[1], L"PackageA", BURN_PACKAGE_REGISTRATION_STATE_PRESENT, BURN_PACKAGE_REGISTRATION_STATE_PRESENT); | ||
553 | ValidateNonPermanentPackageExpectedStates(&pEngineState->packages.rgPackages[2], L"PackageB", BURN_PACKAGE_REGISTRATION_STATE_PRESENT, BURN_PACKAGE_REGISTRATION_STATE_PRESENT); | ||
554 | } | ||
555 | |||
556 | [Fact] | ||
462 | void OrphanCompatiblePackageTest() | 557 | void OrphanCompatiblePackageTest() |
463 | { | 558 | { |
464 | HRESULT hr = S_OK; | 559 | HRESULT hr = S_OK; |
diff --git a/src/burn/test/BurnUnitTest/TestData/PlanTest/BundlePackage_Multiple_manifest.xml b/src/burn/test/BurnUnitTest/TestData/PlanTest/BundlePackage_Multiple_manifest.xml index 0b521faa..b02c2056 100644 --- a/src/burn/test/BurnUnitTest/TestData/PlanTest/BundlePackage_Multiple_manifest.xml +++ b/src/burn/test/BurnUnitTest/TestData/PlanTest/BundlePackage_Multiple_manifest.xml | |||
@@ -1 +1 @@ | |||
<?xml version="1.0" encoding="utf-8"?><BurnManifest xmlns="http://wixtoolset.org/schemas/v4/2008/Burn"><Log PathVariable="WixBundleLog" Prefix="~BundlePackageTests_MultipleBundlePackagesBundle" Extension=".log" /><RelatedBundle Id="{86D214FB-8D74-456C-99B3-6557ECA6159C}" Action="Upgrade" /><Variable Id="TestGroupName" Value="BundlePackageTests" Type="string" Hidden="no" Persisted="no" /><Variable Id="WixBundleInProgressName" Hidden="no" Persisted="yes" /><Variable Id="WixBundleName" Hidden="no" Persisted="yes" /><Variable Id="WixBundleOriginalSource" Hidden="no" Persisted="yes" /><Variable Id="WixBundleOriginalSourceFolder" Hidden="no" Persisted="yes" /><Variable Id="WixBundleLastUsedSource" Hidden="no" Persisted="yes" /><RegistrySearch Id="NETFRAMEWORK45" Variable="NETFRAMEWORK45" Root="HKLM" Key="SOFTWARE\Microsoft\NET Framework Setup\NDP\v4\Full" Value="Release" Type="value" VariableType="string" /><UX><Payload Id="WixManagedBootstrapperApplicationHost" FilePath="mbahost.dll" SourcePath="u30" /><Payload Id="payO60IVK4ATGzPpMz3rwVbUWl6DyU" FilePath="WixToolset.Mba.Host.config" SourcePath="u0" /><Payload Id="payxj4zDAKL2NVlz4ohp0GvwFHepyI" FilePath="TestBA.dll" SourcePath="u1" /><Payload Id="pay1hOSAUC8_D633cD2TXpIXCL30OU" FilePath="mbanative.dll" SourcePath="u2" /><Payload Id="payujy6Izl_BlUNfHt2eI.ADfjYAv4" FilePath="WixToolset.Mba.Core.dll" SourcePath="u3" /><Payload Id="payR4EbR4OTDZpPEycWaSSM_gZRBWM" FilePath="mbapreq.thm" SourcePath="u4" /><Payload Id="paylVCy2Ecl8pHPdJTCQZryUG4T9us" FilePath="mbapreq.png" SourcePath="u5" /><Payload Id="payTaG4B_lob1aLcKFaOqSSG3MPMpU" FilePath="mbapreq.wxl" SourcePath="u6" /><Payload Id="payZwIGuiezVTitZOoZKxyh2DdRSGs" FilePath="1028\mbapreq.wxl" SourcePath="u7" /><Payload Id="pay.herBWX.LlOh8jLsx24aWdunV_0" FilePath="1029\mbapreq.wxl" SourcePath="u8" /><Payload Id="pay8DkMszYsoxxdgX14huLDMYXylQg" FilePath="1030\mbapreq.wxl" SourcePath="u9" /><Payload Id="payPaHpoTeOdkW.TK99IDwktNLhTAg" FilePath="1031\mbapreq.wxl" SourcePath="u10" /><Payload Id="pay45AtAzterLTMzZgdxxtuYvaiXwU" FilePath="1032\mbapreq.wxl" SourcePath="u11" /><Payload Id="payA2VEKIqhePyNIEmr14eyH3JoVLc" FilePath="1035\mbapreq.wxl" SourcePath="u12" /><Payload Id="payvre23ObscjzhcaFIifUAkXMdPa8" FilePath="1036\mbapreq.wxl" SourcePath="u13" /><Payload Id="paytxUV3vuBbG2c.a9c.d_sZX2x6wA" FilePath="1038\mbapreq.wxl" SourcePath="u14" /><Payload Id="payYvMWRK9xelo5.sQn7jRkJIaBp9A" FilePath="1040\mbapreq.wxl" SourcePath="u15" /><Payload Id="pay68KKSApyQimbA25t6kSbqhdeH10" FilePath="1041\mbapreq.wxl" SourcePath="u16" /><Payload Id="paypiqxaHpYZqx.9eDVjQrj1igLbRY" FilePath="1042\mbapreq.wxl" SourcePath="u17" /><Payload Id="payTO0YwZzxKpbqdrBVUcVRTu3BFe8" FilePath="1043\mbapreq.wxl" SourcePath="u18" /><Payload Id="payIXg2ldBJukRzhqWolJVOEbTmF34" FilePath="1044\mbapreq.wxl" SourcePath="u19" /><Payload Id="payOHIZbSkIvrpwKkkXI173tv3u3B4" FilePath="1045\mbapreq.wxl" SourcePath="u20" /><Payload Id="payQRQ_UZl_R2UtV0xDXB2yeH2bg3E" FilePath="1046\mbapreq.wxl" SourcePath="u21" /><Payload Id="payhrejLLBfc1i27iN._QPhQ4K337I" FilePath="1049\mbapreq.wxl" SourcePath="u22" /><Payload Id="payqEzaDNzxB68vGp29jgDcCos6dvg" FilePath="1051\mbapreq.wxl" SourcePath="u23" /><Payload Id="paydz8Vk8xSTyYohgGXTSIxWGXL5.Q" FilePath="1053\mbapreq.wxl" SourcePath="u24" /><Payload Id="pay0HRUZTlbC3taSOffJBsEj92Br8Y" FilePath="1055\mbapreq.wxl" SourcePath="u25" /><Payload Id="payIvUOkc_EMH7laMFehefNolV8hZo" FilePath="1060\mbapreq.wxl" SourcePath="u26" /><Payload Id="payLFhOb.rHuk4sW5CYAPMShG0NjGI" FilePath="2052\mbapreq.wxl" SourcePath="u27" /><Payload Id="payqIKCmERK7Nhxx_nNXvRxdKqKDbI" FilePath="2070\mbapreq.wxl" SourcePath="u28" /><Payload Id="payqeWUzIVaEqjuRXN0z8ECC3Y4tCc" FilePath="3082\mbapreq.wxl" SourcePath="u29" /><Payload Id="paylfeHEjJSSTnNzY9QMZM2Ye3Ipy4" FilePath="mbapreq.dll" SourcePath="u31" /><Payload Id="payDPxs6uy8nbky.R7zhir2RRAfc.c" FilePath="WixToolset.Mba.Host.dll" SourcePath="u32" /><Payload Id="uxTxMXPVMXwQrPTMIGa5WGt93w0Ns" FilePath="BootstrapperApplicationData.xml" SourcePath="u33" /><Payload Id="uxYRbgitOs0K878jn5L_z7LdJ21KI" FilePath="BundleExtensionData.xml" SourcePath="u34" /></UX><Container Id="WixAttachedContainer" FileSize="15696370" Hash="0F9966B421400E481D394DB4C4D7F0F92548E5BEB79B98880C926E817E8C1F381EC8A17053E2E66AE7132A3C9ECE441629E6A1FB3452C5C9282280C40252F141" FilePath="MultipleBundlePackagesBundle.exe" AttachedIndex="1" Attached="yes" Primary="yes" /><Payload Id="NetFx48Web" FilePath="redist\ndp48-web.exe" FileSize="1439328" CertificateRootPublicKeyIdentifier="F49F9B33E25E33CCA0BFB15A62B7C29FFAB3880B" CertificateRootThumbprint="ABDCA79AF9DD48A0EA702AD45260B3C03093FB4B" DownloadUrl="https://go.microsoft.com/fwlink/?LinkId=2085155" Packaging="external" SourcePath="redist\ndp48-web.exe" /><Payload Id="PackageA" FilePath="BundleA.exe" FileSize="5241635" Hash="20E1AFF76DE4693CB2876DC6BCCA0152DB16BE49AEDE2CD581C03FC39AB89DEA12BC25CB435F06E4D7D2B4443CE8A8935D5E92E2E49A4981B60A273980E4B29B" Packaging="embedded" SourcePath="a0" Container="WixAttachedContainer" /><Payload Id="PackageB" FilePath="BundleB_x64.exe" FileSize="10450821" Hash="43A58873D61D6E0FA83F6C5266F2F05FEA9BC85D11C195493B7FD9F0B4AA799C1EFCB78D76DCED32124D2EC62A4E7114B62CDE6F0B87E42A7E28CDBB0DA0FF8E" Packaging="embedded" SourcePath="a1" Container="WixAttachedContainer" /><RollbackBoundary Id="WixDefaultBoundary" Vital="yes" Transaction="no" /><Registration Id="{35192ED0-C70A-49B2-9D12-3B1FA39B5E6F}" ExecutableName="MultipleBundlePackagesBundle.exe" PerMachine="yes" Tag="" Version="1.0.0.0" ProviderKey="{35192ED0-C70A-49B2-9D12-3B1FA39B5E6F}"><Arp Register="yes" DisplayName="~BundlePackageTests - MultipleBundlePackagesBundle" DisplayVersion="1.0.0.0" /></Registration><Chain><ExePackage Id="NetFx48Web" Cache="remove" CacheId="642721C60D52051C7F3434D8710FE3406A7CFE10B2B39E90EA847719ED1697D7C614F2DF44AD50412B1DF8C98DD78FDC57CA1D047D28C81AC158092E5FB18040" InstallSize="1439328" Size="1439328" PerMachine="yes" Permanent="yes" Vital="yes" RollbackBoundaryForward="WixDefaultBoundary" LogPathVariable="NetFx48WebLog" RollbackLogPathVariable="WixBundleRollbackLog_NetFx48Web" DetectCondition="NETFRAMEWORK45 >= 528040" InstallArguments="/q /norestart /log "[NetFx48WebLog].html"" UninstallArguments="" Uninstallable="no" RepairArguments="" Repairable="no" Protocol="netfx4"><PayloadRef Id="NetFx48Web" /></ExePackage><BundlePackage Id="PackageA" Cache="keep" CacheId="{B39CEE4D-CCD7-4797-BE3A-6613BD1DC4BE}v1.0.0.0" InstallSize="2169" Size="5241635" Version="1.0.0.0" PerMachine="yes" Permanent="no" Vital="yes" LogPathVariable="WixBundleLog_PackageA" RollbackLogPathVariable="WixBundleRollbackLog_PackageA" BundleId="{B39CEE4D-CCD7-4797-BE3A-6613BD1DC4BE}" InstallArguments="" UninstallArguments="" RepairArguments="" SupportsBurnProtocol="yes" Win64="no"><Provides Key="{B39CEE4D-CCD7-4797-BE3A-6613BD1DC4BE}" Version="1.0.0.0" DisplayName="~BasicFunctionalityTests - BundleA" Imported="yes" /><RelatedBundle Id="{8C7E2C47-1EE7-4BBE-99A2-EAB7F3693F48}" Action="Upgrade" /><PayloadRef Id="PackageA" /></BundlePackage><BundlePackage Id="PackageB" Cache="keep" CacheId="{7506235A-7C59-4750-82C7-EB460A87ED3A}v1.0.0.0" InstallSize="1441497" Size="10450821" Version="1.0.0.0" PerMachine="yes" Permanent="no" Vital="yes" RollbackBoundaryBackward="WixDefaultBoundary" LogPathVariable="WixBundleLog_PackageB" RollbackLogPathVariable="WixBundleRollbackLog_PackageB" BundleId="{7506235A-7C59-4750-82C7-EB460A87ED3A}" InstallArguments="" UninstallArguments="" RepairArguments="" SupportsBurnProtocol="yes" Win64="yes"><Provides Key="{7506235A-7C59-4750-82C7-EB460A87ED3A}" Version="1.0.0.0" DisplayName="~BasicFunctionalityTests - BundleB_x64" Imported="yes" /><RelatedBundle Id="{79F45B7A-D990-46E4-819B-078D87C3321A}" Action="Upgrade" /><PayloadRef Id="PackageB" /></BundlePackage></Chain><CommandLine Variables="upperCase" /></BurnManifest> | <?xml version="1.0" encoding="utf-8"?><BurnManifest xmlns="http://wixtoolset.org/schemas/v4/2008/Burn"><Log PathVariable="WixBundleLog" Prefix="~BundlePackageTests_MultipleBundlePackagesBundle" Extension=".log" /><RelatedBundle Id="{86D214FB-8D74-456C-99B3-6557ECA6159C}" Action="Upgrade" /><Variable Id="TestGroupName" Value="BundlePackageTests" Type="string" Hidden="no" Persisted="no" /><Variable Id="WixBundleInProgressName" Hidden="no" Persisted="yes" /><Variable Id="WixBundleName" Hidden="no" Persisted="yes" /><Variable Id="WixBundleOriginalSource" Hidden="no" Persisted="yes" /><Variable Id="WixBundleOriginalSourceFolder" Hidden="no" Persisted="yes" /><Variable Id="WixBundleLastUsedSource" Hidden="no" Persisted="yes" /><RegistrySearch Id="NETFRAMEWORK45" Variable="NETFRAMEWORK45" Root="HKLM" Key="SOFTWARE\Microsoft\NET Framework Setup\NDP\v4\Full" Value="Release" Type="value" VariableType="string" /><UX><Payload Id="WixManagedBootstrapperApplicationHost" FilePath="mbahost.dll" SourcePath="u30" /><Payload Id="payO60IVK4ATGzPpMz3rwVbUWl6DyU" FilePath="WixToolset.Mba.Host.config" SourcePath="u0" /><Payload Id="payxj4zDAKL2NVlz4ohp0GvwFHepyI" FilePath="TestBA.dll" SourcePath="u1" /><Payload Id="pay1hOSAUC8_D633cD2TXpIXCL30OU" FilePath="mbanative.dll" SourcePath="u2" /><Payload Id="payujy6Izl_BlUNfHt2eI.ADfjYAv4" FilePath="WixToolset.Mba.Core.dll" SourcePath="u3" /><Payload Id="payR4EbR4OTDZpPEycWaSSM_gZRBWM" FilePath="mbapreq.thm" SourcePath="u4" /><Payload Id="paylVCy2Ecl8pHPdJTCQZryUG4T9us" FilePath="mbapreq.png" SourcePath="u5" /><Payload Id="payTaG4B_lob1aLcKFaOqSSG3MPMpU" FilePath="mbapreq.wxl" SourcePath="u6" /><Payload Id="payZwIGuiezVTitZOoZKxyh2DdRSGs" FilePath="1028\mbapreq.wxl" SourcePath="u7" /><Payload Id="pay.herBWX.LlOh8jLsx24aWdunV_0" FilePath="1029\mbapreq.wxl" SourcePath="u8" /><Payload Id="pay8DkMszYsoxxdgX14huLDMYXylQg" FilePath="1030\mbapreq.wxl" SourcePath="u9" /><Payload Id="payPaHpoTeOdkW.TK99IDwktNLhTAg" FilePath="1031\mbapreq.wxl" SourcePath="u10" /><Payload Id="pay45AtAzterLTMzZgdxxtuYvaiXwU" FilePath="1032\mbapreq.wxl" SourcePath="u11" /><Payload Id="payA2VEKIqhePyNIEmr14eyH3JoVLc" FilePath="1035\mbapreq.wxl" SourcePath="u12" /><Payload Id="payvre23ObscjzhcaFIifUAkXMdPa8" FilePath="1036\mbapreq.wxl" SourcePath="u13" /><Payload Id="paytxUV3vuBbG2c.a9c.d_sZX2x6wA" FilePath="1038\mbapreq.wxl" SourcePath="u14" /><Payload Id="payYvMWRK9xelo5.sQn7jRkJIaBp9A" FilePath="1040\mbapreq.wxl" SourcePath="u15" /><Payload Id="pay68KKSApyQimbA25t6kSbqhdeH10" FilePath="1041\mbapreq.wxl" SourcePath="u16" /><Payload Id="paypiqxaHpYZqx.9eDVjQrj1igLbRY" FilePath="1042\mbapreq.wxl" SourcePath="u17" /><Payload Id="payTO0YwZzxKpbqdrBVUcVRTu3BFe8" FilePath="1043\mbapreq.wxl" SourcePath="u18" /><Payload Id="payIXg2ldBJukRzhqWolJVOEbTmF34" FilePath="1044\mbapreq.wxl" SourcePath="u19" /><Payload Id="payOHIZbSkIvrpwKkkXI173tv3u3B4" FilePath="1045\mbapreq.wxl" SourcePath="u20" /><Payload Id="payQRQ_UZl_R2UtV0xDXB2yeH2bg3E" FilePath="1046\mbapreq.wxl" SourcePath="u21" /><Payload Id="payhrejLLBfc1i27iN._QPhQ4K337I" FilePath="1049\mbapreq.wxl" SourcePath="u22" /><Payload Id="payqEzaDNzxB68vGp29jgDcCos6dvg" FilePath="1051\mbapreq.wxl" SourcePath="u23" /><Payload Id="paydz8Vk8xSTyYohgGXTSIxWGXL5.Q" FilePath="1053\mbapreq.wxl" SourcePath="u24" /><Payload Id="pay0HRUZTlbC3taSOffJBsEj92Br8Y" FilePath="1055\mbapreq.wxl" SourcePath="u25" /><Payload Id="payIvUOkc_EMH7laMFehefNolV8hZo" FilePath="1060\mbapreq.wxl" SourcePath="u26" /><Payload Id="payLFhOb.rHuk4sW5CYAPMShG0NjGI" FilePath="2052\mbapreq.wxl" SourcePath="u27" /><Payload Id="payqIKCmERK7Nhxx_nNXvRxdKqKDbI" FilePath="2070\mbapreq.wxl" SourcePath="u28" /><Payload Id="payqeWUzIVaEqjuRXN0z8ECC3Y4tCc" FilePath="3082\mbapreq.wxl" SourcePath="u29" /><Payload Id="paylfeHEjJSSTnNzY9QMZM2Ye3Ipy4" FilePath="mbapreq.dll" SourcePath="u31" /><Payload Id="payDPxs6uy8nbky.R7zhir2RRAfc.c" FilePath="WixToolset.Mba.Host.dll" SourcePath="u32" /><Payload Id="uxTxMXPVMXwQrPTMIGa5WGt93w0Ns" FilePath="BootstrapperApplicationData.xml" SourcePath="u33" /><Payload Id="uxYRbgitOs0K878jn5L_z7LdJ21KI" FilePath="BundleExtensionData.xml" SourcePath="u34" /></UX><Container Id="WixAttachedContainer" FileSize="15696370" Hash="0F9966B421400E481D394DB4C4D7F0F92548E5BEB79B98880C926E817E8C1F381EC8A17053E2E66AE7132A3C9ECE441629E6A1FB3452C5C9282280C40252F141" FilePath="MultipleBundlePackagesBundle.exe" AttachedIndex="1" Attached="yes" Primary="yes" /><Payload Id="NetFx48Web" FilePath="redist\ndp48-web.exe" FileSize="1439328" CertificateRootPublicKeyIdentifier="F49F9B33E25E33CCA0BFB15A62B7C29FFAB3880B" CertificateRootThumbprint="ABDCA79AF9DD48A0EA702AD45260B3C03093FB4B" DownloadUrl="https://go.microsoft.com/fwlink/?LinkId=2085155" Packaging="external" SourcePath="redist\ndp48-web.exe" /><Payload Id="PackageA" FilePath="BundleA.exe" FileSize="5241635" Hash="20E1AFF76DE4693CB2876DC6BCCA0152DB16BE49AEDE2CD581C03FC39AB89DEA12BC25CB435F06E4D7D2B4443CE8A8935D5E92E2E49A4981B60A273980E4B29B" Packaging="embedded" SourcePath="a0" Container="WixAttachedContainer" /><Payload Id="PackageB" FilePath="BundleB_x64.exe" FileSize="10450821" Hash="43A58873D61D6E0FA83F6C5266F2F05FEA9BC85D11C195493B7FD9F0B4AA799C1EFCB78D76DCED32124D2EC62A4E7114B62CDE6F0B87E42A7E28CDBB0DA0FF8E" Packaging="embedded" SourcePath="a1" Container="WixAttachedContainer" /><RollbackBoundary Id="WixDefaultBoundary" Vital="yes" Transaction="no" /><Registration Id="{35192ED0-C70A-49B2-9D12-3B1FA39B5E6F}" ExecutableName="MultipleBundlePackagesBundle.exe" PerMachine="yes" Tag="" Version="1.0.0.0" ProviderKey="{35192ED0-C70A-49B2-9D12-3B1FA39B5E6F}"><Arp Register="yes" DisplayName="~BundlePackageTests - MultipleBundlePackagesBundle" DisplayVersion="1.0.0.0" /></Registration><Chain><ExePackage Id="NetFx48Web" Cache="remove" CacheId="642721C60D52051C7F3434D8710FE3406A7CFE10B2B39E90EA847719ED1697D7C614F2DF44AD50412B1DF8C98DD78FDC57CA1D047D28C81AC158092E5FB18040" InstallSize="1439328" Size="1439328" PerMachine="yes" Permanent="yes" Vital="yes" RollbackBoundaryForward="WixDefaultBoundary" LogPathVariable="NetFx48WebLog" RollbackLogPathVariable="WixBundleRollbackLog_NetFx48Web" DetectCondition="NETFRAMEWORK45 >= 528040" InstallArguments="/q /norestart /log "[NetFx48WebLog].html"" UninstallArguments="" Uninstallable="no" RepairArguments="" Repairable="no" Protocol="netfx4"><PayloadRef Id="NetFx48Web" /></ExePackage><BundlePackage Id="PackageA" Cache="keep" CacheId="{B39CEE4D-CCD7-4797-BE3A-6613BD1DC4BE}v1.0.0.0" InstallSize="2169" Size="5241635" Version="1.0.0.0" PerMachine="yes" Permanent="no" Vital="yes" RepairCondition="0" LogPathVariable="WixBundleLog_PackageA" RollbackLogPathVariable="WixBundleRollbackLog_PackageA" BundleId="{B39CEE4D-CCD7-4797-BE3A-6613BD1DC4BE}" InstallArguments="" UninstallArguments="" RepairArguments="" SupportsBurnProtocol="yes" Win64="no"><Provides Key="{B39CEE4D-CCD7-4797-BE3A-6613BD1DC4BE}" Version="1.0.0.0" DisplayName="~BasicFunctionalityTests - BundleA" Imported="yes" /><RelatedBundle Id="{8C7E2C47-1EE7-4BBE-99A2-EAB7F3693F48}" Action="Upgrade" /><PayloadRef Id="PackageA" /></BundlePackage><BundlePackage Id="PackageB" Cache="keep" CacheId="{7506235A-7C59-4750-82C7-EB460A87ED3A}v1.0.0.0" InstallSize="1441497" Size="10450821" Version="1.0.0.0" PerMachine="yes" Permanent="no" Vital="yes" RollbackBoundaryBackward="WixDefaultBoundary" LogPathVariable="WixBundleLog_PackageB" RollbackLogPathVariable="WixBundleRollbackLog_PackageB" BundleId="{7506235A-7C59-4750-82C7-EB460A87ED3A}" InstallArguments="" UninstallArguments="" RepairArguments="" SupportsBurnProtocol="yes" Win64="yes"><Provides Key="{7506235A-7C59-4750-82C7-EB460A87ED3A}" Version="1.0.0.0" DisplayName="~BasicFunctionalityTests - BundleB_x64" Imported="yes" /><RelatedBundle Id="{79F45B7A-D990-46E4-819B-078D87C3321A}" Action="Upgrade" /><PayloadRef Id="PackageB" /></BundlePackage></Chain><CommandLine Variables="upperCase" /></BurnManifest> | ||
diff --git a/src/burn/test/BurnUnitTest/VariableTest.cpp b/src/burn/test/BurnUnitTest/VariableTest.cpp index d0361c0e..1d5fc6f3 100644 --- a/src/burn/test/BurnUnitTest/VariableTest.cpp +++ b/src/burn/test/BurnUnitTest/VariableTest.cpp | |||
@@ -388,6 +388,7 @@ namespace Bootstrapper | |||
388 | Assert::True(EvaluateFailureConditionHelper(&variables, L"1A")); | 388 | Assert::True(EvaluateFailureConditionHelper(&variables, L"1A")); |
389 | Assert::True(EvaluateFailureConditionHelper(&variables, L"*")); | 389 | Assert::True(EvaluateFailureConditionHelper(&variables, L"*")); |
390 | 390 | ||
391 | Assert::False(EvaluateFailureConditionHelper(&variables, L"0")); | ||
391 | Assert::True(EvaluateFailureConditionHelper(&variables, L"1 == 1")); | 392 | Assert::True(EvaluateFailureConditionHelper(&variables, L"1 == 1")); |
392 | } | 393 | } |
393 | finally | 394 | finally |