aboutsummaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
Diffstat (limited to 'src')
-rw-r--r--src/WixToolset.Core/Bind/FileFacade.cs2
-rw-r--r--src/WixToolset.Core/Compiler.cs10
-rw-r--r--src/test/WixToolsetTest.CoreIntegration/TestData/MultiFileCompressed/PackageComponents.wxs4
3 files changed, 8 insertions, 8 deletions
diff --git a/src/WixToolset.Core/Bind/FileFacade.cs b/src/WixToolset.Core/Bind/FileFacade.cs
index f0ce14ca..511f4aab 100644
--- a/src/WixToolset.Core/Bind/FileFacade.cs
+++ b/src/WixToolset.Core/Bind/FileFacade.cs
@@ -56,7 +56,7 @@ namespace WixToolset.Core.Bind
56 56
57 public int DiskId 57 public int DiskId
58 { 58 {
59 get => this.FileRow == null ? this.FileTuple.DiskId ?? 0 : this.FileRow.DiskId; 59 get => this.FileRow == null ? this.FileTuple.DiskId ?? 1 : this.FileRow.DiskId;
60 set 60 set
61 { 61 {
62 if (this.FileRow == null) 62 if (this.FileRow == null)
diff --git a/src/WixToolset.Core/Compiler.cs b/src/WixToolset.Core/Compiler.cs
index e2a5721e..56f6322a 100644
--- a/src/WixToolset.Core/Compiler.cs
+++ b/src/WixToolset.Core/Compiler.cs
@@ -5728,11 +5728,6 @@ namespace WixToolset.Core
5728 id = this.Core.CreateIdentifier("fil", directoryId, name ?? shortName); 5728 id = this.Core.CreateIdentifier("fil", directoryId, name ?? shortName);
5729 } 5729 }
5730 5730
5731 if (!this.compilingModule && CompilerConstants.IntegerNotSet == diskId)
5732 {
5733 diskId = 1; // default to first Media
5734 }
5735
5736 if (null != defaultVersion && null != companionFile) 5731 if (null != defaultVersion && null != companionFile)
5737 { 5732 {
5738 this.Core.Write(ErrorMessages.IllegalAttributeWithOtherAttribute(sourceLineNumbers, node.Name.LocalName, "DefaultVersion", "CompanionFile", companionFile)); 5733 this.Core.Write(ErrorMessages.IllegalAttributeWithOtherAttribute(sourceLineNumbers, node.Name.LocalName, "DefaultVersion", "CompanionFile", companionFile));
@@ -5914,6 +5909,11 @@ namespace WixToolset.Core
5914 } 5909 }
5915 } 5910 }
5916 5911
5912 if (CompilerConstants.IntegerNotSet != diskId)
5913 {
5914 this.Core.CreateSimpleReference(sourceLineNumbers, TupleDefinitions.Media, diskId.ToString(CultureInfo.InvariantCulture.NumberFormat));
5915 }
5916
5917 // If this component does not have a companion file this file is a possible keypath. 5917 // If this component does not have a companion file this file is a possible keypath.
5918 possibleKeyPath = null; 5918 possibleKeyPath = null;
5919 if (null == companionFile) 5919 if (null == companionFile)
diff --git a/src/test/WixToolsetTest.CoreIntegration/TestData/MultiFileCompressed/PackageComponents.wxs b/src/test/WixToolsetTest.CoreIntegration/TestData/MultiFileCompressed/PackageComponents.wxs
index 1a040fa3..82797ebe 100644
--- a/src/test/WixToolsetTest.CoreIntegration/TestData/MultiFileCompressed/PackageComponents.wxs
+++ b/src/test/WixToolsetTest.CoreIntegration/TestData/MultiFileCompressed/PackageComponents.wxs
@@ -3,10 +3,10 @@
3 <Fragment> 3 <Fragment>
4 <ComponentGroup Id="ProductComponents" Directory="INSTALLFOLDER"> 4 <ComponentGroup Id="ProductComponents" Directory="INSTALLFOLDER">
5 <Component> 5 <Component>
6 <File DiskId="1" Source="$(env.WINDIR)\Notepad.exe" /> 6 <File Source="$(env.WINDIR)\Notepad.exe" />
7 </Component> 7 </Component>
8 <Component> 8 <Component>
9 <File DiskId="2" Source="test.txt" /> 9 <File Source="test.txt" />
10 </Component> 10 </Component>
11 </ComponentGroup> 11 </ComponentGroup>
12 </Fragment> 12 </Fragment>