aboutsummaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
Diffstat (limited to 'src')
-rw-r--r--src/WixToolset.Core.WindowsInstaller/Bind/AssignMediaCommand.cs12
-rw-r--r--src/WixToolset.Core/Compiler.cs9
-rw-r--r--src/WixToolset.Core/Linker.cs1
-rw-r--r--src/test/WixToolsetTest.CoreIntegration/CabFixture.cs36
-rw-r--r--src/test/WixToolsetTest.CoreIntegration/MsiFixture.cs4
-rw-r--r--src/test/WixToolsetTest.CoreIntegration/TestData/Assembly/Package.wxs1
-rw-r--r--src/test/WixToolsetTest.CoreIntegration/TestData/BadIf/Package.wxs1
-rw-r--r--src/test/WixToolsetTest.CoreIntegration/TestData/ComplexExampleExtension/Package.wxs1
-rw-r--r--src/test/WixToolsetTest.CoreIntegration/TestData/Components/Package.wxs1
-rw-r--r--src/test/WixToolsetTest.CoreIntegration/TestData/ErrorsInUI/Package.wxs1
-rw-r--r--src/test/WixToolsetTest.CoreIntegration/TestData/ExampleExtension/Package.wxs1
-rw-r--r--src/test/WixToolsetTest.CoreIntegration/TestData/ForEach/Package.wxs1
-rw-r--r--src/test/WixToolsetTest.CoreIntegration/TestData/IncludePath/Package.wxs1
-rw-r--r--src/test/WixToolsetTest.CoreIntegration/TestData/InstanceTransform/Package.wxs1
-rw-r--r--src/test/WixToolsetTest.CoreIntegration/TestData/ManualUpgrade/Package.wxs2
-rw-r--r--src/test/WixToolsetTest.CoreIntegration/TestData/MultiFileCompressed/Package.wxs3
-rw-r--r--src/test/WixToolsetTest.CoreIntegration/TestData/MultiFileCompressed/PackageComponents.wxs4
-rw-r--r--src/test/WixToolsetTest.CoreIntegration/TestData/OverridableActions/Package.wxs1
-rw-r--r--src/test/WixToolsetTest.CoreIntegration/TestData/PatchFamilyFilter/Package.wxs1
-rw-r--r--src/test/WixToolsetTest.CoreIntegration/TestData/ProductWithComponentGroupRef/Product.wxs1
-rw-r--r--src/test/WixToolsetTest.CoreIntegration/TestData/ProgId/Package.wxs1
-rw-r--r--src/test/WixToolsetTest.CoreIntegration/TestData/SetProperty/Package.wxs1
-rw-r--r--src/test/WixToolsetTest.CoreIntegration/TestData/SimpleMerge/Package.wxs3
-rw-r--r--src/test/WixToolsetTest.CoreIntegration/TestData/SingleFile/Package.wxs1
-rw-r--r--src/test/WixToolsetTest.CoreIntegration/TestData/Variables/Package.wxs1
-rw-r--r--src/test/WixToolsetTest.CoreIntegration/TestData/Wixipl/Package.wxs1
-rw-r--r--src/test/WixToolsetTest.CoreIntegration/TestData/WixlibWithBinaries/Package.wxs1
27 files changed, 55 insertions, 37 deletions
diff --git a/src/WixToolset.Core.WindowsInstaller/Bind/AssignMediaCommand.cs b/src/WixToolset.Core.WindowsInstaller/Bind/AssignMediaCommand.cs
index b75956b4..773b3225 100644
--- a/src/WixToolset.Core.WindowsInstaller/Bind/AssignMediaCommand.cs
+++ b/src/WixToolset.Core.WindowsInstaller/Bind/AssignMediaCommand.cs
@@ -59,6 +59,18 @@ namespace WixToolset.Core.WindowsInstaller.Bind
59 throw new WixException(ErrorMessages.MediaTableCollision(null)); 59 throw new WixException(ErrorMessages.MediaTableCollision(null));
60 } 60 }
61 61
62 // If neither tuple is authored, default to a media template.
63 if (SectionType.Product == this.Section.Type && mediaTemplateTuples.Count == 0 && mediaTuples.Count == 0)
64 {
65 var mediaTemplate = new WixMediaTemplateTuple()
66 {
67 CabinetTemplate = "cab{0}.cab",
68 };
69
70 this.Section.AddTuple(mediaTemplate);
71 mediaTemplateTuples.Add(mediaTemplate);
72 }
73
62 // When building merge module, all the files go to "#MergeModule.CABinet". 74 // When building merge module, all the files go to "#MergeModule.CABinet".
63 if (SectionType.Module == this.Section.Type) 75 if (SectionType.Module == this.Section.Type)
64 { 76 {
diff --git a/src/WixToolset.Core/Compiler.cs b/src/WixToolset.Core/Compiler.cs
index 9681cb3f..ae7f7624 100644
--- a/src/WixToolset.Core/Compiler.cs
+++ b/src/WixToolset.Core/Compiler.cs
@@ -5870,7 +5870,6 @@ namespace WixToolset.Core
5870 } 5870 }
5871 } 5871 }
5872 5872
5873
5874 if (!this.Core.EncounteredError) 5873 if (!this.Core.EncounteredError)
5875 { 5874 {
5876 var patchAttributes = PatchAttributeType.None; 5875 var patchAttributes = PatchAttributeType.None;
@@ -5957,8 +5956,6 @@ namespace WixToolset.Core
5957 } 5956 }
5958 } 5957 }
5959 5958
5960 this.Core.CreateSimpleReference(sourceLineNumbers, TupleDefinitions.Media, diskId.ToString(CultureInfo.InvariantCulture.NumberFormat));
5961
5962 // If this component does not have a companion file this file is a possible keypath. 5959 // If this component does not have a companion file this file is a possible keypath.
5963 possibleKeyPath = null; 5960 possibleKeyPath = null;
5964 if (null == companionFile) 5961 if (null == companionFile)
@@ -7677,12 +7674,6 @@ namespace WixToolset.Core
7677 this.Core.Write(ErrorMessages.ExpectedAttribute(sourceLineNumbers, node.Name.LocalName, "SourceFile")); 7674 this.Core.Write(ErrorMessages.ExpectedAttribute(sourceLineNumbers, node.Name.LocalName, "SourceFile"));
7678 } 7675 }
7679 7676
7680 if (CompilerConstants.IntegerNotSet == diskId)
7681 {
7682 this.Core.Write(ErrorMessages.ExpectedAttributeInElementOrParent(sourceLineNumbers, node.Name.LocalName, "DiskId", "Directory"));
7683 diskId = CompilerConstants.IllegalInteger;
7684 }
7685
7686 foreach (var child in node.Elements()) 7677 foreach (var child in node.Elements())
7687 { 7678 {
7688 if (CompilerCore.WixNamespace == child.Name.Namespace) 7679 if (CompilerCore.WixNamespace == child.Name.Namespace)
diff --git a/src/WixToolset.Core/Linker.cs b/src/WixToolset.Core/Linker.cs
index fb1b2488..cbdb46d0 100644
--- a/src/WixToolset.Core/Linker.cs
+++ b/src/WixToolset.Core/Linker.cs
@@ -140,7 +140,6 @@ namespace WixToolset.Core
140#endif 140#endif
141 141
142 // First find the entry section and while processing all sections load all the symbols from all of the sections. 142 // First find the entry section and while processing all sections load all the symbols from all of the sections.
143 // sections.FindEntrySectionAndLoadSymbols(false, this, expectedOutputType, out entrySection, out allSymbols);
144 var find = new FindEntrySectionAndLoadSymbolsCommand(this.Messaging, sections, this.Context.ExpectedOutputType); 143 var find = new FindEntrySectionAndLoadSymbolsCommand(this.Messaging, sections, this.Context.ExpectedOutputType);
145 find.Execute(); 144 find.Execute();
146 145
diff --git a/src/test/WixToolsetTest.CoreIntegration/CabFixture.cs b/src/test/WixToolsetTest.CoreIntegration/CabFixture.cs
index 79471554..5aef148e 100644
--- a/src/test/WixToolsetTest.CoreIntegration/CabFixture.cs
+++ b/src/test/WixToolsetTest.CoreIntegration/CabFixture.cs
@@ -49,6 +49,42 @@ namespace WixToolsetTest.CoreIntegration
49 } 49 }
50 } 50 }
51 51
52 [Fact(Skip = "Sequence number of file from merge module is 0 but should be 1.")]
53 public void CabinetFilesSequencedCorrectlyUsingMergeModule()
54 {
55 var folder = TestData.Get(@"TestData\SimpleMerge");
56
57 using (var fs = new DisposableFileSystem())
58 {
59 var baseFolder = fs.GetFolder();
60 var intermediateFolder = Path.Combine(baseFolder, "obj");
61 var msiPath = Path.Combine(baseFolder, @"bin\test.msi");
62 var cabPath = Path.Combine(baseFolder, @"bin\cab1.cab");
63
64 var result = WixRunner.Execute(new[]
65 {
66 "build",
67 Path.Combine(folder, "Package.wxs"),
68 "-loc", Path.Combine(folder, "Package.en-us.wxl"),
69 "-bindpath", Path.Combine(folder, ".data"),
70 "-intermediateFolder", intermediateFolder,
71 "-o", msiPath
72 });
73
74 result.AssertSuccess();
75 Assert.True(File.Exists(cabPath));
76
77 var fileTable = Query.QueryDatabase(msiPath, new[] { "File" });
78 var fileRows = fileTable.Select(r => new FileRow(r)).OrderBy(f => f.Sequence).ToList();
79
80 Assert.Equal(new[] { 1 }, fileRows.Select(f => f.Sequence).ToArray());
81 Assert.Equal(new[] { "test.txt" }, fileRows.Select(f => f.Name).ToArray());
82
83 var files = Query.GetCabinetFiles(cabPath);
84 Assert.Equal(fileRows.Select(f => f.Id).ToArray(), files.Select(f => f.Name).ToArray());
85 }
86 }
87
52 private class FileRow 88 private class FileRow
53 { 89 {
54 public FileRow(string row) 90 public FileRow(string row)
diff --git a/src/test/WixToolsetTest.CoreIntegration/MsiFixture.cs b/src/test/WixToolsetTest.CoreIntegration/MsiFixture.cs
index 69258ae4..fbfebc5b 100644
--- a/src/test/WixToolsetTest.CoreIntegration/MsiFixture.cs
+++ b/src/test/WixToolsetTest.CoreIntegration/MsiFixture.cs
@@ -164,7 +164,6 @@ namespace WixToolsetTest.CoreIntegration
164 "build", 164 "build",
165 Path.Combine(folder, "Package.wxs"), 165 Path.Combine(folder, "Package.wxs"),
166 Path.Combine(folder, "PackageComponents.wxs"), 166 Path.Combine(folder, "PackageComponents.wxs"),
167 "-d", "MediaTemplateCompressionLevel",
168 "-loc", Path.Combine(folder, "Package.en-us.wxl"), 167 "-loc", Path.Combine(folder, "Package.en-us.wxl"),
169 "-bindpath", Path.Combine(folder, "data"), 168 "-bindpath", Path.Combine(folder, "data"),
170 "-intermediateFolder", intermediateFolder, 169 "-intermediateFolder", intermediateFolder,
@@ -174,7 +173,8 @@ namespace WixToolsetTest.CoreIntegration
174 result.AssertSuccess(); 173 result.AssertSuccess();
175 174
176 Assert.True(File.Exists(Path.Combine(intermediateFolder, @"bin\test.msi"))); 175 Assert.True(File.Exists(Path.Combine(intermediateFolder, @"bin\test.msi")));
177 Assert.True(File.Exists(Path.Combine(intermediateFolder, @"bin\cab1.cab"))); 176 Assert.True(File.Exists(Path.Combine(intermediateFolder, @"bin\example1.cab")));
177 Assert.True(File.Exists(Path.Combine(intermediateFolder, @"bin\example2.cab")));
178 Assert.True(File.Exists(Path.Combine(intermediateFolder, @"bin\test.wixpdb"))); 178 Assert.True(File.Exists(Path.Combine(intermediateFolder, @"bin\test.wixpdb")));
179 } 179 }
180 } 180 }
diff --git a/src/test/WixToolsetTest.CoreIntegration/TestData/Assembly/Package.wxs b/src/test/WixToolsetTest.CoreIntegration/TestData/Assembly/Package.wxs
index d9a2a34e..dbce4c71 100644
--- a/src/test/WixToolsetTest.CoreIntegration/TestData/Assembly/Package.wxs
+++ b/src/test/WixToolsetTest.CoreIntegration/TestData/Assembly/Package.wxs
@@ -4,7 +4,6 @@
4 <Package InstallerVersion="200" Compressed="no" InstallScope="perMachine" /> 4 <Package InstallerVersion="200" Compressed="no" InstallScope="perMachine" />
5 5
6 <MajorUpgrade DowngradeErrorMessage="!(loc.DowngradeError)" /> 6 <MajorUpgrade DowngradeErrorMessage="!(loc.DowngradeError)" />
7 <MediaTemplate />
8 7
9 <Feature Id="ProductFeature" Title="!(loc.FeatureTitle)"> 8 <Feature Id="ProductFeature" Title="!(loc.FeatureTitle)">
10 <ComponentGroupRef Id="ProductComponents" /> 9 <ComponentGroupRef Id="ProductComponents" />
diff --git a/src/test/WixToolsetTest.CoreIntegration/TestData/BadIf/Package.wxs b/src/test/WixToolsetTest.CoreIntegration/TestData/BadIf/Package.wxs
index 73577ce5..c1cf55c2 100644
--- a/src/test/WixToolsetTest.CoreIntegration/TestData/BadIf/Package.wxs
+++ b/src/test/WixToolsetTest.CoreIntegration/TestData/BadIf/Package.wxs
@@ -4,7 +4,6 @@
4 <Package InstallerVersion="200" Compressed="no" InstallScope="perMachine" /> 4 <Package InstallerVersion="200" Compressed="no" InstallScope="perMachine" />
5 5
6 <MajorUpgrade DowngradeErrorMessage="!(loc.DowngradeError)" /> 6 <MajorUpgrade DowngradeErrorMessage="!(loc.DowngradeError)" />
7 <MediaTemplate />
8 7
9 <Feature Id="ProductFeature" Title="!(loc.FeatureTitle)"> 8 <Feature Id="ProductFeature" Title="!(loc.FeatureTitle)">
10 <ComponentGroupRef Id="ProductComponents.x86" /> 9 <ComponentGroupRef Id="ProductComponents.x86" />
diff --git a/src/test/WixToolsetTest.CoreIntegration/TestData/ComplexExampleExtension/Package.wxs b/src/test/WixToolsetTest.CoreIntegration/TestData/ComplexExampleExtension/Package.wxs
index 0e8e9795..f3dd9a02 100644
--- a/src/test/WixToolsetTest.CoreIntegration/TestData/ComplexExampleExtension/Package.wxs
+++ b/src/test/WixToolsetTest.CoreIntegration/TestData/ComplexExampleExtension/Package.wxs
@@ -4,7 +4,6 @@
4 <Package InstallerVersion="200" Compressed="no" InstallScope="perMachine" /> 4 <Package InstallerVersion="200" Compressed="no" InstallScope="perMachine" />
5 5
6 <MajorUpgrade DowngradeErrorMessage="!(loc.DowngradeError)" /> 6 <MajorUpgrade DowngradeErrorMessage="!(loc.DowngradeError)" />
7 <MediaTemplate />
8 7
9 <Property Id="ExampleProperty" Value="$(ex.Test)" /> 8 <Property Id="ExampleProperty" Value="$(ex.Test)" />
10 9
diff --git a/src/test/WixToolsetTest.CoreIntegration/TestData/Components/Package.wxs b/src/test/WixToolsetTest.CoreIntegration/TestData/Components/Package.wxs
index 6da3dcbe..28d564e2 100644
--- a/src/test/WixToolsetTest.CoreIntegration/TestData/Components/Package.wxs
+++ b/src/test/WixToolsetTest.CoreIntegration/TestData/Components/Package.wxs
@@ -4,7 +4,6 @@
4 <Package InstallerVersion="200" Compressed="no" InstallScope="perMachine" /> 4 <Package InstallerVersion="200" Compressed="no" InstallScope="perMachine" />
5 5
6 <MajorUpgrade DowngradeErrorMessage="!(loc.DowngradeError)" /> 6 <MajorUpgrade DowngradeErrorMessage="!(loc.DowngradeError)" />
7 <MediaTemplate />
8 7
9 <Feature Id="ProductFeature" Title="!(loc.FeatureTitle)"> 8 <Feature Id="ProductFeature" Title="!(loc.FeatureTitle)">
10 <ComponentGroupRef Id="ProductComponents" /> 9 <ComponentGroupRef Id="ProductComponents" />
diff --git a/src/test/WixToolsetTest.CoreIntegration/TestData/ErrorsInUI/Package.wxs b/src/test/WixToolsetTest.CoreIntegration/TestData/ErrorsInUI/Package.wxs
index a4c01d7e..59eeb027 100644
--- a/src/test/WixToolsetTest.CoreIntegration/TestData/ErrorsInUI/Package.wxs
+++ b/src/test/WixToolsetTest.CoreIntegration/TestData/ErrorsInUI/Package.wxs
@@ -4,7 +4,6 @@
4 <Package InstallerVersion="200" Compressed="no" InstallScope="perMachine" /> 4 <Package InstallerVersion="200" Compressed="no" InstallScope="perMachine" />
5 5
6 <MajorUpgrade DowngradeErrorMessage="!(loc.DowngradeError)" /> 6 <MajorUpgrade DowngradeErrorMessage="!(loc.DowngradeError)" />
7 <MediaTemplate />
8 7
9 <CustomAction Id="CanWeReferenceAnError_YesWeCan" Error="1234" /> 8 <CustomAction Id="CanWeReferenceAnError_YesWeCan" Error="1234" />
10 <CustomAction Id="TextErrorsWorkOKToo" Error="If you see this, something went wrong." /> 9 <CustomAction Id="TextErrorsWorkOKToo" Error="If you see this, something went wrong." />
diff --git a/src/test/WixToolsetTest.CoreIntegration/TestData/ExampleExtension/Package.wxs b/src/test/WixToolsetTest.CoreIntegration/TestData/ExampleExtension/Package.wxs
index bff5f609..f20f5f73 100644
--- a/src/test/WixToolsetTest.CoreIntegration/TestData/ExampleExtension/Package.wxs
+++ b/src/test/WixToolsetTest.CoreIntegration/TestData/ExampleExtension/Package.wxs
@@ -4,7 +4,6 @@
4 <Package InstallerVersion="200" Compressed="no" InstallScope="perMachine" /> 4 <Package InstallerVersion="200" Compressed="no" InstallScope="perMachine" />
5 5
6 <MajorUpgrade DowngradeErrorMessage="!(loc.DowngradeError)" /> 6 <MajorUpgrade DowngradeErrorMessage="!(loc.DowngradeError)" />
7 <MediaTemplate />
8 7
9 <Property Id="ExampleProperty" Value="$(ex.Test)" /> 8 <Property Id="ExampleProperty" Value="$(ex.Test)" />
10 9
diff --git a/src/test/WixToolsetTest.CoreIntegration/TestData/ForEach/Package.wxs b/src/test/WixToolsetTest.CoreIntegration/TestData/ForEach/Package.wxs
index 4bc7e2a4..3bd14fbb 100644
--- a/src/test/WixToolsetTest.CoreIntegration/TestData/ForEach/Package.wxs
+++ b/src/test/WixToolsetTest.CoreIntegration/TestData/ForEach/Package.wxs
@@ -4,7 +4,6 @@
4 <Package InstallerVersion="200" Compressed="no" InstallScope="perMachine" /> 4 <Package InstallerVersion="200" Compressed="no" InstallScope="perMachine" />
5 5
6 <MajorUpgrade DowngradeErrorMessage="!(loc.DowngradeError)" /> 6 <MajorUpgrade DowngradeErrorMessage="!(loc.DowngradeError)" />
7 <MediaTemplate />
8 7
9 <Feature Id="ProductFeature" Title="!(loc.FeatureTitle)"> 8 <Feature Id="ProductFeature" Title="!(loc.FeatureTitle)">
10 <ComponentGroupRef Id="ProductComponents.x86" /> 9 <ComponentGroupRef Id="ProductComponents.x86" />
diff --git a/src/test/WixToolsetTest.CoreIntegration/TestData/IncludePath/Package.wxs b/src/test/WixToolsetTest.CoreIntegration/TestData/IncludePath/Package.wxs
index 8deab961..59c8b2b3 100644
--- a/src/test/WixToolsetTest.CoreIntegration/TestData/IncludePath/Package.wxs
+++ b/src/test/WixToolsetTest.CoreIntegration/TestData/IncludePath/Package.wxs
@@ -5,7 +5,6 @@
5 <Package InstallerVersion="200" Compressed="no" InstallScope="perMachine" /> 5 <Package InstallerVersion="200" Compressed="no" InstallScope="perMachine" />
6 6
7 <MajorUpgrade DowngradeErrorMessage="!(loc.DowngradeError)" /> 7 <MajorUpgrade DowngradeErrorMessage="!(loc.DowngradeError)" />
8 <MediaTemplate />
9 8
10 <Feature Id="ProductFeature" Title="!(loc.FeatureTitle)"> 9 <Feature Id="ProductFeature" Title="!(loc.FeatureTitle)">
11 <ComponentGroupRef Id="ProductComponents" /> 10 <ComponentGroupRef Id="ProductComponents" />
diff --git a/src/test/WixToolsetTest.CoreIntegration/TestData/InstanceTransform/Package.wxs b/src/test/WixToolsetTest.CoreIntegration/TestData/InstanceTransform/Package.wxs
index 9c529668..e55b3ec6 100644
--- a/src/test/WixToolsetTest.CoreIntegration/TestData/InstanceTransform/Package.wxs
+++ b/src/test/WixToolsetTest.CoreIntegration/TestData/InstanceTransform/Package.wxs
@@ -4,7 +4,6 @@
4 <Package InstallerVersion="200" Compressed="no" InstallScope="perMachine" /> 4 <Package InstallerVersion="200" Compressed="no" InstallScope="perMachine" />
5 5
6 <MajorUpgrade DowngradeErrorMessage="!(loc.DowngradeError)" /> 6 <MajorUpgrade DowngradeErrorMessage="!(loc.DowngradeError)" />
7 <MediaTemplate />
8 7
9 <Property Id="INSTANCEPROPERTY" Secure="yes" /> 8 <Property Id="INSTANCEPROPERTY" Secure="yes" />
10 9
diff --git a/src/test/WixToolsetTest.CoreIntegration/TestData/ManualUpgrade/Package.wxs b/src/test/WixToolsetTest.CoreIntegration/TestData/ManualUpgrade/Package.wxs
index 38125b57..025aaaa3 100644
--- a/src/test/WixToolsetTest.CoreIntegration/TestData/ManualUpgrade/Package.wxs
+++ b/src/test/WixToolsetTest.CoreIntegration/TestData/ManualUpgrade/Package.wxs
@@ -12,8 +12,6 @@
12 <RemoveExistingProducts After="InstallValidate" /> 12 <RemoveExistingProducts After="InstallValidate" />
13 </InstallExecuteSequence> 13 </InstallExecuteSequence>
14 14
15 <MediaTemplate />
16
17 <Feature Id="ProductFeature" Title="!(loc.FeatureTitle)"> 15 <Feature Id="ProductFeature" Title="!(loc.FeatureTitle)">
18 <ComponentGroupRef Id="ProductComponents" /> 16 <ComponentGroupRef Id="ProductComponents" />
19 </Feature> 17 </Feature>
diff --git a/src/test/WixToolsetTest.CoreIntegration/TestData/MultiFileCompressed/Package.wxs b/src/test/WixToolsetTest.CoreIntegration/TestData/MultiFileCompressed/Package.wxs
index 0b743c81..44b8c2b5 100644
--- a/src/test/WixToolsetTest.CoreIntegration/TestData/MultiFileCompressed/Package.wxs
+++ b/src/test/WixToolsetTest.CoreIntegration/TestData/MultiFileCompressed/Package.wxs
@@ -6,7 +6,8 @@
6 <MajorUpgrade DowngradeErrorMessage="!(loc.DowngradeError)" /> 6 <MajorUpgrade DowngradeErrorMessage="!(loc.DowngradeError)" />
7 7
8 <?ifndef MediaTemplateCompressionLevel?> 8 <?ifndef MediaTemplateCompressionLevel?>
9 <Media Id="1" Cabinet="example.cab" /> 9 <Media Id="1" Cabinet="example1.cab" />
10 <Media Id="2" Cabinet="example2.cab" />
10 <?elseif $(MediaTemplateCompressionLevel) = ""?> 11 <?elseif $(MediaTemplateCompressionLevel) = ""?>
11 <MediaTemplate /> 12 <MediaTemplate />
12 <?else?> 13 <?else?>
diff --git a/src/test/WixToolsetTest.CoreIntegration/TestData/MultiFileCompressed/PackageComponents.wxs b/src/test/WixToolsetTest.CoreIntegration/TestData/MultiFileCompressed/PackageComponents.wxs
index 82797ebe..1a040fa3 100644
--- a/src/test/WixToolsetTest.CoreIntegration/TestData/MultiFileCompressed/PackageComponents.wxs
+++ b/src/test/WixToolsetTest.CoreIntegration/TestData/MultiFileCompressed/PackageComponents.wxs
@@ -3,10 +3,10 @@
3 <Fragment> 3 <Fragment>
4 <ComponentGroup Id="ProductComponents" Directory="INSTALLFOLDER"> 4 <ComponentGroup Id="ProductComponents" Directory="INSTALLFOLDER">
5 <Component> 5 <Component>
6 <File Source="$(env.WINDIR)\Notepad.exe" /> 6 <File DiskId="1" Source="$(env.WINDIR)\Notepad.exe" />
7 </Component> 7 </Component>
8 <Component> 8 <Component>
9 <File Source="test.txt" /> 9 <File DiskId="2" Source="test.txt" />
10 </Component> 10 </Component>
11 </ComponentGroup> 11 </ComponentGroup>
12 </Fragment> 12 </Fragment>
diff --git a/src/test/WixToolsetTest.CoreIntegration/TestData/OverridableActions/Package.wxs b/src/test/WixToolsetTest.CoreIntegration/TestData/OverridableActions/Package.wxs
index db773d17..cc873a62 100644
--- a/src/test/WixToolsetTest.CoreIntegration/TestData/OverridableActions/Package.wxs
+++ b/src/test/WixToolsetTest.CoreIntegration/TestData/OverridableActions/Package.wxs
@@ -5,7 +5,6 @@
5 <Package InstallerVersion="200" Compressed="no" InstallScope="perMachine" /> 5 <Package InstallerVersion="200" Compressed="no" InstallScope="perMachine" />
6 6
7 <MajorUpgrade DowngradeErrorMessage="!(loc.DowngradeError)" /> 7 <MajorUpgrade DowngradeErrorMessage="!(loc.DowngradeError)" />
8 <MediaTemplate />
9 8
10 <InstallExecuteSequence> 9 <InstallExecuteSequence>
11 <ValidateProductID Suppress="yes" /> 10 <ValidateProductID Suppress="yes" />
diff --git a/src/test/WixToolsetTest.CoreIntegration/TestData/PatchFamilyFilter/Package.wxs b/src/test/WixToolsetTest.CoreIntegration/TestData/PatchFamilyFilter/Package.wxs
index 2657797f..4baeb85b 100644
--- a/src/test/WixToolsetTest.CoreIntegration/TestData/PatchFamilyFilter/Package.wxs
+++ b/src/test/WixToolsetTest.CoreIntegration/TestData/PatchFamilyFilter/Package.wxs
@@ -5,7 +5,6 @@
5 <Package InstallScope='perMachine' /> 5 <Package InstallScope='perMachine' />
6 6
7 <MajorUpgrade DowngradeErrorMessage='Newer version already installed.' /> 7 <MajorUpgrade DowngradeErrorMessage='Newer version already installed.' />
8 <MediaTemplate />
9 8
10 <Directory Id='TARGETDIR' Name='SourceDir'> 9 <Directory Id='TARGETDIR' Name='SourceDir'>
11 <Directory Id='ProgramFilesFolder'> 10 <Directory Id='ProgramFilesFolder'>
diff --git a/src/test/WixToolsetTest.CoreIntegration/TestData/ProductWithComponentGroupRef/Product.wxs b/src/test/WixToolsetTest.CoreIntegration/TestData/ProductWithComponentGroupRef/Product.wxs
index e0e5345a..b2f22b7d 100644
--- a/src/test/WixToolsetTest.CoreIntegration/TestData/ProductWithComponentGroupRef/Product.wxs
+++ b/src/test/WixToolsetTest.CoreIntegration/TestData/ProductWithComponentGroupRef/Product.wxs
@@ -4,7 +4,6 @@
4 <Package InstallerVersion="500" Compressed="no" InstallScope="perMachine" /> 4 <Package InstallerVersion="500" Compressed="no" InstallScope="perMachine" />
5 5
6 <MajorUpgrade DowngradeErrorMessage="A newer version of [ProductName] is already installed." /> 6 <MajorUpgrade DowngradeErrorMessage="A newer version of [ProductName] is already installed." />
7 <MediaTemplate />
8 7
9 <Feature Id="ProductFeature" Title="MsiPackageTitle"> 8 <Feature Id="ProductFeature" Title="MsiPackageTitle">
10 <ComponentGroupRef Id="ProductComponents" /> 9 <ComponentGroupRef Id="ProductComponents" />
diff --git a/src/test/WixToolsetTest.CoreIntegration/TestData/ProgId/Package.wxs b/src/test/WixToolsetTest.CoreIntegration/TestData/ProgId/Package.wxs
index d4b53cd6..388a271e 100644
--- a/src/test/WixToolsetTest.CoreIntegration/TestData/ProgId/Package.wxs
+++ b/src/test/WixToolsetTest.CoreIntegration/TestData/ProgId/Package.wxs
@@ -4,7 +4,6 @@
4 <Package InstallerVersion="200" Compressed="no" InstallScope="perMachine" /> 4 <Package InstallerVersion="200" Compressed="no" InstallScope="perMachine" />
5 5
6 <MajorUpgrade DowngradeErrorMessage="!(loc.DowngradeError)" /> 6 <MajorUpgrade DowngradeErrorMessage="!(loc.DowngradeError)" />
7 <MediaTemplate />
8 7
9 <Feature Id="ProductFeature" Title="!(loc.FeatureTitle)"> 8 <Feature Id="ProductFeature" Title="!(loc.FeatureTitle)">
10 <ComponentGroupRef Id="ProductComponents" /> 9 <ComponentGroupRef Id="ProductComponents" />
diff --git a/src/test/WixToolsetTest.CoreIntegration/TestData/SetProperty/Package.wxs b/src/test/WixToolsetTest.CoreIntegration/TestData/SetProperty/Package.wxs
index eb907569..879fad35 100644
--- a/src/test/WixToolsetTest.CoreIntegration/TestData/SetProperty/Package.wxs
+++ b/src/test/WixToolsetTest.CoreIntegration/TestData/SetProperty/Package.wxs
@@ -4,7 +4,6 @@
4 <Package InstallerVersion="200" Compressed="no" InstallScope="perMachine" /> 4 <Package InstallerVersion="200" Compressed="no" InstallScope="perMachine" />
5 5
6 <MajorUpgrade DowngradeErrorMessage="!(loc.DowngradeError)" /> 6 <MajorUpgrade DowngradeErrorMessage="!(loc.DowngradeError)" />
7 <MediaTemplate />
8 7
9 <Feature Id="ProductFeature" Title="!(loc.FeatureTitle)"> 8 <Feature Id="ProductFeature" Title="!(loc.FeatureTitle)">
10 <ComponentGroupRef Id="ProductComponents" /> 9 <ComponentGroupRef Id="ProductComponents" />
diff --git a/src/test/WixToolsetTest.CoreIntegration/TestData/SimpleMerge/Package.wxs b/src/test/WixToolsetTest.CoreIntegration/TestData/SimpleMerge/Package.wxs
index 303e2ba8..b04c5d1a 100644
--- a/src/test/WixToolsetTest.CoreIntegration/TestData/SimpleMerge/Package.wxs
+++ b/src/test/WixToolsetTest.CoreIntegration/TestData/SimpleMerge/Package.wxs
@@ -4,7 +4,6 @@
4 <Package InstallerVersion="200" Compressed="yes" InstallScope="perMachine" /> 4 <Package InstallerVersion="200" Compressed="yes" InstallScope="perMachine" />
5 5
6 <MajorUpgrade DowngradeErrorMessage="!(loc.DowngradeError)" /> 6 <MajorUpgrade DowngradeErrorMessage="!(loc.DowngradeError)" />
7 <MediaTemplate />
8 7
9 <Feature Id="ProductFeature" Title="!(loc.FeatureTitle)"> 8 <Feature Id="ProductFeature" Title="!(loc.FeatureTitle)">
10 <MergeRef Id="TestMsm" /> 9 <MergeRef Id="TestMsm" />
@@ -16,7 +15,7 @@
16 <Directory Id="ProgramFilesFolder"> 15 <Directory Id="ProgramFilesFolder">
17 <Directory Id="INSTALLFOLDER" Name="MsiPackage"> 16 <Directory Id="INSTALLFOLDER" Name="MsiPackage">
18 <!-- --> 17 <!-- -->
19 <Merge Id="TestMsm" Language="1033" SourceFile="test.msm" DiskId="1" /> 18 <Merge Id="TestMsm" Language="1033" SourceFile="test.msm" />
20 </Directory> 19 </Directory>
21 </Directory> 20 </Directory>
22 </Directory> 21 </Directory>
diff --git a/src/test/WixToolsetTest.CoreIntegration/TestData/SingleFile/Package.wxs b/src/test/WixToolsetTest.CoreIntegration/TestData/SingleFile/Package.wxs
index 6da3dcbe..28d564e2 100644
--- a/src/test/WixToolsetTest.CoreIntegration/TestData/SingleFile/Package.wxs
+++ b/src/test/WixToolsetTest.CoreIntegration/TestData/SingleFile/Package.wxs
@@ -4,7 +4,6 @@
4 <Package InstallerVersion="200" Compressed="no" InstallScope="perMachine" /> 4 <Package InstallerVersion="200" Compressed="no" InstallScope="perMachine" />
5 5
6 <MajorUpgrade DowngradeErrorMessage="!(loc.DowngradeError)" /> 6 <MajorUpgrade DowngradeErrorMessage="!(loc.DowngradeError)" />
7 <MediaTemplate />
8 7
9 <Feature Id="ProductFeature" Title="!(loc.FeatureTitle)"> 8 <Feature Id="ProductFeature" Title="!(loc.FeatureTitle)">
10 <ComponentGroupRef Id="ProductComponents" /> 9 <ComponentGroupRef Id="ProductComponents" />
diff --git a/src/test/WixToolsetTest.CoreIntegration/TestData/Variables/Package.wxs b/src/test/WixToolsetTest.CoreIntegration/TestData/Variables/Package.wxs
index 57c24f57..8d49c30e 100644
--- a/src/test/WixToolsetTest.CoreIntegration/TestData/Variables/Package.wxs
+++ b/src/test/WixToolsetTest.CoreIntegration/TestData/Variables/Package.wxs
@@ -17,7 +17,6 @@
17 <Package InstallerVersion="200" Compressed="no" InstallScope="perMachine" /> 17 <Package InstallerVersion="200" Compressed="no" InstallScope="perMachine" />
18 18
19 <MajorUpgrade DowngradeErrorMessage="!(loc.DowngradeError)" /> 19 <MajorUpgrade DowngradeErrorMessage="!(loc.DowngradeError)" />
20 <MediaTemplate />
21 20
22 <Feature Id="ProductFeature" Title="!(loc.FeatureTitle)"> 21 <Feature Id="ProductFeature" Title="!(loc.FeatureTitle)">
23 <ComponentGroupRef Id="ProductComponents" /> 22 <ComponentGroupRef Id="ProductComponents" />
diff --git a/src/test/WixToolsetTest.CoreIntegration/TestData/Wixipl/Package.wxs b/src/test/WixToolsetTest.CoreIntegration/TestData/Wixipl/Package.wxs
index 15807698..00a80fca 100644
--- a/src/test/WixToolsetTest.CoreIntegration/TestData/Wixipl/Package.wxs
+++ b/src/test/WixToolsetTest.CoreIntegration/TestData/Wixipl/Package.wxs
@@ -4,7 +4,6 @@
4 <Package InstallerVersion="200" Compressed="no" InstallScope="perMachine" /> 4 <Package InstallerVersion="200" Compressed="no" InstallScope="perMachine" />
5 5
6 <MajorUpgrade DowngradeErrorMessage="!(loc.DowngradeError)" /> 6 <MajorUpgrade DowngradeErrorMessage="!(loc.DowngradeError)" />
7 <MediaTemplate />
8 7
9 <CustomAction Id="CAFromExtension" BinaryKey="BinFromWir" DllEntry="DoesntExist" /> 8 <CustomAction Id="CAFromExtension" BinaryKey="BinFromWir" DllEntry="DoesntExist" />
10 9
diff --git a/src/test/WixToolsetTest.CoreIntegration/TestData/WixlibWithBinaries/Package.wxs b/src/test/WixToolsetTest.CoreIntegration/TestData/WixlibWithBinaries/Package.wxs
index 85dcb695..4c36f3cc 100644
--- a/src/test/WixToolsetTest.CoreIntegration/TestData/WixlibWithBinaries/Package.wxs
+++ b/src/test/WixToolsetTest.CoreIntegration/TestData/WixlibWithBinaries/Package.wxs
@@ -4,7 +4,6 @@
4 <Package InstallerVersion="200" Compressed="no" InstallScope="perMachine" /> 4 <Package InstallerVersion="200" Compressed="no" InstallScope="perMachine" />
5 5
6 <MajorUpgrade DowngradeErrorMessage="!(loc.DowngradeError)" /> 6 <MajorUpgrade DowngradeErrorMessage="!(loc.DowngradeError)" />
7 <MediaTemplate />
8 7
9 <Feature Id="ProductFeature" Title="!(loc.FeatureTitle)"> 8 <Feature Id="ProductFeature" Title="!(loc.FeatureTitle)">
10 <ComponentGroupRef Id="ProductComponents" /> 9 <ComponentGroupRef Id="ProductComponents" />