aboutsummaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
Diffstat (limited to 'src')
-rw-r--r--src/be/utilbe.vcxproj6
-rw-r--r--src/ca/FormatFiles.cpp2
-rw-r--r--src/ca/XmlConfig.cpp11
-rw-r--r--src/ca/XmlFile.cpp7
-rw-r--r--src/ca/utilca.vcxproj4
5 files changed, 11 insertions, 19 deletions
diff --git a/src/be/utilbe.vcxproj b/src/be/utilbe.vcxproj
index c02b51a5..683b376a 100644
--- a/src/be/utilbe.vcxproj
+++ b/src/be/utilbe.vcxproj
@@ -69,9 +69,9 @@
69 </ItemGroup> 69 </ItemGroup>
70 70
71 <ItemGroup> 71 <ItemGroup>
72 <PackageReference Include="WixToolset.BextUtil" Version="4.0.55" /> 72 <PackageReference Include="WixToolset.BextUtil" Version="4.0.58" />
73 <PackageReference Include="WixToolset.BootstrapperCore.Native" Version="4.0.110" /> 73 <PackageReference Include="WixToolset.BootstrapperCore.Native" Version="4.0.141" />
74 <PackageReference Include="WixToolset.DUtil" Version="4.0.70" /> 74 <PackageReference Include="WixToolset.DUtil" Version="4.0.72" />
75 <PackageReference Include="Microsoft.SourceLink.GitHub" Version="1.0.0" /> 75 <PackageReference Include="Microsoft.SourceLink.GitHub" Version="1.0.0" />
76 <PackageReference Include="Nerdbank.GitVersioning" Version="3.3.37" /> 76 <PackageReference Include="Nerdbank.GitVersioning" Version="3.3.37" />
77 </ItemGroup> 77 </ItemGroup>
diff --git a/src/ca/FormatFiles.cpp b/src/ca/FormatFiles.cpp
index 464b92d6..d1533999 100644
--- a/src/ca/FormatFiles.cpp
+++ b/src/ca/FormatFiles.cpp
@@ -203,7 +203,7 @@ extern "C" UINT __stdcall WixExecFormatFiles(
203 hr = FileGetTime(sczFilePath, NULL, NULL, &filetime); 203 hr = FileGetTime(sczFilePath, NULL, NULL, &filetime);
204 ExitOnFailure(hr, "Failed to get modified time of file : %ls", sczFilePath); 204 ExitOnFailure(hr, "Failed to get modified time of file : %ls", sczFilePath);
205 205
206 hr = FileWrite(sczFilePath, FILE_ATTRIBUTE_NORMAL, pbData, static_cast<DWORD>(cbData), NULL); 206 hr = FileWrite(sczFilePath, FILE_ATTRIBUTE_NORMAL, pbData, cbData, NULL);
207 ExitOnFailure(hr, "Failed to write file content: %ls", sczFilePath); 207 ExitOnFailure(hr, "Failed to write file content: %ls", sczFilePath);
208 208
209 hr = FileSetTime(sczFilePath, NULL, NULL, &filetime); 209 hr = FileSetTime(sczFilePath, NULL, NULL, &filetime);
diff --git a/src/ca/XmlConfig.cpp b/src/ca/XmlConfig.cpp
index 959f95b0..a1ec9d6f 100644
--- a/src/ca/XmlConfig.cpp
+++ b/src/ca/XmlConfig.cpp
@@ -171,7 +171,7 @@ static HRESULT ReadXmlConfigTable(
171 ExitOnFailure(hr, "failed to get component name for Wix4XmlConfig: %ls", (*ppxfcTail)->wzId); 171 ExitOnFailure(hr, "failed to get component name for Wix4XmlConfig: %ls", (*ppxfcTail)->wzId);
172 172
173 // Get the component's state 173 // Get the component's state
174 if (0 < lstrlenW(pwzData)) 174 if (pwzData && *pwzData)
175 { 175 {
176 hr = StringCchCopyW((*ppxfcTail)->wzComponent, countof((*ppxfcTail)->wzComponent), pwzData); 176 hr = StringCchCopyW((*ppxfcTail)->wzComponent, countof((*ppxfcTail)->wzComponent), pwzData);
177 ExitOnFailure(hr, "failed to copy component id"); 177 ExitOnFailure(hr, "failed to copy component id");
@@ -1041,7 +1041,6 @@ extern "C" UINT __stdcall ExecXmlConfigRollback(
1041 LPWSTR pwzFileName = NULL; 1041 LPWSTR pwzFileName = NULL;
1042 LPBYTE pbData = NULL; 1042 LPBYTE pbData = NULL;
1043 DWORD_PTR cbData = 0; 1043 DWORD_PTR cbData = 0;
1044 DWORD cbDataWritten = 0;
1045 1044
1046 FILETIME ft; 1045 FILETIME ft;
1047 1046
@@ -1099,12 +1098,8 @@ extern "C" UINT __stdcall ExecXmlConfigRollback(
1099 ExitOnInvalidHandleWithLastError(hFile, hr, "failed to open file: %ls", pwzFileName); 1098 ExitOnInvalidHandleWithLastError(hFile, hr, "failed to open file: %ls", pwzFileName);
1100 1099
1101 // Write out the old data 1100 // Write out the old data
1102 if (!::WriteFile(hFile, pbData, (DWORD)cbData, &cbDataWritten, NULL)) 1101 hr = FileWriteHandle(hFile, pbData, cbData);
1103 { 1102 ExitOnFailure(hr, "failed to write to file: %ls", pwzFileName);
1104 ExitOnLastError(hr, "failed to write to file: %ls", pwzFileName);
1105 }
1106
1107 Assert(cbData == cbDataWritten);
1108 1103
1109 ReleaseFile(hFile); 1104 ReleaseFile(hFile);
1110 1105
diff --git a/src/ca/XmlFile.cpp b/src/ca/XmlFile.cpp
index 95f18411..04a4ae98 100644
--- a/src/ca/XmlFile.cpp
+++ b/src/ca/XmlFile.cpp
@@ -854,7 +854,6 @@ extern "C" UINT __stdcall ExecXmlFileRollback(
854 LPWSTR pwzFileName = NULL; 854 LPWSTR pwzFileName = NULL;
855 LPBYTE pbData = NULL; 855 LPBYTE pbData = NULL;
856 DWORD_PTR cbData = 0; 856 DWORD_PTR cbData = 0;
857 DWORD cbDataWritten = 0;
858 857
859 FILETIME ft; 858 FILETIME ft;
860 859
@@ -913,10 +912,8 @@ extern "C" UINT __stdcall ExecXmlFileRollback(
913 ExitOnInvalidHandleWithLastError(hFile, hr, "failed to open file: %ls", pwzFileName); 912 ExitOnInvalidHandleWithLastError(hFile, hr, "failed to open file: %ls", pwzFileName);
914 913
915 // Write out the old data 914 // Write out the old data
916 if (!::WriteFile(hFile, pbData, (DWORD)cbData, &cbDataWritten, NULL)) 915 hr = FileWriteHandle(hFile, pbData, cbData);
917 ExitOnLastError(hr, "failed to write to file: %ls", pwzFileName); 916 ExitOnFailure(hr, "failed to write to file: %ls", pwzFileName);
918
919 Assert(cbData == cbDataWritten);
920 917
921 ReleaseFile(hFile); 918 ReleaseFile(hFile);
922 919
diff --git a/src/ca/utilca.vcxproj b/src/ca/utilca.vcxproj
index 88f35673..7b64db95 100644
--- a/src/ca/utilca.vcxproj
+++ b/src/ca/utilca.vcxproj
@@ -96,8 +96,8 @@
96 </ItemGroup> 96 </ItemGroup>
97 97
98 <ItemGroup> 98 <ItemGroup>
99 <PackageReference Include="WixToolset.Dutil" Version="4.0.70" /> 99 <PackageReference Include="WixToolset.Dutil" Version="4.0.72" />
100 <PackageReference Include="WixToolset.WcaUtil" Version="4.0.18" /> 100 <PackageReference Include="WixToolset.WcaUtil" Version="4.0.19" />
101 <PackageReference Include="Microsoft.SourceLink.GitHub" Version="1.0.0" /> 101 <PackageReference Include="Microsoft.SourceLink.GitHub" Version="1.0.0" />
102 <PackageReference Include="Nerdbank.GitVersioning" Version="3.3.37" /> 102 <PackageReference Include="Nerdbank.GitVersioning" Version="3.3.37" />
103 </ItemGroup> 103 </ItemGroup>