| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
| |
Fixes https://github.com/wixtoolset/issues/issues/8977
|
| |
|
|
|
|
|
|
|
|
| |
- Move ext\ unit tests to MSTest.
- MSBuildify ext projects with MSTest execution.
- Fork test support projects for MSTest:
- WixInternal.TestSupport
- WixInternal.Core.TestPackage
|
|
|
|
| |
Implements https://github.com/wixtoolset/issues/issues/7622
|
|
|
|
|
|
|
|
|
|
| |
to investigate Wix4Group / Wix6Group decompiler interactions).
Fix up Msmq Util dependency by bringing it into Build explicitly, as per
NetFx extension.
Signed-off-by: Bevan Weiss <bevan.weiss@gmail.com>
|
|
|
|
|
|
|
|
| |
Decompiler not being broad enough in where it looks for indexes.
Carry forward both Group and Wix4Group just for good measure.
Signed-off-by: Bevan Weiss <bevan.weiss@gmail.com>
|
|
|
|
|
|
|
| |
Needed fix up for Group decompiler to work correctly, adding to Index,
and fixing where the Group name column is located.
Signed-off-by: Bevan Weiss <bevan.weiss@gmail.com>
|
|
|
|
|
|
|
|
| |
And updated decompiler to Wix4 table names etc in line with firewall CA.
Fixes wixtoolset/issues#8902
Signed-off-by: Bevan Weiss <bevan.weiss@gmail.com>
|
|
|
|
|
|
|
|
|
|
|
| |
Lines in WixUI are too short for standard dialog widths. Increase them by
3 pixels.
Fixes wixtoolset/issues#2691
Signed-off-by: Bevan Weiss <bevan.weiss@gmail.com>
|
|
|
|
|
|
|
|
|
| |
Microsoft documentation doesn't list Level 0 as being a valid group info
level to request for NetLocalGroupGetInfo. So we should only be requesting
Level 1 instead.
Signed-off-by: Bevan Weiss <bevan.weiss@gmail.com>
|
| |
|
|
|
|
| |
Signed-off-by: Bevan Weiss <bevan.weiss@gmail.com>
|
|
|
|
|
|
| |
Since there's no reason to not have them identical where practical.
Signed-off-by: Bevan Weiss <bevan.weiss@gmail.com>
|
| |
|
|
|
|
|
|
| |
Fixups to a few test cases.
Signed-off-by: Bevan Weiss <bevan.weiss@gmail.com>
|
| |
|
|
|
|
| |
Signed-off-by: Bevan Weiss <bevan.weiss@gmail.com>
|
|
|
|
|
|
|
|
|
|
| |
Local group membership Add/Remove working, however with
BUILTIN local system groups .NET doesn't appear to locate them as either
groups nor basic security Principals. Still needs work to fix the test
for nested groups. Ideally with some way to test for domain groups.
Signed-off-by: Bevan Weiss <bevan.weiss@gmail.com>
|
|
|
|
| |
Signed-off-by: Bevan Weiss <bevan.weiss@gmail.com>
|
|
|
|
|
|
| |
Fixes wixtoolset/issues#1520
Signed-off-by: Bevan Weiss <bevan.weiss@gmail.com>
|
|
|
|
| |
Fixes https://github.com/wixtoolset/issues/issues/8913
|
| |
|
|
|
|
|
|
|
| |
The "bundle id" always had more in common with the PackageCode from the Windows
Installer. With the introduction of an actual Id attribute on the Bundle
element, there is potential for confusion, so there is finally real motivation
to rename "bundle id" to "bundle code".
|
|
|
|
|
|
|
|
| |
Add `WixUI/ExtendedPathValidation="yes"` to opt-in.
Removed the WIXUI_DONTVALIDATEPATH runtime opt-out.
Fixes https://github.com/wixtoolset/issues/issues/8718
Relies on https://github.com/wixtoolset/wix/pull/563
|
|
|
|
| |
Fixes https://github.com/wixtoolset/issues/issues/8580
|
|
|
|
| |
Fixes 8673
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Table names updated for Wix4 prefix.
Custom action names similarly updated.
Table names Wix4ComPlusUserInApplicationRole,
Wix4ComPlusGroupInApplicationRole and Wix4ComPlusApplicationRoleProperty
had to be shortened to fit within MSI 31 character table name limit.
Migrated from fixed GUID for RegistrationHelper to use CLSIDFromProgID in
an attempt to fix behaviour under .NET 4+ DLLs.
Added setting of Partition enable if a Partition is configured in authoring,
new Windows config has Partitions disabled by default, and they don't work
at all under Windows workstation (non-server) versions.
Added a new Runtime condition for `RequireWindowsServer` which will skip
execution of Runtime test on workstation/desktop OSes, since COM+ Partitions
only work correctly under Windows Server.
Quite a lot of basic typos fixed also.
Signed-off-by: Bevan Weiss <bevan.weiss@gmail.com>
|
|
|
|
|
|
| |
(Simplified).
Signed-off-by: Bevan Weiss <bevan.weiss@gmail.com>
|
|
|
|
|
|
|
|
| |
Added translations in line with existing translations. I'm sure they'll
suffice for now, Google translate makes sense of them anyway.
Signed-off-by: Bevan Weiss <bevan.weiss@gmail.com>
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
When ::GetFileAttributesW returns 0xFFFFFFFF it means
'Invalid File/Folder'
So we should return a matching error message.
To avoid confusing invalid paths with junctions (in error message)
Unfortunately the constant for this is not defined.
So just define it here as though it would be.
Signed-off-by: Bevan Weiss <bevan.weiss@gmail.com>
|
|
|
|
|
|
|
|
| |
Contains no files etc to verify that Remove action can still occur without
other elements bringing in the RemoveFiles Standard Action
Signed-off-by: Bevan Weiss <bevan.weiss@gmail.com>
|
|
|
|
|
|
|
|
|
| |
Fix up lack of WIX CUSTOM_ACTION_DECORATION wrappers
Add new RuntimeTest skipper for Server Features / Optional Features.
Signed-off-by: Bevan Weiss <bevan.weiss@gmail.com>
|
|
|
|
| |
Fixes 8638
|
|
|
|
|
|
|
|
| |
Generally, clean up the handling of getting the domain from a server name by
centralizing and simplifying it behind an improved GetDomainFromServerName()
based on the buggy GetServerName().
Fixes 8576
|
|
|
|
| |
Fixes 8624
|
| |
|
| |
|
| |
|
|
|
|
|
|
| |
v143 output is compatible back to VS2017 (at least).
Fixes https://github.com/wixtoolset/issues/issues/8211.
|
| |
|
| |
|
| |
|
|
|
|
| |
See https://github.com/wixtoolset/issues/issues/7862.
|
|
|
|
| |
Fixes 8091
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When deleting directories recursively, an elevated custom action
following junctions in a user-writable location could recurse into
any directory, including some that you might not want to be deleted.
Therefore, avoid recursing into directories that are actually
junctions (aka "reparse points").
This applies to:
- The RemoveFoldersEx custom action (which doesn't actually do deletions
but would instruct elevated MSI to delete on your behalf).
- DTF's custom action runner.
|
|
|
|
|
| |
Take this breaking change opportunity to simplify the header files used by
BA devs.
|
|
|
|
|
|
| |
It's a formatted field but was too short.
Fixes https://github.com/wixtoolset/issues/issues/8043.
|
| |
|