1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
|
// Copyright (c) .NET Foundation and contributors. All rights reserved. Licensed under the Microsoft Reciprocal License. See LICENSE.TXT file in the project root for full license information.
#include "precomp.h"
namespace Microsoft
{
namespace Tools
{
namespace WindowsInstallerXml
{
namespace Test
{
namespace Bootstrapper
{
using namespace System;
using namespace System::IO;
using namespace Xunit;
public ref class ApprovedExeTest : BurnUnitTest
{
public:
ApprovedExeTest(BurnTestFixture^ fixture) : BurnUnitTest(fixture)
{
}
[Fact]
void ApprovedExesVerifyPFilesTest()
{
HRESULT hr = S_OK;
BURN_CACHE cache = { };
BURN_ENGINE_COMMAND internalCommand = { };
BURN_VARIABLES variables = { };
LPWSTR scz = NULL;
LPWSTR scz2 = NULL;
try
{
hr = VariableInitialize(&variables);
NativeAssert::Succeeded(hr, L"Failed to initialize variables.");
hr = CacheInitialize(&cache, &internalCommand);
NativeAssert::Succeeded(hr, "Failed to initialize cache.");
hr = VariableGetString(&variables, L"ProgramFilesFolder", &scz);
NativeAssert::Succeeded(hr, "Failed to get variable ProgramFilesFolder.");
hr = PathConcat(scz, L"a.exe", &scz2);
NativeAssert::Succeeded(hr, "Failed to combine paths");
hr = ApprovedExesVerifySecureLocation(&cache, &variables, scz2, 0, NULL);
NativeAssert::Succeeded(hr, "Failed to test secure location under ProgramFilesFolder");
Assert::True((hr == S_OK), "Path under ProgramFilesFolder was expected to be safe");
}
finally
{
ReleaseStr(internalCommand.sczEngineWorkingDirectory);
ReleaseStr(scz);
ReleaseStr(scz2);
CacheUninitialize(&cache);
VariablesUninitialize(&variables);
}
}
[Fact]
void ApprovedExesVerifyPFilesWithRelativeTest()
{
HRESULT hr = S_OK;
BURN_CACHE cache = { };
BURN_ENGINE_COMMAND internalCommand = { };
BURN_VARIABLES variables = { };
LPWSTR scz = NULL;
LPWSTR scz2 = NULL;
try
{
hr = VariableInitialize(&variables);
NativeAssert::Succeeded(hr, L"Failed to initialize variables.");
hr = CacheInitialize(&cache, &internalCommand);
NativeAssert::Succeeded(hr, "Failed to initialize cache.");
cache.fPerMachineCacheRootVerified = TRUE;
cache.fOriginalPerMachineCacheRootVerified = TRUE;
hr = VariableGetString(&variables, L"ProgramFilesFolder", &scz);
NativeAssert::Succeeded(hr, "Failed to get variable ProgramFilesFolder.");
hr = PathConcat(scz, L"..\\a.exe", &scz2);
NativeAssert::Succeeded(hr, "Failed to combine paths");
hr = ApprovedExesVerifySecureLocation(&cache, &variables, scz2, 0, NULL);
NativeAssert::Succeeded(hr, "Failed to test secure location under ProgramFilesFolder");
Assert::True((hr == S_FALSE), "Path pretending to be under ProgramFilesFolder was expected to be unsafe");
}
finally
{
ReleaseStr(internalCommand.sczEngineWorkingDirectory);
ReleaseStr(scz);
ReleaseStr(scz2);
CacheUninitialize(&cache);
VariablesUninitialize(&variables);
}
}
[Fact]
void ApprovedExesVerifyPFiles64Test()
{
HRESULT hr = S_OK;
BURN_CACHE cache = { };
BURN_ENGINE_COMMAND internalCommand = { };
BURN_VARIABLES variables = { };
LPWSTR scz = NULL;
LPWSTR scz2 = NULL;
try
{
hr = VariableInitialize(&variables);
NativeAssert::Succeeded(hr, L"Failed to initialize variables.");
hr = CacheInitialize(&cache, &internalCommand);
NativeAssert::Succeeded(hr, "Failed to initialize cache.");
hr = VariableGetString(&variables, L"ProgramFiles64Folder", &scz);
NativeAssert::Succeeded(hr, "Failed to get variable ProgramFiles64Folder.");
hr = PathConcat(scz, L"a.exe", &scz2);
NativeAssert::Succeeded(hr, "Failed to combine paths");
hr = ApprovedExesVerifySecureLocation(&cache, &variables, scz2, 0, NULL);
NativeAssert::Succeeded(hr, "Failed to test secure location under ProgramFiles64Folder");
Assert::True((hr == S_OK), "Path under ProgramFiles64Folder was expected to be safe");
}
finally
{
ReleaseStr(internalCommand.sczEngineWorkingDirectory);
ReleaseStr(scz);
ReleaseStr(scz2);
CacheUninitialize(&cache);
VariablesUninitialize(&variables);
}
}
[Fact]
void ApprovedExesVerifySys64FolderTest()
{
HRESULT hr = S_OK;
BURN_CACHE cache = { };
BURN_ENGINE_COMMAND internalCommand = { };
BURN_VARIABLES variables = { };
LPWSTR scz = NULL;
LPWSTR scz2 = NULL;
try
{
hr = VariableInitialize(&variables);
NativeAssert::Succeeded(hr, L"Failed to initialize variables.");
hr = CacheInitialize(&cache, &internalCommand);
NativeAssert::Succeeded(hr, "Failed to initialize cache.");
cache.fPerMachineCacheRootVerified = TRUE;
cache.fOriginalPerMachineCacheRootVerified = TRUE;
hr = VariableGetString(&variables, L"System64Folder", &scz);
NativeAssert::Succeeded(hr, "Failed to get variable System64Folder.");
hr = PathConcat(scz, L"a.exe", &scz2);
NativeAssert::Succeeded(hr, "Failed to combine paths");
hr = ApprovedExesVerifySecureLocation(&cache, &variables, scz2, 0, NULL);
NativeAssert::Succeeded(hr, "Failed to test secure location under System64Folder");
Assert::True((hr == S_FALSE), "Path under System64Folder was expected to be unsafe");
}
finally
{
ReleaseStr(internalCommand.sczEngineWorkingDirectory);
ReleaseStr(scz);
ReleaseStr(scz2);
CacheUninitialize(&cache);
VariablesUninitialize(&variables);
}
}
[Fact]
void ApprovedExesVerifySys64Rundll32UnsafeTest()
{
HRESULT hr = S_OK;
BURN_CACHE cache = { };
BURN_ENGINE_COMMAND internalCommand = { };
BURN_VARIABLES variables = { };
LPWSTR scz = NULL;
LPWSTR scz2 = NULL;
LPWSTR szArgs = NULL;
try
{
hr = VariableInitialize(&variables);
NativeAssert::Succeeded(hr, L"Failed to initialize variables.");
hr = CacheInitialize(&cache, &internalCommand);
NativeAssert::Succeeded(hr, "Failed to initialize cache.");
cache.fPerMachineCacheRootVerified = TRUE;
cache.fOriginalPerMachineCacheRootVerified = TRUE;
hr = VariableGetString(&variables, L"System64Folder", &scz);
NativeAssert::Succeeded(hr, "Failed to get variable System64Folder.");
hr = PathConcat(scz, L"rundll32.exe", &scz2);
NativeAssert::Succeeded(hr, "Failed to combine paths");
hr = ApprovedExesVerifySecureLocation(&cache, &variables, scz2, 1, const_cast<LPCWSTR*>(&scz2));
NativeAssert::Succeeded(hr, "Failed to test secure location under System64Folder");
Assert::True((hr == S_FALSE), "Path under System64Folder was expected to be unsafe for rundll32 target");
}
finally
{
ReleaseStr(internalCommand.sczEngineWorkingDirectory);
ReleaseStr(scz);
ReleaseStr(scz2);
ReleaseStr(szArgs);
CacheUninitialize(&cache);
VariablesUninitialize(&variables);
}
}
[Fact]
void ApprovedExesVerifySys64Rundll32SafeTest()
{
HRESULT hr = S_OK;
BURN_CACHE cache = { };
BURN_ENGINE_COMMAND internalCommand = { };
BURN_VARIABLES variables = { };
LPWSTR scz = NULL;
LPWSTR scz2 = NULL;
LPWSTR scz3 = NULL;
try
{
hr = VariableInitialize(&variables);
NativeAssert::Succeeded(hr, L"Failed to initialize variables.");
hr = CacheInitialize(&cache, &internalCommand);
NativeAssert::Succeeded(hr, "Failed to initialize cache.");
cache.fPerMachineCacheRootVerified = TRUE;
cache.fOriginalPerMachineCacheRootVerified = TRUE;
// System64Folder
hr = VariableGetString(&variables, L"System64Folder", &scz);
NativeAssert::Succeeded(hr, "Failed to get variable System64Folder.");
hr = PathConcat(scz, L"rundll32.exe", &scz2);
NativeAssert::Succeeded(hr, "Failed to combine paths");
hr = VariableGetString(&variables, L"ProgramFiles64Folder", &scz);
NativeAssert::Succeeded(hr, "Failed to get variable ProgramFiles64Folder.");
hr = PathConcat(scz, L"a.dll", &scz3);
NativeAssert::Succeeded(hr, "Failed to combine paths");
hr = ApprovedExesVerifySecureLocation(&cache, &variables, scz2, 1, const_cast<LPCWSTR*>(&scz3));
NativeAssert::Succeeded(hr, "Failed to test secure location under ProgramFiles64Folder for System64Folder/rundll32 target");
Assert::True((hr == S_OK), "Path under ProgramFiles64Folder was expected to be safe for System64Folder/rundll32 target");
hr = PathConcat(scz, L"a.dll,somthing else", &scz3);
NativeAssert::Succeeded(hr, "Failed to combine paths");
hr = ApprovedExesVerifySecureLocation(&cache, &variables, scz2, 1, const_cast<LPCWSTR*>(&scz3));
NativeAssert::Succeeded(hr, "Failed to test secure location under ProgramFiles64Folder for rundll32 target");
Assert::True((hr == S_OK), "Path under ProgramFiles64Folder was expected to be safe for System64Folder/rundll32 target");
// SystemFolder
hr = VariableGetString(&variables, L"SystemFolder", &scz);
NativeAssert::Succeeded(hr, "Failed to get variable System64Folder.");
hr = PathConcat(scz, L"rundll32.exe", &scz2);
NativeAssert::Succeeded(hr, "Failed to combine paths");
hr = ApprovedExesVerifySecureLocation(&cache, &variables, scz2, 1, const_cast<LPCWSTR*>(&scz3));
NativeAssert::Succeeded(hr, "Failed to test secure location under ProgramFiles64Folder for SystemFolder/rundll32 target");
Assert::True((hr == S_OK), "Path under ProgramFiles64Folder was expected to be safe for SystemFolder/rundll32 target");
// Sysnative
hr = PathSystemWindowsSubdirectory(L"SysNative\\", &scz);
NativeAssert::Succeeded(hr, "Failed to get SysNative Folder.");
hr = PathConcat(scz, L"rundll32.exe", &scz2);
NativeAssert::Succeeded(hr, "Failed to combine paths");
hr = ApprovedExesVerifySecureLocation(&cache, &variables, scz2, 1, const_cast<LPCWSTR*>(&scz3));
NativeAssert::Succeeded(hr, "Failed to test secure location under ProgramFiles64Folder for Sysnative/rundll32 target");
Assert::True((hr == S_OK), "Path under ProgramFiles64Folder was expected to be safe for Sysnative/rundll32 target");
}
finally
{
ReleaseStr(internalCommand.sczEngineWorkingDirectory);
ReleaseStr(scz);
ReleaseStr(scz2);
ReleaseStr(scz3);
CacheUninitialize(&cache);
VariablesUninitialize(&variables);
}
}
};
}
}
}
}
}
|
