diff options
author | deraadt <> | 2014-06-07 22:23:12 +0000 |
---|---|---|
committer | deraadt <> | 2014-06-07 22:23:12 +0000 |
commit | de48c77a08514ed654e05e710444452ffab6d0aa (patch) | |
tree | 974be678316c95805c95e61416f75191d5b20bbe /src/lib/libssl/ssl_locl.h | |
parent | ffcbdf8a3fda87b9b0d60403b8bda401683595e1 (diff) | |
download | openbsd-de48c77a08514ed654e05e710444452ffab6d0aa.tar.gz openbsd-de48c77a08514ed654e05e710444452ffab6d0aa.tar.bz2 openbsd-de48c77a08514ed654e05e710444452ffab6d0aa.zip |
http://git.openssl.org/gitweb/?p=openssl.git;a=commitdiff;h=2016265dfbab162ec30718b5e7480add42598158
Don't know the full story, but it looks like a "can't do random
perfectly, so do it god awful" problem was found in 2013, and
replaced with "only do it badly if a flag is set". New flags
(SSL_MODE_SEND_SERVERHELLO_TIME and SSL_MODE_SEND_SERVERHELLO_TIME)
were added [Ben Laurie?] to support the old scheme of "use time_t
for first 4 bytes of the random buffer".
Nothing uses these flags [ecosystem scan by sthen]
Fully discourage use of these flags in the future by removing
support & definition of them. The buflen < 4 check is also interesting,
because no entropy would be returned. No callers passed such small
buffers.
ok miod sthen
Diffstat (limited to 'src/lib/libssl/ssl_locl.h')
-rw-r--r-- | src/lib/libssl/ssl_locl.h | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/src/lib/libssl/ssl_locl.h b/src/lib/libssl/ssl_locl.h index 4aa2911da7..a96402ec5c 100644 --- a/src/lib/libssl/ssl_locl.h +++ b/src/lib/libssl/ssl_locl.h | |||
@@ -621,7 +621,6 @@ void ssl_set_cert_masks(CERT *c, const SSL_CIPHER *cipher); | |||
621 | STACK_OF(SSL_CIPHER) *ssl_get_ciphers_by_id(SSL *s); | 621 | STACK_OF(SSL_CIPHER) *ssl_get_ciphers_by_id(SSL *s); |
622 | int ssl_verify_alarm_type(long type); | 622 | int ssl_verify_alarm_type(long type); |
623 | void ssl_load_ciphers(void); | 623 | void ssl_load_ciphers(void); |
624 | int ssl_fill_hello_random(SSL *s, int server, unsigned char *field, int len); | ||
625 | 624 | ||
626 | const SSL_CIPHER *ssl3_get_cipher_by_char(const unsigned char *p); | 625 | const SSL_CIPHER *ssl3_get_cipher_by_char(const unsigned char *p); |
627 | int ssl3_put_cipher_by_char(const SSL_CIPHER *c, unsigned char *p); | 626 | int ssl3_put_cipher_by_char(const SSL_CIPHER *c, unsigned char *p); |