summaryrefslogtreecommitdiff
path: root/src/lib/libcrypto/err/err.c (follow)
Commit message (Collapse)AuthorAgeFilesLines
* Assert assumption on CRYPTO_THREADIDtb2024-11-021-1/+2
| | | | | | | | This type has been opaque for a while, and nobody should be able to call this function with id != NULL. If they do, we want to know and it should be noisy. suggested by/ok jsing
* Inline last uses of CRYPTO_THREADID in err/tb2024-11-021-14/+7
| | | | | | | | This is another Thorpian obfuscation scheme hiding nasty casts of pthread_t to unsigned long and comparing them. We can do this in a less underhanded way by calling the portable functions directly. ok jsing
* err.c: zap stray spacetb2024-10-111-2/+2
|
* Apply some style(9) and tidy some comments.jsing2024-10-111-62/+73
|
* Remove pointless locking from err_build_SYS_str_reasons().jsing2024-10-111-20/+2
| | | | | | | | err_build_SYS_str_reasons() is only called during initialisation, under pthread_once(). As such, there is no need to grab CRYPTO_LOCK_ERR or check for reentrant calls. ok tb@
* Convert err_clear_data() and err_clear() from macros to functions.jsing2024-10-111-23/+25
| | | | ok tb@
* Remove unused typedef for ERR_FNS.jsing2024-10-111-3/+1
|
* Add err_ prefix to build_SYS_str_reasons().jsing2024-10-111-3/+3
|
* Make ERR_str_{libraries,reasons,functs}[] const.jsing2024-10-111-12/+18
| | | | | | | | Provide err_load_const_strings(), which takes a const ERR_STRING_DATA * and does not perform a library error value fixup. Make ERR_str_*[] tables const. ok tb@
* Add ERR_LIB_SYS to the error values in ERR_str_functs[].jsing2024-10-111-12/+12
| | | | | | | | This is currently added via err_load_strings(), which means ERR_str_functs[] cannot be made const. Adding ERR_LIB_SYS means the fixup becomes unnecessary. ok tb@
* Reorder functions.jsing2024-10-021-297/+286
| | | | | Reorder functions so that things are somewhat more logical, moving internal functions towards the top (and removing now unnecessary prototypes).
* Remove err_fns and associated machinery.jsing2024-10-021-142/+65
| | | | | | | | | | | | Like all good OpenSSL code, errors was built to be completely extensible. Thankfully, the ERR_{get,set}_implementation() functions were removed in r1.127 of err.c, which means that the extensibility can no longer be used. Take the first of many steps to clean up this code - remove err_fns and associated machinery, calling functions directly. Rename so that we have an 'err_' prefix rather than 'int_' (or nothing). ok joshua@ tb@
* Remove ERR_add_{,v}data()tb2024-08-311-32/+1
| | | | | | Another unused bit of legacy API... ok beck jsing
* Hide remaining unused ERR functions in err.hbeck2024-07-091-1/+3
| | | | ok tb@
* libcrypto: constify most error string tablestb2024-06-241-17/+30
| | | | | | | | | | | | | | | | | | | | | | | | | | These constitute the bulk of the remaining global mutable state in libcrypto. This commit moves most of them into data.rel.ro, leaving out ERR_str_{functs,libraries,reasons} (which require a slightly different approach) and SYS_str_reasons which is populated on startup. The main observation is that if ERR_load_strings() is called with a 0 lib argument, the ERR_STRING_DATA argument is not actually modified. We could use this fact to cast away const on the caller side and be done with it. We can make this cleaner by adding a helper ERR_load_const_strings() which explicitly avoids the assignment to str->error overriding the error code already set in the table. In order for this to work, we need to sprinkle some const in err/err.c. CMS called ERR_load_strings() with non-0 lib argument, but this didn't actually modify the error data since it ored in the value already stored in the table. Annoyingly, we need to cast const away once, namely in the call to lh_insert() in int_err_set_item(). Fixing this would require changing the public API and is going to be tricky since it requires that the LHASH_DOALL_FN_* types adjust. ok jsing
* Make CRYPTO_THREADID opaquetb2024-03-021-1/+3
| | | | | | | | With ERR_STATE out of the way, we can make CRYPTO_THREADID opaque. The type is still accessed by used public API, but some of the public API can also go away. ok jsing
* Remove ERR_get_statetb2024-03-021-3/+15
| | | | | | | | | The ERR_STATE struct is an unused implementation detail of the horrific error stack code. It is the last public consumer of CRYPTO_THREAD internals. Make this and its accessor internal so we can make the CRYPTO_THREAD struct opaque. ok jsing
* Remove last calls to CRYPTO_{push,pop}_info()tb2024-02-241-9/+3
| | | | | | | These don't do anything but return 0 and will be garbage collected in the upcoming bump. ok jsing
* err.c: fix incorrect line wrappingtb2024-02-241-5/+5
|
* Remove more ERR crufttb2023-07-281-23/+1
| | | | | | | Ever wondered how many entries populate the various err hashes? Me neither. Remove this garbage. ok jsing
* Remove ERR_{get,set}_implementation()tb2023-07-281-28/+3
| | | | | | | Much like ex_data, applications can make the library use their own error stack implementation. Well, except as of right now they no longer can. ok jsing
* Unbreak the namespace build after a broken mk.conf and tool misfire hadbeck2023-07-071-3/+3
| | | | | | | | me aliasing symbols not in the headers I was procesing. This unbreaks the namespace build so it will pass again ok tb@
* Hide symbols in hkdf, evp, err, ecdsa, and ecbeck2023-07-071-1/+34
| | | | | | (part 2 of commit) ok jsing@
* Move a few functions out of OPENSSL_NO_DEPRECATEDtb2023-04-091-3/+1
| | | | | | | | | | | | | | | | | | | | | | | | Geoff Thorpe added OPENSSL_NO_DEPRECATED nearly two decades ago. The hope was that at some point some functions can be dropped. Most of the functions marked deprecated are actually unused nowadays but unfortunately some of them are still used in the ecosystem. Move them out of OPENSSL_NO_DEPRECATED so we can define it without breaking the consumers in the next bump. ERR_remove_state() is still used by a dozen or so ports. This isn't a big deal since it is just a stupid wrapper for the not quite as deprecated ERR_remove_thread_state(). It's not worth patching these ports. Annoyingly, {DH,DSA}_generate_parameters() and RSA_generate_key() are still used. They "make use" of the old-style BN_GENCB callback, which is therefore more difficult to remove - in case you don't know know: that's the thing responsible for printing pretty '.', '+' and '*' when you generate keys. Most annoyingly, DH_generate_parameters() was added to rust-openssl in 2020 for "advanced DH support". This is very unfortunate since cargo bundles a rust-openssl and updates it only every few years or so. As a consequence we're going to be stuck with this nonsense for a good while. ok beck jsing
* Avoid errno is EINVAL after OpenSSL initializationjan2023-03-271-1/+5
| | | | ok tb@
* spelling fixes; from paul tagliamontejmc2022-12-261-2/+2
| | | | | | | i removed the arithmetics -> arithmetic changes, as i felt they were not clearly correct ok tb
* Provide ERR_R_INIT_FAIL.jsing2022-08-291-1/+2
| | | | | | Needed for an upcoming change. ok tb@
* Provide err_clear_last_constant_time() as a way of clearing an error fromjsing2019-10-171-1/+22
| | | | | | | | | | the top of the error stack in constant time. This will be used by upcoming RSA changes. From OpenSSL 1.1.1d. ok inoguchi@ tb@
* KNF: move two opening curly braces of function bodies to their own linestb2018-04-031-2/+3
|
* Bring in compatibility for OpenSSL 1.1 style init functions.beck2018-03-171-2/+30
| | | | | | | | | This adds OPENSSL_init_crypto and OPENSSL_init_ssl, as well thread safety modifications for the existing LibreSSL init functions. The initialization routines are called automatically by the normal entry points into the library, as in newer OpenSSL ok jsing@, nits by tb@ and deraadt@
* Mark ERR_add_error_data and ERR_add_error_vdata as not for internal use,beck2017-02-201-9/+10
| | | | | and document ERR_asprintf_error_data as their replacement. ok jsing@, ingo@
* Revert previous; the implementation is incorrect since it assumes that thejsing2017-02-071-17/+4
| | | | | provided error code matches the error that is currently on the top of the error stack.
* Add file and line to the LibreSSL error strings sine we are no longer inbeck2017-02-071-4/+17
| | | | | | | 1989, VMS, or MS/DOS and we all run Brobdingnagian C compilers that have can now be counted on to achieve this level of sophistication nearly everywhere. ok jsing@
* Send the function codes from the error functions to the bit bucket,beck2017-01-291-2/+2
| | | | | | as was done earlier in libssl. Thanks inoguchi@ for noticing libssl had more reacharounds into this. ok jsing@ inoguchi@
* GOST crypto algorithms (well, most of them), ported from the removed GOSTmiod2014-11-091-1/+2
| | | | | | | | | | | | engine to regular EVP citizens, contributed by Dmitry Eremin-Solenikov; libcrypto bits only for now. This is a verbatim import of Dmitry's work, and does not compile in this state; the forthcoming commits will address these issues. None of the GOST code is enabled in libcrypto yet, for it still gets compiled with OPENSSL_NO_GOST defined. However, the public header gost.h will be installed.
* compile with c89 (code / decl ordering); from Joakim.Tjernlund@transmode.sederaadt2014-10-051-2/+3
| | | | ok miod
* constify strerror return valuebcook2014-08-241-2/+2
| | | | | | | | | There is no intention to modify the string returned by strerror and doing so is forbidden by the standard. from Jonas 'Sortie' Termansen ok tedu@ deraadt@
* Only import cryptlib.h in the four source files that actually need it.jsing2014-07-111-5/+4
| | | | | | | | Remove the openssl public includes from cryptlib.h and add a small number of includes into the source files that actually need them. While here, also sort/group/tidy the includes. ok beck@ miod@
* Explicitly include <openssl/opensslconf.h> in every file that referencesjsing2014-07-101-2/+5
| | | | | | | | | an OPENSSL_NO_* define. This avoids relying on something else pulling it in for us, plus it fixes several cases where the #ifndef OPENSSL_NO_XYZ is never going to do anything, since OPENSSL_NO_XYZ will never defined, due to the fact that opensslconf.h has not been included. This also includes some miscellaneous sorting/tidying of headers.
* save_errno botch; spotted by miodderaadt2014-06-271-2/+2
|
* hand-KNF the remaining bitsderaadt2014-06-271-98/+106
|
* save errno in ERR_put_error(), so that SYSerr doesn't have any accidentalderaadt2014-06-261-1/+3
| | | | | cases where errno can be trashed. ok jsing
* tags as requested by miod and teduderaadt2014-06-121-1/+1
|
* malloc() result does not need a cast.deraadt2014-06-071-1/+1
| | | | ok miod
* No OPENSSL_SYS_WINDOWS wanted.jsing2014-05-241-3/+0
| | | | ok miod@
* add ERR_asprintf_error_data, A tool to be used to get rid of the far toobeck2014-04-241-25/+25
| | | | | | | | | frequent construct of 30 lines of pointer and strlcat insanity followed by an ERR_add_error_data. I will sweep through here like a chubby mongol horde in the next few days pillaging crappy ERR_add_error_data's. Oh and while we're at it fix the nasty vdata function to use something less hard on the eyes. ok jsing@
* KNF.jsing2014-04-211-486/+516
|
* Chop off more SSLv2 tentacles and start fixing and noting y2038 issues.guenther2014-04-201-11/+18
| | | | | | | APIs that pass times as longs will have to change at some point... Bump major on both libcrypto and libssl. ok tedu@
* We'll interpret a (void) cast on snprintf() to mean it's been verified thatguenther2014-04-191-4/+4
| | | | | | truncation is either desirable, not an issue, or is detected and handled later ok deraadt@
* use intrinsic strlcpy and strlcat everywhere so we only have one set ofbeck2014-04-191-1/+1
| | | | | | funcitons to check for incorrect use. keep BUF_strlcpy and BUF_strlcat for API comptibility only. ok tedu@
generated by cgit v1.2.3-55-g6feb (git 2.39.1) at 2025-04-26 17:48:49 +0000