Plan each dependency provider dependent individually.

Refactoring for #6510

8 files changed, 156 insertions, 76 deletions

diff --git a/src/burn/engine/apply.cpp b/src/burn/engine/apply.cpp
index 2168cba6..5cc63d02 100644
--- a/src/burn/engine/apply.cpp
+++ b/src/burn/engine/apply.cpp
@@ -258,7 +258,8 @@ static HRESULT ExecutePackageProviderAction(
 static HRESULT ExecuteDependencyAction(
     __in BURN_ENGINE_STATE* pEngineState,
     __in BURN_EXECUTE_ACTION* pAction,
-    __in BURN_EXECUTE_CONTEXT* pContext
+    __in BURN_EXECUTE_CONTEXT* pContext,
+    __in BOOL fRollback
     );
 static HRESULT ExecuteMsiBeginTransaction(
     __in BURN_ENGINE_STATE* pEngineState,
@@ -2357,7 +2358,7 @@ static HRESULT DoExecuteAction(
             break;
 
         case BURN_EXECUTE_ACTION_TYPE_PACKAGE_DEPENDENCY:
-            hr = ExecuteDependencyAction(pEngineState, pExecuteAction, pContext);
+            hr = ExecuteDependencyAction(pEngineState, pExecuteAction, pContext, FALSE);
             ExitOnFailure(hr, "Failed to execute dependency action.");
             break;
 
@@ -2480,7 +2481,7 @@ static HRESULT DoRollbackActions(
                 break;
 
             case BURN_EXECUTE_ACTION_TYPE_PACKAGE_DEPENDENCY:
-                hr = ExecuteDependencyAction(pEngineState, pRollbackAction, pContext);
+                hr = ExecuteDependencyAction(pEngineState, pRollbackAction, pContext, TRUE);
                 IgnoreRollbackError(hr, "Failed to rollback dependency action.");
                 break;
 
@@ -2915,26 +2916,31 @@ LExit:
 static HRESULT ExecuteDependencyAction(
     __in BURN_ENGINE_STATE* pEngineState,
     __in BURN_EXECUTE_ACTION* pAction,
-    __in BURN_EXECUTE_CONTEXT* /*pContext*/
+    __in BURN_EXECUTE_CONTEXT* pContext,
+    __in BOOL fRollback
     )
 {
     HRESULT hr = S_OK;
     BURN_PACKAGE* pPackage = pAction->packageDependency.pPackage;
 
+    Assert(pContext->fRollback == fRollback);
+    UNREFERENCED_PARAMETER(pContext);
+
     if (pPackage->fPerMachine)
     {
-        hr = ElevationExecutePackageDependencyAction(pEngineState->companionConnection.hPipe, pAction);
+        hr = ElevationExecutePackageDependencyAction(pEngineState->companionConnection.hPipe, pAction, fRollback);
         ExitOnFailure(hr, "Failed to register the dependency on per-machine package.");
     }
     else
     {
-        hr = DependencyExecutePackageDependencyAction(FALSE, pAction);
+        hr = DependencyExecutePackageDependencyAction(FALSE, pAction, fRollback);
         ExitOnFailure(hr, "Failed to register the dependency on per-user package.");
     }
 
     if (pPackage->fCanAffectRegistration)
     {
-        if (BURN_DEPENDENCY_ACTION_REGISTER == pAction->packageDependency.action)
+        BURN_DEPENDENCY_ACTION dependencyAction = fRollback ? pPackage->dependencyRollback : pPackage->dependencyExecute;
+        if (BURN_DEPENDENCY_ACTION_REGISTER == dependencyAction)
         {
             if (BURN_PACKAGE_REGISTRATION_STATE_IGNORED == pPackage->cacheRegistrationState)
             {
@@ -2958,7 +2964,7 @@ static HRESULT ExecuteDependencyAction(
                 pPackage->installRegistrationState = BURN_PACKAGE_REGISTRATION_STATE_PRESENT;
             }
         }
-        else if (BURN_DEPENDENCY_ACTION_UNREGISTER == pAction->packageDependency.action)
+        else if (BURN_DEPENDENCY_ACTION_UNREGISTER == dependencyAction)
         {
             if (BURN_PACKAGE_REGISTRATION_STATE_PRESENT == pPackage->cacheRegistrationState)
             {
diff --git a/src/burn/engine/dependency.cpp b/src/burn/engine/dependency.cpp
index 8f568f28..01f27d72 100644
--- a/src/burn/engine/dependency.cpp
+++ b/src/burn/engine/dependency.cpp
@@ -72,9 +72,11 @@ static void UnregisterPackageProvider(
     __in HKEY hkRoot
     );
 
-static HRESULT RegisterPackageDependency(
-    __in BOOL fPerMachine,
-    __in const BURN_PACKAGE* pPackage,
+static HRESULT RegisterPackageProviderDependent(
+    __in const BURN_DEPENDENCY_PROVIDER* pProvider,
+    __in BOOL fVital,
+    __in HKEY hkRoot,
+    __in LPCWSTR wzPackageId,
     __in_z LPCWSTR wzDependentProviderKey
     );
 
@@ -83,6 +85,13 @@ static void UnregisterPackageDependency(
     __in const BURN_PACKAGE* pPackage,
     __in_z LPCWSTR wzDependentProviderKey
     );
+
+static void UnregisterPackageProviderDependent(
+    __in const BURN_DEPENDENCY_PROVIDER* pProvider,
+    __in HKEY hkRoot,
+    __in LPCWSTR wzPackageId,
+    __in_z LPCWSTR wzDependentProviderKey
+    );
 static void UnregisterOrphanPackageProviders(
     __in const BURN_PACKAGE* pPackage
     );
@@ -551,8 +560,24 @@ extern "C" HRESULT DependencyPlanPackageBegin(
         }
     }
 
-    pPackage->dependencyExecute = dependencyExecuteAction;
-    pPackage->dependencyRollback = dependencyRollbackAction;
+    for (DWORD i = 0; i < pPackage->cDependencyProviders; ++i)
+    {
+        BURN_DEPENDENCY_PROVIDER* pProvider = &pPackage->rgDependencyProviders[i];
+
+        pProvider->dependentExecute = dependencyExecuteAction;
+        pProvider->dependentRollback = dependencyRollbackAction;
+
+        // The highest aggregate action state found will be returned.
+        if (pPackage->dependencyExecute < pProvider->dependentExecute)
+        {
+            pPackage->dependencyExecute = pProvider->dependentExecute;
+        }
+
+        if (pPackage->dependencyRollback < pProvider->dependentRollback)
+        {
+            pPackage->dependencyRollback = pProvider->dependentRollback;
+        }
+    }
 
 LExit:
     ReleaseDict(sdIgnoredDependents);
@@ -690,23 +715,43 @@ extern "C" HRESULT DependencyExecutePackageProviderAction(
 
 extern "C" HRESULT DependencyExecutePackageDependencyAction(
     __in BOOL fPerMachine,
-    __in const BURN_EXECUTE_ACTION* pAction
+    __in const BURN_EXECUTE_ACTION* pAction,
+    __in BOOL fRollback
     )
 {
     AssertSz(BURN_EXECUTE_ACTION_TYPE_PACKAGE_DEPENDENCY == pAction->type, "Execute action type not supported by this function.");
 
     HRESULT hr = S_OK;
     const BURN_PACKAGE* pPackage = pAction->packageDependency.pPackage;
+    HKEY hkRoot = pPackage->fPerMachine ? HKEY_LOCAL_MACHINE : HKEY_CURRENT_USER;
 
-    // Register or unregister the bundle as a dependent of each package dependency provider.
-    if (BURN_DEPENDENCY_ACTION_REGISTER == pAction->packageDependency.action)
+    // Do not register a dependency on a package in a different install context.
+    if (fPerMachine != pPackage->fPerMachine)
     {
-        hr = RegisterPackageDependency(fPerMachine, pPackage, pAction->packageDependency.sczBundleProviderKey);
-        ExitOnFailure(hr, "Failed to register the dependency on the package provider.");
+        LogId(REPORT_STANDARD, MSG_DEPENDENCY_PACKAGE_SKIP_WRONGSCOPE, pPackage->sczId, LoggingPerMachineToString(fPerMachine), LoggingPerMachineToString(pPackage->fPerMachine));
+        ExitFunction1(hr = S_OK);
     }
-    else if (BURN_DEPENDENCY_ACTION_UNREGISTER == pAction->packageDependency.action)
+
+    for (DWORD i = 0; i < pPackage->cDependencyProviders; ++i)
     {
-        UnregisterPackageDependency(fPerMachine, pPackage, pAction->packageDependency.sczBundleProviderKey);
+        const BURN_DEPENDENCY_PROVIDER* pProvider = pPackage->rgDependencyProviders + i;
+        BURN_DEPENDENCY_ACTION action = fRollback ? pProvider->dependentRollback : pProvider->dependentExecute;
+        HRESULT hrProvider = S_OK;
+
+        // Register or unregister the bundle as a dependent of the package dependency provider.
+        switch (action)
+        {
+        case BURN_DEPENDENCY_ACTION_REGISTER:
+            hrProvider = RegisterPackageProviderDependent(pProvider, pPackage->fVital, hkRoot, pPackage->sczId, pAction->packageDependency.sczBundleProviderKey);
+            if (SUCCEEDED(hr) && FAILED(hrProvider))
+            {
+                hr = hrProvider;
+            }
+            break;
+        case BURN_DEPENDENCY_ACTION_UNREGISTER:
+            UnregisterPackageProviderDependent(pProvider, hkRoot, pPackage->sczId, pAction->packageDependency.sczBundleProviderKey);
+            break;
+        }
     }
 
 LExit:
@@ -1262,7 +1307,6 @@ static HRESULT AddPackageDependencyActions(
 
         pAction->type = BURN_EXECUTE_ACTION_TYPE_PACKAGE_DEPENDENCY;
         pAction->packageDependency.pPackage = const_cast<BURN_PACKAGE*>(pPackage);
-        pAction->packageDependency.action = dependencyRollbackAction;
 
         hr = StrAllocString(&pAction->packageDependency.sczBundleProviderKey, pPlan->wzBundleProviderKey, 0);
         ExitOnFailure(hr, "Failed to copy the bundle dependency provider.");
@@ -1294,7 +1338,6 @@ static HRESULT AddPackageDependencyActions(
 
         pAction->type = BURN_EXECUTE_ACTION_TYPE_PACKAGE_DEPENDENCY;
         pAction->packageDependency.pPackage = const_cast<BURN_PACKAGE*>(pPackage);
-        pAction->packageDependency.action = dependencyExecuteAction;
 
         hr = StrAllocString(&pAction->packageDependency.sczBundleProviderKey, pPlan->wzBundleProviderKey, 0);
         ExitOnFailure(hr, "Failed to copy the bundle dependency provider.");
@@ -1378,48 +1421,38 @@ static void UnregisterPackageProvider(
 }
 
 /********************************************************************
- RegisterPackageDependency - Registers the provider key
-  as a dependent of a package.
+ RegisterPackageProviderDependent - Registers the provider key
+  as a dependent of a package provider.
 
 *********************************************************************/
-static HRESULT RegisterPackageDependency(
-    __in BOOL fPerMachine,
-    __in const BURN_PACKAGE* pPackage,
+static HRESULT RegisterPackageProviderDependent(
+    __in const BURN_DEPENDENCY_PROVIDER* pProvider,
+    __in BOOL fVital,
+    __in HKEY hkRoot,
+    __in LPCWSTR wzPackageId,
     __in_z LPCWSTR wzDependentProviderKey
     )
 {
     HRESULT hr = S_OK;
-    HKEY hkRoot = fPerMachine ? HKEY_LOCAL_MACHINE : HKEY_CURRENT_USER;
 
-    // Do not register a dependency on a package in a different install context.
-    if (fPerMachine != pPackage->fPerMachine)
+    LogId(REPORT_VERBOSE, MSG_DEPENDENCY_PACKAGE_REGISTER_DEPENDENCY, wzDependentProviderKey, pProvider->sczKey, wzPackageId);
+
+    hr = DepRegisterDependent(hkRoot, pProvider->sczKey, wzDependentProviderKey, NULL, NULL, 0);
+    if (E_FILENOTFOUND != hr)
     {
-        LogId(REPORT_STANDARD, MSG_DEPENDENCY_PACKAGE_SKIP_WRONGSCOPE, pPackage->sczId, LoggingPerMachineToString(fPerMachine), LoggingPerMachineToString(pPackage->fPerMachine));
-        ExitFunction1(hr = S_OK);
+        ExitOnFailure(hr, "Failed to register the dependency on package dependency provider: %ls", pProvider->sczKey);
     }
-
-    if (pPackage->rgDependencyProviders)
+    else
     {
-        for (DWORD i = 0; i < pPackage->cDependencyProviders; ++i)
-        {
-            const BURN_DEPENDENCY_PROVIDER* pProvider = &pPackage->rgDependencyProviders[i];
-
-            LogId(REPORT_VERBOSE, MSG_DEPENDENCY_PACKAGE_REGISTER_DEPENDENCY, wzDependentProviderKey, pProvider->sczKey, pPackage->sczId);
-
-            hr = DepRegisterDependent(hkRoot, pProvider->sczKey, wzDependentProviderKey, NULL, NULL, 0);
-            if (E_FILENOTFOUND != hr || pPackage->fVital)
-            {
-                ExitOnFailure(hr, "Failed to register the dependency on package dependency provider: %ls", pProvider->sczKey);
-            }
-            else
-            {
-                LogId(REPORT_VERBOSE, MSG_DEPENDENCY_PACKAGE_SKIP_MISSING, pProvider->sczKey, pPackage->sczId);
-                hr = S_OK;
-            }
-        }
+        LogId(REPORT_VERBOSE, MSG_DEPENDENCY_PACKAGE_SKIP_MISSING, pProvider->sczKey, wzPackageId);
     }
 
 LExit:
+    if (!fVital)
+    {
+        hr = S_OK;
+    }
+
     return hr;
 }
 
@@ -1434,7 +1467,6 @@ static void UnregisterPackageDependency(
     __in_z LPCWSTR wzDependentProviderKey
     )
 {
-    HRESULT hr = S_OK;
     HKEY hkRoot = fPerMachine ? HKEY_LOCAL_MACHINE : HKEY_CURRENT_USER;
 
     // Should be no registration to remove since we don't write keys across contexts.
@@ -1451,19 +1483,31 @@ static void UnregisterPackageDependency(
         {
             const BURN_DEPENDENCY_PROVIDER* pProvider = &pPackage->rgDependencyProviders[i];
 
-            hr = DepUnregisterDependent(hkRoot, pProvider->sczKey, wzDependentProviderKey);
-            if (SUCCEEDED(hr))
-            {
-                LogId(REPORT_VERBOSE, MSG_DEPENDENCY_PACKAGE_UNREGISTERED_DEPENDENCY, wzDependentProviderKey, pProvider->sczKey, pPackage->sczId);
-            }
-            else if (FAILED(hr) && E_FILENOTFOUND != hr)
-            {
-                LogId(REPORT_VERBOSE, MSG_DEPENDENCY_PACKAGE_UNREGISTERED_DEPENDENCY_FAILED, wzDependentProviderKey, pProvider->sczKey, pPackage->sczId, hr);
-            }
+            UnregisterPackageProviderDependent(pProvider, hkRoot, pPackage->sczId, wzDependentProviderKey);
         }
     }
 }
 
+static void UnregisterPackageProviderDependent(
+    __in const BURN_DEPENDENCY_PROVIDER* pProvider,
+    __in HKEY hkRoot,
+    __in LPCWSTR wzPackageId,
+    __in_z LPCWSTR wzDependentProviderKey
+    )
+{
+    HRESULT hr = S_OK;
+
+    hr = DepUnregisterDependent(hkRoot, pProvider->sczKey, wzDependentProviderKey);
+    if (SUCCEEDED(hr))
+    {
+        LogId(REPORT_VERBOSE, MSG_DEPENDENCY_PACKAGE_UNREGISTERED_DEPENDENCY, wzDependentProviderKey, pProvider->sczKey, wzPackageId);
+    }
+    else if (FAILED(hr) && E_FILENOTFOUND != hr)
+    {
+        LogId(REPORT_VERBOSE, MSG_DEPENDENCY_PACKAGE_UNREGISTERED_DEPENDENCY_FAILED, wzDependentProviderKey, pProvider->sczKey, wzPackageId, hr);
+    }
+}
+
 static void UnregisterOrphanPackageProviders(
     __in const BURN_PACKAGE* pPackage
     )
diff --git a/src/burn/engine/dependency.h b/src/burn/engine/dependency.h
index 0e558554..b5e4050f 100644
--- a/src/burn/engine/dependency.h
+++ b/src/burn/engine/dependency.h
@@ -161,7 +161,8 @@ HRESULT DependencyExecutePackageProviderAction(
 *********************************************************************/
 HRESULT DependencyExecutePackageDependencyAction(
     __in BOOL fPerMachine,
-    __in const BURN_EXECUTE_ACTION* pAction
+    __in const BURN_EXECUTE_ACTION* pAction,
+    __in BOOL fRollback
     );
 
 /********************************************************************
diff --git a/src/burn/engine/elevation.cpp b/src/burn/engine/elevation.cpp
index 75679acd..86b65cf9 100644
--- a/src/burn/engine/elevation.cpp
+++ b/src/burn/engine/elevation.cpp
@@ -1346,7 +1346,8 @@ LExit:
 
 extern "C" HRESULT ElevationExecutePackageDependencyAction(
     __in HANDLE hPipe,
-    __in BURN_EXECUTE_ACTION* pExecuteAction
+    __in BURN_EXECUTE_ACTION* pExecuteAction,
+    __in BOOL fRollback
     )
 {
     HRESULT hr = S_OK;
@@ -1359,11 +1360,20 @@ extern "C" HRESULT ElevationExecutePackageDependencyAction(
     hr = BuffWriteString(&pbData, &cbData, pExecuteAction->packageDependency.pPackage->sczId);
     ExitOnFailure(hr, "Failed to write package id to message buffer.");
 
+    hr = BuffWriteNumber(&pbData, &cbData, (DWORD)fRollback);
+    ExitOnFailure(hr, "Failed to write rollback flag to message buffer.");
+
     hr = BuffWriteString(&pbData, &cbData, pExecuteAction->packageDependency.sczBundleProviderKey);
     ExitOnFailure(hr, "Failed to write bundle dependency key to message buffer.");
 
-    hr = BuffWriteNumber(&pbData, &cbData, pExecuteAction->packageDependency.action);
-    ExitOnFailure(hr, "Failed to write action to message buffer.");
+    // Dependent actions.
+    for (DWORD i = 0; i < pExecuteAction->packageProvider.pPackage->cDependencyProviders; ++i)
+    {
+        BURN_DEPENDENCY_PROVIDER* pProvider = pExecuteAction->packageProvider.pPackage->rgDependencyProviders + i;
+        BURN_DEPENDENCY_ACTION* pAction = fRollback ? &pProvider->dependentRollback : &pProvider->dependentExecute;
+        hr = BuffWriteNumber(&pbData, &cbData, (DWORD)*pAction);
+        ExitOnFailure(hr, "Failed to write dependent action to message buffer.");
+    }
 
     // Send the message.
     hr = PipeSendMessage(hPipe, BURN_ELEVATION_MESSAGE_TYPE_EXECUTE_PACKAGE_DEPENDENCY, pbData, cbData, NULL, NULL, &dwResult);
@@ -3260,6 +3270,7 @@ static HRESULT OnExecutePackageDependencyAction(
     HRESULT hr = S_OK;
     SIZE_T iData = 0;
     LPWSTR sczPackage = NULL;
+    BOOL fRollback = FALSE;
     BURN_EXECUTE_ACTION executeAction = { };
 
     executeAction.type = BURN_EXECUTE_ACTION_TYPE_PACKAGE_DEPENDENCY;
@@ -3268,12 +3279,6 @@ static HRESULT OnExecutePackageDependencyAction(
     hr = BuffReadString(pbData, cbData, &iData, &sczPackage);
     ExitOnFailure(hr, "Failed to read package id from message buffer.");
 
-    hr = BuffReadString(pbData, cbData, &iData, &executeAction.packageDependency.sczBundleProviderKey);
-    ExitOnFailure(hr, "Failed to read bundle dependency key from message buffer.");
-
-    hr = BuffReadNumber(pbData, cbData, &iData, reinterpret_cast<DWORD*>(&executeAction.packageDependency.action));
-    ExitOnFailure(hr, "Failed to read action.");
-
     // Find the package again.
     hr = PackageFindById(pPackages, sczPackage, &executeAction.packageDependency.pPackage);
     if (E_NOTFOUND == hr)
@@ -3282,8 +3287,23 @@ static HRESULT OnExecutePackageDependencyAction(
     }
     ExitOnFailure(hr, "Failed to find package: %ls", sczPackage);
 
+    hr = BuffReadNumber(pbData, cbData, &iData, (DWORD*)&fRollback);
+    ExitOnFailure(hr, "Failed to read rollback flag.");
+
+    hr = BuffReadString(pbData, cbData, &iData, &executeAction.packageDependency.sczBundleProviderKey);
+    ExitOnFailure(hr, "Failed to read bundle dependency key from message buffer.");
+
+    // Read dependent actions.
+    for (DWORD i = 0; i < executeAction.packageProvider.pPackage->cDependencyProviders; ++i)
+    {
+        BURN_DEPENDENCY_PROVIDER* pProvider = executeAction.packageProvider.pPackage->rgDependencyProviders + i;
+        BURN_DEPENDENCY_ACTION* pAction = fRollback ? &pProvider->dependentRollback : &pProvider->dependentExecute;
+        hr = BuffReadNumber(pbData, cbData, &iData, (DWORD*)pAction);
+        ExitOnFailure(hr, "Failed to read dependent action.");
+    }
+
     // Execute the package dependency action.
-    hr = DependencyExecutePackageDependencyAction(TRUE, &executeAction);
+    hr = DependencyExecutePackageDependencyAction(TRUE, &executeAction, fRollback);
     ExitOnFailure(hr, "Failed to execute package dependency action.");
 
 LExit:
diff --git a/src/burn/engine/elevation.h b/src/burn/engine/elevation.h
index f5b56f02..c2fa0627 100644
--- a/src/burn/engine/elevation.h
+++ b/src/burn/engine/elevation.h
@@ -144,7 +144,8 @@ HRESULT ElevationExecutePackageProviderAction(
     );
 HRESULT ElevationExecutePackageDependencyAction(
     __in HANDLE hPipe,
-    __in BURN_EXECUTE_ACTION* pExecuteAction
+    __in BURN_EXECUTE_ACTION* pExecuteAction,
+    __in BOOL fRollback
     );
 HRESULT ElevationCleanCompatiblePackage(
     __in HANDLE hPipe,
diff --git a/src/burn/engine/package.h b/src/burn/engine/package.h
index 6fae0c10..38be2098 100644
--- a/src/burn/engine/package.h
+++ b/src/burn/engine/package.h
@@ -45,8 +45,8 @@ enum BURN_PACKAGE_TYPE
 enum BURN_DEPENDENCY_ACTION
 {
     BURN_DEPENDENCY_ACTION_NONE,
-    BURN_DEPENDENCY_ACTION_REGISTER,
     BURN_DEPENDENCY_ACTION_UNREGISTER,
+    BURN_DEPENDENCY_ACTION_REGISTER,
 };
 
 enum BURN_PATCH_TARGETCODE_TYPE
@@ -196,6 +196,8 @@ typedef struct _BURN_DEPENDENCY_PROVIDER
     DEPENDENCY* rgDependents; // only valid after Detect.
     UINT cDependents;         // only valid after Detect.
 
+    BURN_DEPENDENCY_ACTION dependentExecute;   // only valid during Plan.
+    BURN_DEPENDENCY_ACTION dependentRollback;  // only valid during Plan.
     BURN_DEPENDENCY_ACTION providerExecute;    // only valid during Plan.
     BURN_DEPENDENCY_ACTION providerRollback;   // only valid during Plan.
 } BURN_DEPENDENCY_PROVIDER;
diff --git a/src/burn/engine/plan.cpp b/src/burn/engine/plan.cpp
index 27eee3fb..812dcd15 100644
--- a/src/burn/engine/plan.cpp
+++ b/src/burn/engine/plan.cpp
@@ -1973,6 +1973,8 @@ static void ResetPlannedPackageState(
     {
         BURN_DEPENDENCY_PROVIDER* pProvider = &pPackage->rgDependencyProviders[i];
 
+        pProvider->dependentExecute = BURN_DEPENDENCY_ACTION_NONE;
+        pProvider->dependentRollback = BURN_DEPENDENCY_ACTION_NONE;
         pProvider->providerExecute = BURN_DEPENDENCY_ACTION_NONE;
         pProvider->providerRollback = BURN_DEPENDENCY_ACTION_NONE;
     }
@@ -2654,7 +2656,12 @@ static void ExecuteActionLog(
         break;
 
     case BURN_EXECUTE_ACTION_TYPE_PACKAGE_DEPENDENCY:
-        LogStringLine(PlanDumpLevel, "%ls action[%u]: PACKAGE_DEPENDENCY package id: %ls, bundle provider key: %ls, action: %hs", wzBase, iAction, pAction->packageDependency.pPackage->sczId, pAction->packageDependency.sczBundleProviderKey, LoggingDependencyActionToString(pAction->packageDependency.action));
+        LogStringLine(PlanDumpLevel, "%ls action[%u]: PACKAGE_DEPENDENCY package id: %ls, bundle provider key: %ls", wzBase, iAction, pAction->packageDependency.pPackage->sczId, pAction->packageDependency.sczBundleProviderKey);
+        for (DWORD j = 0; j < pAction->packageProvider.pPackage->cDependencyProviders; ++j)
+        {
+            const BURN_DEPENDENCY_PROVIDER* pProvider = pAction->packageProvider.pPackage->rgDependencyProviders + j;
+            LogStringLine(PlanDumpLevel, "      Provider[%u]: key: %ls, action: %hs", j, pProvider->sczKey, LoggingDependencyActionToString(fRollback ? pProvider->dependentRollback : pProvider->dependentExecute));
+        }
         break;
 
     case BURN_EXECUTE_ACTION_TYPE_RELATED_BUNDLE:
diff --git a/src/burn/engine/plan.h b/src/burn/engine/plan.h
index 61953168..3e5ab159 100644
--- a/src/burn/engine/plan.h
+++ b/src/burn/engine/plan.h
@@ -213,7 +213,6 @@ typedef struct _BURN_EXECUTE_ACTION
         {
             BURN_PACKAGE* pPackage;
             LPWSTR sczBundleProviderKey;
-            BURN_DEPENDENCY_ACTION action;
         } packageDependency;
         struct
         {