diff options
Diffstat (limited to 'src/burn/engine')
-rw-r--r-- | src/burn/engine/apply.cpp | 22 | ||||
-rw-r--r-- | src/burn/engine/dependency.cpp | 150 | ||||
-rw-r--r-- | src/burn/engine/dependency.h | 3 | ||||
-rw-r--r-- | src/burn/engine/elevation.cpp | 40 | ||||
-rw-r--r-- | src/burn/engine/elevation.h | 3 | ||||
-rw-r--r-- | src/burn/engine/package.h | 4 | ||||
-rw-r--r-- | src/burn/engine/plan.cpp | 9 | ||||
-rw-r--r-- | src/burn/engine/plan.h | 1 |
8 files changed, 156 insertions, 76 deletions
diff --git a/src/burn/engine/apply.cpp b/src/burn/engine/apply.cpp index 2168cba6..5cc63d02 100644 --- a/src/burn/engine/apply.cpp +++ b/src/burn/engine/apply.cpp | |||
@@ -258,7 +258,8 @@ static HRESULT ExecutePackageProviderAction( | |||
258 | static HRESULT ExecuteDependencyAction( | 258 | static HRESULT ExecuteDependencyAction( |
259 | __in BURN_ENGINE_STATE* pEngineState, | 259 | __in BURN_ENGINE_STATE* pEngineState, |
260 | __in BURN_EXECUTE_ACTION* pAction, | 260 | __in BURN_EXECUTE_ACTION* pAction, |
261 | __in BURN_EXECUTE_CONTEXT* pContext | 261 | __in BURN_EXECUTE_CONTEXT* pContext, |
262 | __in BOOL fRollback | ||
262 | ); | 263 | ); |
263 | static HRESULT ExecuteMsiBeginTransaction( | 264 | static HRESULT ExecuteMsiBeginTransaction( |
264 | __in BURN_ENGINE_STATE* pEngineState, | 265 | __in BURN_ENGINE_STATE* pEngineState, |
@@ -2357,7 +2358,7 @@ static HRESULT DoExecuteAction( | |||
2357 | break; | 2358 | break; |
2358 | 2359 | ||
2359 | case BURN_EXECUTE_ACTION_TYPE_PACKAGE_DEPENDENCY: | 2360 | case BURN_EXECUTE_ACTION_TYPE_PACKAGE_DEPENDENCY: |
2360 | hr = ExecuteDependencyAction(pEngineState, pExecuteAction, pContext); | 2361 | hr = ExecuteDependencyAction(pEngineState, pExecuteAction, pContext, FALSE); |
2361 | ExitOnFailure(hr, "Failed to execute dependency action."); | 2362 | ExitOnFailure(hr, "Failed to execute dependency action."); |
2362 | break; | 2363 | break; |
2363 | 2364 | ||
@@ -2480,7 +2481,7 @@ static HRESULT DoRollbackActions( | |||
2480 | break; | 2481 | break; |
2481 | 2482 | ||
2482 | case BURN_EXECUTE_ACTION_TYPE_PACKAGE_DEPENDENCY: | 2483 | case BURN_EXECUTE_ACTION_TYPE_PACKAGE_DEPENDENCY: |
2483 | hr = ExecuteDependencyAction(pEngineState, pRollbackAction, pContext); | 2484 | hr = ExecuteDependencyAction(pEngineState, pRollbackAction, pContext, TRUE); |
2484 | IgnoreRollbackError(hr, "Failed to rollback dependency action."); | 2485 | IgnoreRollbackError(hr, "Failed to rollback dependency action."); |
2485 | break; | 2486 | break; |
2486 | 2487 | ||
@@ -2915,26 +2916,31 @@ LExit: | |||
2915 | static HRESULT ExecuteDependencyAction( | 2916 | static HRESULT ExecuteDependencyAction( |
2916 | __in BURN_ENGINE_STATE* pEngineState, | 2917 | __in BURN_ENGINE_STATE* pEngineState, |
2917 | __in BURN_EXECUTE_ACTION* pAction, | 2918 | __in BURN_EXECUTE_ACTION* pAction, |
2918 | __in BURN_EXECUTE_CONTEXT* /*pContext*/ | 2919 | __in BURN_EXECUTE_CONTEXT* pContext, |
2920 | __in BOOL fRollback | ||
2919 | ) | 2921 | ) |
2920 | { | 2922 | { |
2921 | HRESULT hr = S_OK; | 2923 | HRESULT hr = S_OK; |
2922 | BURN_PACKAGE* pPackage = pAction->packageDependency.pPackage; | 2924 | BURN_PACKAGE* pPackage = pAction->packageDependency.pPackage; |
2923 | 2925 | ||
2926 | Assert(pContext->fRollback == fRollback); | ||
2927 | UNREFERENCED_PARAMETER(pContext); | ||
2928 | |||
2924 | if (pPackage->fPerMachine) | 2929 | if (pPackage->fPerMachine) |
2925 | { | 2930 | { |
2926 | hr = ElevationExecutePackageDependencyAction(pEngineState->companionConnection.hPipe, pAction); | 2931 | hr = ElevationExecutePackageDependencyAction(pEngineState->companionConnection.hPipe, pAction, fRollback); |
2927 | ExitOnFailure(hr, "Failed to register the dependency on per-machine package."); | 2932 | ExitOnFailure(hr, "Failed to register the dependency on per-machine package."); |
2928 | } | 2933 | } |
2929 | else | 2934 | else |
2930 | { | 2935 | { |
2931 | hr = DependencyExecutePackageDependencyAction(FALSE, pAction); | 2936 | hr = DependencyExecutePackageDependencyAction(FALSE, pAction, fRollback); |
2932 | ExitOnFailure(hr, "Failed to register the dependency on per-user package."); | 2937 | ExitOnFailure(hr, "Failed to register the dependency on per-user package."); |
2933 | } | 2938 | } |
2934 | 2939 | ||
2935 | if (pPackage->fCanAffectRegistration) | 2940 | if (pPackage->fCanAffectRegistration) |
2936 | { | 2941 | { |
2937 | if (BURN_DEPENDENCY_ACTION_REGISTER == pAction->packageDependency.action) | 2942 | BURN_DEPENDENCY_ACTION dependencyAction = fRollback ? pPackage->dependencyRollback : pPackage->dependencyExecute; |
2943 | if (BURN_DEPENDENCY_ACTION_REGISTER == dependencyAction) | ||
2938 | { | 2944 | { |
2939 | if (BURN_PACKAGE_REGISTRATION_STATE_IGNORED == pPackage->cacheRegistrationState) | 2945 | if (BURN_PACKAGE_REGISTRATION_STATE_IGNORED == pPackage->cacheRegistrationState) |
2940 | { | 2946 | { |
@@ -2958,7 +2964,7 @@ static HRESULT ExecuteDependencyAction( | |||
2958 | pPackage->installRegistrationState = BURN_PACKAGE_REGISTRATION_STATE_PRESENT; | 2964 | pPackage->installRegistrationState = BURN_PACKAGE_REGISTRATION_STATE_PRESENT; |
2959 | } | 2965 | } |
2960 | } | 2966 | } |
2961 | else if (BURN_DEPENDENCY_ACTION_UNREGISTER == pAction->packageDependency.action) | 2967 | else if (BURN_DEPENDENCY_ACTION_UNREGISTER == dependencyAction) |
2962 | { | 2968 | { |
2963 | if (BURN_PACKAGE_REGISTRATION_STATE_PRESENT == pPackage->cacheRegistrationState) | 2969 | if (BURN_PACKAGE_REGISTRATION_STATE_PRESENT == pPackage->cacheRegistrationState) |
2964 | { | 2970 | { |
diff --git a/src/burn/engine/dependency.cpp b/src/burn/engine/dependency.cpp index 8f568f28..01f27d72 100644 --- a/src/burn/engine/dependency.cpp +++ b/src/burn/engine/dependency.cpp | |||
@@ -72,9 +72,11 @@ static void UnregisterPackageProvider( | |||
72 | __in HKEY hkRoot | 72 | __in HKEY hkRoot |
73 | ); | 73 | ); |
74 | 74 | ||
75 | static HRESULT RegisterPackageDependency( | 75 | static HRESULT RegisterPackageProviderDependent( |
76 | __in BOOL fPerMachine, | 76 | __in const BURN_DEPENDENCY_PROVIDER* pProvider, |
77 | __in const BURN_PACKAGE* pPackage, | 77 | __in BOOL fVital, |
78 | __in HKEY hkRoot, | ||
79 | __in LPCWSTR wzPackageId, | ||
78 | __in_z LPCWSTR wzDependentProviderKey | 80 | __in_z LPCWSTR wzDependentProviderKey |
79 | ); | 81 | ); |
80 | 82 | ||
@@ -83,6 +85,13 @@ static void UnregisterPackageDependency( | |||
83 | __in const BURN_PACKAGE* pPackage, | 85 | __in const BURN_PACKAGE* pPackage, |
84 | __in_z LPCWSTR wzDependentProviderKey | 86 | __in_z LPCWSTR wzDependentProviderKey |
85 | ); | 87 | ); |
88 | |||
89 | static void UnregisterPackageProviderDependent( | ||
90 | __in const BURN_DEPENDENCY_PROVIDER* pProvider, | ||
91 | __in HKEY hkRoot, | ||
92 | __in LPCWSTR wzPackageId, | ||
93 | __in_z LPCWSTR wzDependentProviderKey | ||
94 | ); | ||
86 | static void UnregisterOrphanPackageProviders( | 95 | static void UnregisterOrphanPackageProviders( |
87 | __in const BURN_PACKAGE* pPackage | 96 | __in const BURN_PACKAGE* pPackage |
88 | ); | 97 | ); |
@@ -551,8 +560,24 @@ extern "C" HRESULT DependencyPlanPackageBegin( | |||
551 | } | 560 | } |
552 | } | 561 | } |
553 | 562 | ||
554 | pPackage->dependencyExecute = dependencyExecuteAction; | 563 | for (DWORD i = 0; i < pPackage->cDependencyProviders; ++i) |
555 | pPackage->dependencyRollback = dependencyRollbackAction; | 564 | { |
565 | BURN_DEPENDENCY_PROVIDER* pProvider = &pPackage->rgDependencyProviders[i]; | ||
566 | |||
567 | pProvider->dependentExecute = dependencyExecuteAction; | ||
568 | pProvider->dependentRollback = dependencyRollbackAction; | ||
569 | |||
570 | // The highest aggregate action state found will be returned. | ||
571 | if (pPackage->dependencyExecute < pProvider->dependentExecute) | ||
572 | { | ||
573 | pPackage->dependencyExecute = pProvider->dependentExecute; | ||
574 | } | ||
575 | |||
576 | if (pPackage->dependencyRollback < pProvider->dependentRollback) | ||
577 | { | ||
578 | pPackage->dependencyRollback = pProvider->dependentRollback; | ||
579 | } | ||
580 | } | ||
556 | 581 | ||
557 | LExit: | 582 | LExit: |
558 | ReleaseDict(sdIgnoredDependents); | 583 | ReleaseDict(sdIgnoredDependents); |
@@ -690,23 +715,43 @@ extern "C" HRESULT DependencyExecutePackageProviderAction( | |||
690 | 715 | ||
691 | extern "C" HRESULT DependencyExecutePackageDependencyAction( | 716 | extern "C" HRESULT DependencyExecutePackageDependencyAction( |
692 | __in BOOL fPerMachine, | 717 | __in BOOL fPerMachine, |
693 | __in const BURN_EXECUTE_ACTION* pAction | 718 | __in const BURN_EXECUTE_ACTION* pAction, |
719 | __in BOOL fRollback | ||
694 | ) | 720 | ) |
695 | { | 721 | { |
696 | AssertSz(BURN_EXECUTE_ACTION_TYPE_PACKAGE_DEPENDENCY == pAction->type, "Execute action type not supported by this function."); | 722 | AssertSz(BURN_EXECUTE_ACTION_TYPE_PACKAGE_DEPENDENCY == pAction->type, "Execute action type not supported by this function."); |
697 | 723 | ||
698 | HRESULT hr = S_OK; | 724 | HRESULT hr = S_OK; |
699 | const BURN_PACKAGE* pPackage = pAction->packageDependency.pPackage; | 725 | const BURN_PACKAGE* pPackage = pAction->packageDependency.pPackage; |
726 | HKEY hkRoot = pPackage->fPerMachine ? HKEY_LOCAL_MACHINE : HKEY_CURRENT_USER; | ||
700 | 727 | ||
701 | // Register or unregister the bundle as a dependent of each package dependency provider. | 728 | // Do not register a dependency on a package in a different install context. |
702 | if (BURN_DEPENDENCY_ACTION_REGISTER == pAction->packageDependency.action) | 729 | if (fPerMachine != pPackage->fPerMachine) |
703 | { | 730 | { |
704 | hr = RegisterPackageDependency(fPerMachine, pPackage, pAction->packageDependency.sczBundleProviderKey); | 731 | LogId(REPORT_STANDARD, MSG_DEPENDENCY_PACKAGE_SKIP_WRONGSCOPE, pPackage->sczId, LoggingPerMachineToString(fPerMachine), LoggingPerMachineToString(pPackage->fPerMachine)); |
705 | ExitOnFailure(hr, "Failed to register the dependency on the package provider."); | 732 | ExitFunction1(hr = S_OK); |
706 | } | 733 | } |
707 | else if (BURN_DEPENDENCY_ACTION_UNREGISTER == pAction->packageDependency.action) | 734 | |
735 | for (DWORD i = 0; i < pPackage->cDependencyProviders; ++i) | ||
708 | { | 736 | { |
709 | UnregisterPackageDependency(fPerMachine, pPackage, pAction->packageDependency.sczBundleProviderKey); | 737 | const BURN_DEPENDENCY_PROVIDER* pProvider = pPackage->rgDependencyProviders + i; |
738 | BURN_DEPENDENCY_ACTION action = fRollback ? pProvider->dependentRollback : pProvider->dependentExecute; | ||
739 | HRESULT hrProvider = S_OK; | ||
740 | |||
741 | // Register or unregister the bundle as a dependent of the package dependency provider. | ||
742 | switch (action) | ||
743 | { | ||
744 | case BURN_DEPENDENCY_ACTION_REGISTER: | ||
745 | hrProvider = RegisterPackageProviderDependent(pProvider, pPackage->fVital, hkRoot, pPackage->sczId, pAction->packageDependency.sczBundleProviderKey); | ||
746 | if (SUCCEEDED(hr) && FAILED(hrProvider)) | ||
747 | { | ||
748 | hr = hrProvider; | ||
749 | } | ||
750 | break; | ||
751 | case BURN_DEPENDENCY_ACTION_UNREGISTER: | ||
752 | UnregisterPackageProviderDependent(pProvider, hkRoot, pPackage->sczId, pAction->packageDependency.sczBundleProviderKey); | ||
753 | break; | ||
754 | } | ||
710 | } | 755 | } |
711 | 756 | ||
712 | LExit: | 757 | LExit: |
@@ -1262,7 +1307,6 @@ static HRESULT AddPackageDependencyActions( | |||
1262 | 1307 | ||
1263 | pAction->type = BURN_EXECUTE_ACTION_TYPE_PACKAGE_DEPENDENCY; | 1308 | pAction->type = BURN_EXECUTE_ACTION_TYPE_PACKAGE_DEPENDENCY; |
1264 | pAction->packageDependency.pPackage = const_cast<BURN_PACKAGE*>(pPackage); | 1309 | pAction->packageDependency.pPackage = const_cast<BURN_PACKAGE*>(pPackage); |
1265 | pAction->packageDependency.action = dependencyRollbackAction; | ||
1266 | 1310 | ||
1267 | hr = StrAllocString(&pAction->packageDependency.sczBundleProviderKey, pPlan->wzBundleProviderKey, 0); | 1311 | hr = StrAllocString(&pAction->packageDependency.sczBundleProviderKey, pPlan->wzBundleProviderKey, 0); |
1268 | ExitOnFailure(hr, "Failed to copy the bundle dependency provider."); | 1312 | ExitOnFailure(hr, "Failed to copy the bundle dependency provider."); |
@@ -1294,7 +1338,6 @@ static HRESULT AddPackageDependencyActions( | |||
1294 | 1338 | ||
1295 | pAction->type = BURN_EXECUTE_ACTION_TYPE_PACKAGE_DEPENDENCY; | 1339 | pAction->type = BURN_EXECUTE_ACTION_TYPE_PACKAGE_DEPENDENCY; |
1296 | pAction->packageDependency.pPackage = const_cast<BURN_PACKAGE*>(pPackage); | 1340 | pAction->packageDependency.pPackage = const_cast<BURN_PACKAGE*>(pPackage); |
1297 | pAction->packageDependency.action = dependencyExecuteAction; | ||
1298 | 1341 | ||
1299 | hr = StrAllocString(&pAction->packageDependency.sczBundleProviderKey, pPlan->wzBundleProviderKey, 0); | 1342 | hr = StrAllocString(&pAction->packageDependency.sczBundleProviderKey, pPlan->wzBundleProviderKey, 0); |
1300 | ExitOnFailure(hr, "Failed to copy the bundle dependency provider."); | 1343 | ExitOnFailure(hr, "Failed to copy the bundle dependency provider."); |
@@ -1378,48 +1421,38 @@ static void UnregisterPackageProvider( | |||
1378 | } | 1421 | } |
1379 | 1422 | ||
1380 | /******************************************************************** | 1423 | /******************************************************************** |
1381 | RegisterPackageDependency - Registers the provider key | 1424 | RegisterPackageProviderDependent - Registers the provider key |
1382 | as a dependent of a package. | 1425 | as a dependent of a package provider. |
1383 | 1426 | ||
1384 | *********************************************************************/ | 1427 | *********************************************************************/ |
1385 | static HRESULT RegisterPackageDependency( | 1428 | static HRESULT RegisterPackageProviderDependent( |
1386 | __in BOOL fPerMachine, | 1429 | __in const BURN_DEPENDENCY_PROVIDER* pProvider, |
1387 | __in const BURN_PACKAGE* pPackage, | 1430 | __in BOOL fVital, |
1431 | __in HKEY hkRoot, | ||
1432 | __in LPCWSTR wzPackageId, | ||
1388 | __in_z LPCWSTR wzDependentProviderKey | 1433 | __in_z LPCWSTR wzDependentProviderKey |
1389 | ) | 1434 | ) |
1390 | { | 1435 | { |
1391 | HRESULT hr = S_OK; | 1436 | HRESULT hr = S_OK; |
1392 | HKEY hkRoot = fPerMachine ? HKEY_LOCAL_MACHINE : HKEY_CURRENT_USER; | ||
1393 | 1437 | ||
1394 | // Do not register a dependency on a package in a different install context. | 1438 | LogId(REPORT_VERBOSE, MSG_DEPENDENCY_PACKAGE_REGISTER_DEPENDENCY, wzDependentProviderKey, pProvider->sczKey, wzPackageId); |
1395 | if (fPerMachine != pPackage->fPerMachine) | 1439 | |
1440 | hr = DepRegisterDependent(hkRoot, pProvider->sczKey, wzDependentProviderKey, NULL, NULL, 0); | ||
1441 | if (E_FILENOTFOUND != hr) | ||
1396 | { | 1442 | { |
1397 | LogId(REPORT_STANDARD, MSG_DEPENDENCY_PACKAGE_SKIP_WRONGSCOPE, pPackage->sczId, LoggingPerMachineToString(fPerMachine), LoggingPerMachineToString(pPackage->fPerMachine)); | 1443 | ExitOnFailure(hr, "Failed to register the dependency on package dependency provider: %ls", pProvider->sczKey); |
1398 | ExitFunction1(hr = S_OK); | ||
1399 | } | 1444 | } |
1400 | 1445 | else | |
1401 | if (pPackage->rgDependencyProviders) | ||
1402 | { | 1446 | { |
1403 | for (DWORD i = 0; i < pPackage->cDependencyProviders; ++i) | 1447 | LogId(REPORT_VERBOSE, MSG_DEPENDENCY_PACKAGE_SKIP_MISSING, pProvider->sczKey, wzPackageId); |
1404 | { | ||
1405 | const BURN_DEPENDENCY_PROVIDER* pProvider = &pPackage->rgDependencyProviders[i]; | ||
1406 | |||
1407 | LogId(REPORT_VERBOSE, MSG_DEPENDENCY_PACKAGE_REGISTER_DEPENDENCY, wzDependentProviderKey, pProvider->sczKey, pPackage->sczId); | ||
1408 | |||
1409 | hr = DepRegisterDependent(hkRoot, pProvider->sczKey, wzDependentProviderKey, NULL, NULL, 0); | ||
1410 | if (E_FILENOTFOUND != hr || pPackage->fVital) | ||
1411 | { | ||
1412 | ExitOnFailure(hr, "Failed to register the dependency on package dependency provider: %ls", pProvider->sczKey); | ||
1413 | } | ||
1414 | else | ||
1415 | { | ||
1416 | LogId(REPORT_VERBOSE, MSG_DEPENDENCY_PACKAGE_SKIP_MISSING, pProvider->sczKey, pPackage->sczId); | ||
1417 | hr = S_OK; | ||
1418 | } | ||
1419 | } | ||
1420 | } | 1448 | } |
1421 | 1449 | ||
1422 | LExit: | 1450 | LExit: |
1451 | if (!fVital) | ||
1452 | { | ||
1453 | hr = S_OK; | ||
1454 | } | ||
1455 | |||
1423 | return hr; | 1456 | return hr; |
1424 | } | 1457 | } |
1425 | 1458 | ||
@@ -1434,7 +1467,6 @@ static void UnregisterPackageDependency( | |||
1434 | __in_z LPCWSTR wzDependentProviderKey | 1467 | __in_z LPCWSTR wzDependentProviderKey |
1435 | ) | 1468 | ) |
1436 | { | 1469 | { |
1437 | HRESULT hr = S_OK; | ||
1438 | HKEY hkRoot = fPerMachine ? HKEY_LOCAL_MACHINE : HKEY_CURRENT_USER; | 1470 | HKEY hkRoot = fPerMachine ? HKEY_LOCAL_MACHINE : HKEY_CURRENT_USER; |
1439 | 1471 | ||
1440 | // Should be no registration to remove since we don't write keys across contexts. | 1472 | // Should be no registration to remove since we don't write keys across contexts. |
@@ -1451,19 +1483,31 @@ static void UnregisterPackageDependency( | |||
1451 | { | 1483 | { |
1452 | const BURN_DEPENDENCY_PROVIDER* pProvider = &pPackage->rgDependencyProviders[i]; | 1484 | const BURN_DEPENDENCY_PROVIDER* pProvider = &pPackage->rgDependencyProviders[i]; |
1453 | 1485 | ||
1454 | hr = DepUnregisterDependent(hkRoot, pProvider->sczKey, wzDependentProviderKey); | 1486 | UnregisterPackageProviderDependent(pProvider, hkRoot, pPackage->sczId, wzDependentProviderKey); |
1455 | if (SUCCEEDED(hr)) | ||
1456 | { | ||
1457 | LogId(REPORT_VERBOSE, MSG_DEPENDENCY_PACKAGE_UNREGISTERED_DEPENDENCY, wzDependentProviderKey, pProvider->sczKey, pPackage->sczId); | ||
1458 | } | ||
1459 | else if (FAILED(hr) && E_FILENOTFOUND != hr) | ||
1460 | { | ||
1461 | LogId(REPORT_VERBOSE, MSG_DEPENDENCY_PACKAGE_UNREGISTERED_DEPENDENCY_FAILED, wzDependentProviderKey, pProvider->sczKey, pPackage->sczId, hr); | ||
1462 | } | ||
1463 | } | 1487 | } |
1464 | } | 1488 | } |
1465 | } | 1489 | } |
1466 | 1490 | ||
1491 | static void UnregisterPackageProviderDependent( | ||
1492 | __in const BURN_DEPENDENCY_PROVIDER* pProvider, | ||
1493 | __in HKEY hkRoot, | ||
1494 | __in LPCWSTR wzPackageId, | ||
1495 | __in_z LPCWSTR wzDependentProviderKey | ||
1496 | ) | ||
1497 | { | ||
1498 | HRESULT hr = S_OK; | ||
1499 | |||
1500 | hr = DepUnregisterDependent(hkRoot, pProvider->sczKey, wzDependentProviderKey); | ||
1501 | if (SUCCEEDED(hr)) | ||
1502 | { | ||
1503 | LogId(REPORT_VERBOSE, MSG_DEPENDENCY_PACKAGE_UNREGISTERED_DEPENDENCY, wzDependentProviderKey, pProvider->sczKey, wzPackageId); | ||
1504 | } | ||
1505 | else if (FAILED(hr) && E_FILENOTFOUND != hr) | ||
1506 | { | ||
1507 | LogId(REPORT_VERBOSE, MSG_DEPENDENCY_PACKAGE_UNREGISTERED_DEPENDENCY_FAILED, wzDependentProviderKey, pProvider->sczKey, wzPackageId, hr); | ||
1508 | } | ||
1509 | } | ||
1510 | |||
1467 | static void UnregisterOrphanPackageProviders( | 1511 | static void UnregisterOrphanPackageProviders( |
1468 | __in const BURN_PACKAGE* pPackage | 1512 | __in const BURN_PACKAGE* pPackage |
1469 | ) | 1513 | ) |
diff --git a/src/burn/engine/dependency.h b/src/burn/engine/dependency.h index 0e558554..b5e4050f 100644 --- a/src/burn/engine/dependency.h +++ b/src/burn/engine/dependency.h | |||
@@ -161,7 +161,8 @@ HRESULT DependencyExecutePackageProviderAction( | |||
161 | *********************************************************************/ | 161 | *********************************************************************/ |
162 | HRESULT DependencyExecutePackageDependencyAction( | 162 | HRESULT DependencyExecutePackageDependencyAction( |
163 | __in BOOL fPerMachine, | 163 | __in BOOL fPerMachine, |
164 | __in const BURN_EXECUTE_ACTION* pAction | 164 | __in const BURN_EXECUTE_ACTION* pAction, |
165 | __in BOOL fRollback | ||
165 | ); | 166 | ); |
166 | 167 | ||
167 | /******************************************************************** | 168 | /******************************************************************** |
diff --git a/src/burn/engine/elevation.cpp b/src/burn/engine/elevation.cpp index 75679acd..86b65cf9 100644 --- a/src/burn/engine/elevation.cpp +++ b/src/burn/engine/elevation.cpp | |||
@@ -1346,7 +1346,8 @@ LExit: | |||
1346 | 1346 | ||
1347 | extern "C" HRESULT ElevationExecutePackageDependencyAction( | 1347 | extern "C" HRESULT ElevationExecutePackageDependencyAction( |
1348 | __in HANDLE hPipe, | 1348 | __in HANDLE hPipe, |
1349 | __in BURN_EXECUTE_ACTION* pExecuteAction | 1349 | __in BURN_EXECUTE_ACTION* pExecuteAction, |
1350 | __in BOOL fRollback | ||
1350 | ) | 1351 | ) |
1351 | { | 1352 | { |
1352 | HRESULT hr = S_OK; | 1353 | HRESULT hr = S_OK; |
@@ -1359,11 +1360,20 @@ extern "C" HRESULT ElevationExecutePackageDependencyAction( | |||
1359 | hr = BuffWriteString(&pbData, &cbData, pExecuteAction->packageDependency.pPackage->sczId); | 1360 | hr = BuffWriteString(&pbData, &cbData, pExecuteAction->packageDependency.pPackage->sczId); |
1360 | ExitOnFailure(hr, "Failed to write package id to message buffer."); | 1361 | ExitOnFailure(hr, "Failed to write package id to message buffer."); |
1361 | 1362 | ||
1363 | hr = BuffWriteNumber(&pbData, &cbData, (DWORD)fRollback); | ||
1364 | ExitOnFailure(hr, "Failed to write rollback flag to message buffer."); | ||
1365 | |||
1362 | hr = BuffWriteString(&pbData, &cbData, pExecuteAction->packageDependency.sczBundleProviderKey); | 1366 | hr = BuffWriteString(&pbData, &cbData, pExecuteAction->packageDependency.sczBundleProviderKey); |
1363 | ExitOnFailure(hr, "Failed to write bundle dependency key to message buffer."); | 1367 | ExitOnFailure(hr, "Failed to write bundle dependency key to message buffer."); |
1364 | 1368 | ||
1365 | hr = BuffWriteNumber(&pbData, &cbData, pExecuteAction->packageDependency.action); | 1369 | // Dependent actions. |
1366 | ExitOnFailure(hr, "Failed to write action to message buffer."); | 1370 | for (DWORD i = 0; i < pExecuteAction->packageProvider.pPackage->cDependencyProviders; ++i) |
1371 | { | ||
1372 | BURN_DEPENDENCY_PROVIDER* pProvider = pExecuteAction->packageProvider.pPackage->rgDependencyProviders + i; | ||
1373 | BURN_DEPENDENCY_ACTION* pAction = fRollback ? &pProvider->dependentRollback : &pProvider->dependentExecute; | ||
1374 | hr = BuffWriteNumber(&pbData, &cbData, (DWORD)*pAction); | ||
1375 | ExitOnFailure(hr, "Failed to write dependent action to message buffer."); | ||
1376 | } | ||
1367 | 1377 | ||
1368 | // Send the message. | 1378 | // Send the message. |
1369 | hr = PipeSendMessage(hPipe, BURN_ELEVATION_MESSAGE_TYPE_EXECUTE_PACKAGE_DEPENDENCY, pbData, cbData, NULL, NULL, &dwResult); | 1379 | hr = PipeSendMessage(hPipe, BURN_ELEVATION_MESSAGE_TYPE_EXECUTE_PACKAGE_DEPENDENCY, pbData, cbData, NULL, NULL, &dwResult); |
@@ -3260,6 +3270,7 @@ static HRESULT OnExecutePackageDependencyAction( | |||
3260 | HRESULT hr = S_OK; | 3270 | HRESULT hr = S_OK; |
3261 | SIZE_T iData = 0; | 3271 | SIZE_T iData = 0; |
3262 | LPWSTR sczPackage = NULL; | 3272 | LPWSTR sczPackage = NULL; |
3273 | BOOL fRollback = FALSE; | ||
3263 | BURN_EXECUTE_ACTION executeAction = { }; | 3274 | BURN_EXECUTE_ACTION executeAction = { }; |
3264 | 3275 | ||
3265 | executeAction.type = BURN_EXECUTE_ACTION_TYPE_PACKAGE_DEPENDENCY; | 3276 | executeAction.type = BURN_EXECUTE_ACTION_TYPE_PACKAGE_DEPENDENCY; |
@@ -3268,12 +3279,6 @@ static HRESULT OnExecutePackageDependencyAction( | |||
3268 | hr = BuffReadString(pbData, cbData, &iData, &sczPackage); | 3279 | hr = BuffReadString(pbData, cbData, &iData, &sczPackage); |
3269 | ExitOnFailure(hr, "Failed to read package id from message buffer."); | 3280 | ExitOnFailure(hr, "Failed to read package id from message buffer."); |
3270 | 3281 | ||
3271 | hr = BuffReadString(pbData, cbData, &iData, &executeAction.packageDependency.sczBundleProviderKey); | ||
3272 | ExitOnFailure(hr, "Failed to read bundle dependency key from message buffer."); | ||
3273 | |||
3274 | hr = BuffReadNumber(pbData, cbData, &iData, reinterpret_cast<DWORD*>(&executeAction.packageDependency.action)); | ||
3275 | ExitOnFailure(hr, "Failed to read action."); | ||
3276 | |||
3277 | // Find the package again. | 3282 | // Find the package again. |
3278 | hr = PackageFindById(pPackages, sczPackage, &executeAction.packageDependency.pPackage); | 3283 | hr = PackageFindById(pPackages, sczPackage, &executeAction.packageDependency.pPackage); |
3279 | if (E_NOTFOUND == hr) | 3284 | if (E_NOTFOUND == hr) |
@@ -3282,8 +3287,23 @@ static HRESULT OnExecutePackageDependencyAction( | |||
3282 | } | 3287 | } |
3283 | ExitOnFailure(hr, "Failed to find package: %ls", sczPackage); | 3288 | ExitOnFailure(hr, "Failed to find package: %ls", sczPackage); |
3284 | 3289 | ||
3290 | hr = BuffReadNumber(pbData, cbData, &iData, (DWORD*)&fRollback); | ||
3291 | ExitOnFailure(hr, "Failed to read rollback flag."); | ||
3292 | |||
3293 | hr = BuffReadString(pbData, cbData, &iData, &executeAction.packageDependency.sczBundleProviderKey); | ||
3294 | ExitOnFailure(hr, "Failed to read bundle dependency key from message buffer."); | ||
3295 | |||
3296 | // Read dependent actions. | ||
3297 | for (DWORD i = 0; i < executeAction.packageProvider.pPackage->cDependencyProviders; ++i) | ||
3298 | { | ||
3299 | BURN_DEPENDENCY_PROVIDER* pProvider = executeAction.packageProvider.pPackage->rgDependencyProviders + i; | ||
3300 | BURN_DEPENDENCY_ACTION* pAction = fRollback ? &pProvider->dependentRollback : &pProvider->dependentExecute; | ||
3301 | hr = BuffReadNumber(pbData, cbData, &iData, (DWORD*)pAction); | ||
3302 | ExitOnFailure(hr, "Failed to read dependent action."); | ||
3303 | } | ||
3304 | |||
3285 | // Execute the package dependency action. | 3305 | // Execute the package dependency action. |
3286 | hr = DependencyExecutePackageDependencyAction(TRUE, &executeAction); | 3306 | hr = DependencyExecutePackageDependencyAction(TRUE, &executeAction, fRollback); |
3287 | ExitOnFailure(hr, "Failed to execute package dependency action."); | 3307 | ExitOnFailure(hr, "Failed to execute package dependency action."); |
3288 | 3308 | ||
3289 | LExit: | 3309 | LExit: |
diff --git a/src/burn/engine/elevation.h b/src/burn/engine/elevation.h index f5b56f02..c2fa0627 100644 --- a/src/burn/engine/elevation.h +++ b/src/burn/engine/elevation.h | |||
@@ -144,7 +144,8 @@ HRESULT ElevationExecutePackageProviderAction( | |||
144 | ); | 144 | ); |
145 | HRESULT ElevationExecutePackageDependencyAction( | 145 | HRESULT ElevationExecutePackageDependencyAction( |
146 | __in HANDLE hPipe, | 146 | __in HANDLE hPipe, |
147 | __in BURN_EXECUTE_ACTION* pExecuteAction | 147 | __in BURN_EXECUTE_ACTION* pExecuteAction, |
148 | __in BOOL fRollback | ||
148 | ); | 149 | ); |
149 | HRESULT ElevationCleanCompatiblePackage( | 150 | HRESULT ElevationCleanCompatiblePackage( |
150 | __in HANDLE hPipe, | 151 | __in HANDLE hPipe, |
diff --git a/src/burn/engine/package.h b/src/burn/engine/package.h index 6fae0c10..38be2098 100644 --- a/src/burn/engine/package.h +++ b/src/burn/engine/package.h | |||
@@ -45,8 +45,8 @@ enum BURN_PACKAGE_TYPE | |||
45 | enum BURN_DEPENDENCY_ACTION | 45 | enum BURN_DEPENDENCY_ACTION |
46 | { | 46 | { |
47 | BURN_DEPENDENCY_ACTION_NONE, | 47 | BURN_DEPENDENCY_ACTION_NONE, |
48 | BURN_DEPENDENCY_ACTION_REGISTER, | ||
49 | BURN_DEPENDENCY_ACTION_UNREGISTER, | 48 | BURN_DEPENDENCY_ACTION_UNREGISTER, |
49 | BURN_DEPENDENCY_ACTION_REGISTER, | ||
50 | }; | 50 | }; |
51 | 51 | ||
52 | enum BURN_PATCH_TARGETCODE_TYPE | 52 | enum BURN_PATCH_TARGETCODE_TYPE |
@@ -196,6 +196,8 @@ typedef struct _BURN_DEPENDENCY_PROVIDER | |||
196 | DEPENDENCY* rgDependents; // only valid after Detect. | 196 | DEPENDENCY* rgDependents; // only valid after Detect. |
197 | UINT cDependents; // only valid after Detect. | 197 | UINT cDependents; // only valid after Detect. |
198 | 198 | ||
199 | BURN_DEPENDENCY_ACTION dependentExecute; // only valid during Plan. | ||
200 | BURN_DEPENDENCY_ACTION dependentRollback; // only valid during Plan. | ||
199 | BURN_DEPENDENCY_ACTION providerExecute; // only valid during Plan. | 201 | BURN_DEPENDENCY_ACTION providerExecute; // only valid during Plan. |
200 | BURN_DEPENDENCY_ACTION providerRollback; // only valid during Plan. | 202 | BURN_DEPENDENCY_ACTION providerRollback; // only valid during Plan. |
201 | } BURN_DEPENDENCY_PROVIDER; | 203 | } BURN_DEPENDENCY_PROVIDER; |
diff --git a/src/burn/engine/plan.cpp b/src/burn/engine/plan.cpp index 27eee3fb..812dcd15 100644 --- a/src/burn/engine/plan.cpp +++ b/src/burn/engine/plan.cpp | |||
@@ -1973,6 +1973,8 @@ static void ResetPlannedPackageState( | |||
1973 | { | 1973 | { |
1974 | BURN_DEPENDENCY_PROVIDER* pProvider = &pPackage->rgDependencyProviders[i]; | 1974 | BURN_DEPENDENCY_PROVIDER* pProvider = &pPackage->rgDependencyProviders[i]; |
1975 | 1975 | ||
1976 | pProvider->dependentExecute = BURN_DEPENDENCY_ACTION_NONE; | ||
1977 | pProvider->dependentRollback = BURN_DEPENDENCY_ACTION_NONE; | ||
1976 | pProvider->providerExecute = BURN_DEPENDENCY_ACTION_NONE; | 1978 | pProvider->providerExecute = BURN_DEPENDENCY_ACTION_NONE; |
1977 | pProvider->providerRollback = BURN_DEPENDENCY_ACTION_NONE; | 1979 | pProvider->providerRollback = BURN_DEPENDENCY_ACTION_NONE; |
1978 | } | 1980 | } |
@@ -2654,7 +2656,12 @@ static void ExecuteActionLog( | |||
2654 | break; | 2656 | break; |
2655 | 2657 | ||
2656 | case BURN_EXECUTE_ACTION_TYPE_PACKAGE_DEPENDENCY: | 2658 | case BURN_EXECUTE_ACTION_TYPE_PACKAGE_DEPENDENCY: |
2657 | LogStringLine(PlanDumpLevel, "%ls action[%u]: PACKAGE_DEPENDENCY package id: %ls, bundle provider key: %ls, action: %hs", wzBase, iAction, pAction->packageDependency.pPackage->sczId, pAction->packageDependency.sczBundleProviderKey, LoggingDependencyActionToString(pAction->packageDependency.action)); | 2659 | LogStringLine(PlanDumpLevel, "%ls action[%u]: PACKAGE_DEPENDENCY package id: %ls, bundle provider key: %ls", wzBase, iAction, pAction->packageDependency.pPackage->sczId, pAction->packageDependency.sczBundleProviderKey); |
2660 | for (DWORD j = 0; j < pAction->packageProvider.pPackage->cDependencyProviders; ++j) | ||
2661 | { | ||
2662 | const BURN_DEPENDENCY_PROVIDER* pProvider = pAction->packageProvider.pPackage->rgDependencyProviders + j; | ||
2663 | LogStringLine(PlanDumpLevel, " Provider[%u]: key: %ls, action: %hs", j, pProvider->sczKey, LoggingDependencyActionToString(fRollback ? pProvider->dependentRollback : pProvider->dependentExecute)); | ||
2664 | } | ||
2658 | break; | 2665 | break; |
2659 | 2666 | ||
2660 | case BURN_EXECUTE_ACTION_TYPE_RELATED_BUNDLE: | 2667 | case BURN_EXECUTE_ACTION_TYPE_RELATED_BUNDLE: |
diff --git a/src/burn/engine/plan.h b/src/burn/engine/plan.h index 61953168..3e5ab159 100644 --- a/src/burn/engine/plan.h +++ b/src/burn/engine/plan.h | |||
@@ -213,7 +213,6 @@ typedef struct _BURN_EXECUTE_ACTION | |||
213 | { | 213 | { |
214 | BURN_PACKAGE* pPackage; | 214 | BURN_PACKAGE* pPackage; |
215 | LPWSTR sczBundleProviderKey; | 215 | LPWSTR sczBundleProviderKey; |
216 | BURN_DEPENDENCY_ACTION action; | ||
217 | } packageDependency; | 216 | } packageDependency; |
218 | struct | 217 | struct |
219 | { | 218 | { |